View Revisions: Issue #5051

Summary 0005051: Inherited rotation gets automatically overwritten on door classes
Revision 09.09.2019 00:58 by VanishedOne
Description When you create a rotating door, the default rotation isn't just inherited but explicitly set to 0 90 0 for that entity. I think that's because atdm:mover_door includes "editor_setKeyValue rotate" "0 90 0".

Entity classes that inherit from atdm:mover_door sometimes set their own values for "rotate", but typically don't override "editor_setKeyValue rotate", so the value they set is never actually inherited by an entity unless the mapper deletes the spawnarg from the entity.

A particularly odd case is that of atdm:mover_metal_cabinetdoor_l and atdm:mover_metal_cabinetdoor_r. They do set an editor value for translate of 0 0 0, which is unnecessary. They don't set one for rotate, so they get the atdm:mover_door default. This overrides the value they do have for rotate - which is 0 0 100 for both, resulting in a completely wrong rotation. And since they're a left and right pair, it's obvious the same rotation can't be correct for both.
Revision 09.09.2019 00:48 by VanishedOne
Description When you create a rotating door, the default rotation isn't just inherited but explicitly set to 0 90 0 for that entity. I think that's because atdm:mover_door includes "editor_setKeyValue rotate" "0 90 0".

Entity classes that inherit from atdm:mover_door sometimes set their own values for "rotate", but typically don't override "editor_setKeyValue rotate", so the value they set is never actually inherited by an entity unless the mapper deletes the spawnarg from the entity.

A particularly odd case is that of atdm:mover_metal_cabinetdoorl and atdm:mover_metal_cabinetdoorr. They do set an editor value for translate of 0 0 0, which is unnecessary. They don't set one for rotate, so they get the atdm:mover_door default. This overrides the value they do have for rotate - which is 0 0 100 for both, resulting in a completely wrong rotation. And since they're a left and right pair, it's obvious the same rotation can't be correct for both.