Changesets: DarkRadiant

master bd82dba4

13.09.2023 18:52

Matthew Mott


Details Diff
OrthoView::setViewType() is now setOrientation()
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.h Diff File
mod - radiant/xyview/OrthoView.cpp Diff File
mod - radiant/xyview/OrthoView.h Diff File

master c32e050a

13.09.2023 18:36

Matthew Mott


Details Diff
IOrthoView::getViewType() is now getOrientation()
mod - include/iorthoview.h Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiant/xyview/OrthoView.cpp Diff File
mod - radiant/xyview/OrthoView.h Diff File
mod - radiant/xyview/tools/XYMouseToolEvent.h Diff File

master 78a96778

12.09.2023 19:15

Matthew Mott


Details Diff
XYWnd is now OrthoView
mod - radiant/CMakeLists.txt Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.h Diff File
mv - radiant/xyview/XYWnd.cpp → radiant/xyview/OrthoView.cpp Diff File
mv - radiant/xyview/XYWnd.h → radiant/xyview/OrthoView.h Diff File

master cd19cb7b

06.09.2023 19:05

Matthew Mott


Details Diff
EViewType is now enum class OrthoOrientation
mod - include/iclipper.h Diff File
mod - include/iorthoview.h Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.h Diff File
mod - radiant/xyview/XYWnd.cpp Diff File
mod - radiant/xyview/XYWnd.h Diff File
mod - radiant/xyview/tools/BrushCreatorTool.cpp Diff File
mod - radiant/xyview/tools/CameraAngleTool.h Diff File
mod - radiant/xyview/tools/CameraMoveTool.h Diff File
mod - radiant/xyview/tools/ClipperTool.cpp Diff File
mod - radiant/xyview/tools/XYMouseToolEvent.h Diff File
mod - radiantcore/clipper/ClipPoint.cpp Diff File
mod - radiantcore/clipper/ClipPoint.h Diff File
mod - radiantcore/clipper/Clipper.cpp Diff File
mod - radiantcore/clipper/Clipper.h Diff File
mod - radiantcore/map/RegionManager.cpp Diff File
mod - radiantcore/patch/Patch.cpp Diff File
mod - radiantcore/patch/Patch.h Diff File
mod - radiantcore/patch/algorithm/Prefab.cpp Diff File
mod - radiantcore/patch/algorithm/Prefab.h Diff File
mod - radiantcore/selection/algorithm/Primitives.cpp Diff File
mod - radiantcore/selection/algorithm/SelectionPolicies.h Diff File
mod - radiantcore/selection/algorithm/Transformation.cpp Diff File
mod - radiantcore/selection/algorithm/Transformation.h Diff File

master 0aa99969

05.09.2023 19:12

Matthew Mott


Details Diff
XYWndManager implements IUserControlCreator directly

Instead of a local implementation of IUserControlCreator in the .cpp
file, the XYWndManager class now derives from IUserControlCreator and
implements its methods directly.
mod - include/ui/iuserinterface.h Diff File
mod - radiant/ui/UserInterfaceModule.cpp Diff File
mod - radiant/ui/UserInterfaceModule.h Diff File
mod - radiant/ui/einspector/EntityInspectorModule.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.h Diff File

master 33fb427c

29.08.2023 19:27

Matthew Mott


Details Diff
IUserControl is now IUserControlCreator

Clarify that this interface is responsible for *creating* user controls,
but is not necessarily implemented by the control itself.
mod - include/ui/iusercontrol.h Diff File
mod - include/ui/iuserinterface.h Diff File
mod - radiant/camera/CameraWndManager.cpp Diff File
mod - radiant/textool/TextureToolControl.h Diff File
mod - radiant/ui/UserInterfaceModule.cpp Diff File
mod - radiant/ui/UserInterfaceModule.h Diff File
mod - radiant/ui/aas/AasVisualisationControl.h Diff File
mod - radiant/ui/console/ConsoleControl.h Diff File
mod - radiant/ui/einspector/EntityInspectorModule.cpp Diff File
mod - radiant/ui/entitylist/EntityListControl.h Diff File
mod - radiant/ui/favourites/FavouritesBrowserControl.h Diff File
mod - radiant/ui/findshader/FindShaderControl.h Diff File
mod - radiant/ui/layers/LayerControl.h Diff File
mod - radiant/ui/lightinspector/LightInspectorControl.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserModule.cpp Diff File
mod - radiant/ui/merge/MapMergeControl.h Diff File
mod - radiant/ui/overlay/OrthoBackgroundControl.h Diff File
mod - radiant/ui/patch/PatchInspectorControl.h Diff File
mod - radiant/ui/script/ScriptPanel.h Diff File
mod - radiant/ui/surfaceinspector/SurfaceInspectorControl.h Diff File
mod - radiant/ui/texturebrowser/TextureBrowserManager.cpp Diff File
mod - radiant/ui/transform/TransformPanelControl.h Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File

master 1f6c8698

23.08.2023 19:15

Matthew Mott


Details Diff
Remove unused XYWndManager::getUniqueID()
mod - libs/wxutil/DockablePanel.h Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.h Diff File

master f08ac00b

23.08.2023 18:55

Matthew Mott


Details Diff
IXWndManager is now IOrthoViewManager

In addition to being a more accurate representation of the function of
this interface, this also fixes the typo in the previous name (no "Y" in
"IXWndManager").
mod - include/iorthoview.h Diff File
mod - libs/scene/SelectionIndex.cpp Diff File
mod - radiant/camera/tools/JumpToObjectTool.h Diff File
mod - radiant/ui/favourites/FavouritesBrowser.cpp Diff File
mod - radiant/ui/mainframe/MainFrame.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.h Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - radiantcore/map/PointFile.cpp Diff File
mod - radiantcore/map/RegionManager.cpp Diff File
mod - radiantcore/patch/algorithm/Prefab.cpp Diff File
mod - radiantcore/selection/algorithm/Primitives.cpp Diff File
mod - radiantcore/selection/algorithm/SelectionPolicies.h Diff File
mod - radiantcore/selection/algorithm/Transformation.cpp Diff File

master 166d9240

23.08.2023 18:33

Matthew Mott


Details Diff
XYWnd recent origin/scale stored as node content

Use the standard registry::getValue()/setValue() API to store and
retrieve the recent origin and scale values, rather than using custom
attributes on an XML node.
mod - radiant/xyview/XYWnd.cpp Diff File
mod - radiant/xyview/XYWnd.h Diff File

master cd3a24ef

22.08.2023 19:21

Matthew Mott


Details Diff
Use inline initialisation for XYWnd class members
mod - radiant/xyview/XYWnd.cpp Diff File
mod - radiant/xyview/XYWnd.h Diff File

master b1afc44e

09.08.2023 19:14

Matthew Mott


Details Diff
Registry stores keyvalues using XML content (not attributes)

Instead of storing key values in a "value" attribute on a node with no
content, the value is now stored as content and the legacy "value"
attribute (if present) is removed.

To retain backwards compatibility, a "value" attribute will still be
used for retrieval if the node does not contain any content.
mod - libs/xmlutil/Node.cpp Diff File
mod - libs/xmlutil/Node.h Diff File
mod - radiantcore/xmlregistry/RegistryTree.cpp Diff File
mod - radiantcore/xmlregistry/XMLRegistry.cpp Diff File
mod - test/Registry.cpp Diff File

master 7c711ba7

08.08.2023 19:10

Matthew Mott


Details Diff
Remove unused RegistryTree::get()

XMLRegistry never calls this method; its own get() method looks up the
value attribute directly.
mod - radiantcore/xmlregistry/RegistryTree.cpp Diff File
mod - radiantcore/xmlregistry/RegistryTree.h Diff File

master a124997f

02.08.2023 19:19

Matthew Mott


Details Diff
Remove some redundancy in XMLRegistry implementation

The get() method is now just forwarding to getAttribute() to obtain the
"value" attribute, then calling utf8_to_mb() on the returned string.
mod - radiantcore/xmlregistry/XMLRegistry.cpp Diff File

master f092d3b6

02.08.2023 19:12

Matthew Mott


Details Diff
Further tests for getting and setting registry keyvalues
mod - libs/xmlutil/Node.h Diff File
mod - test/Registry.cpp Diff File

master 6b234eb8

01.08.2023 19:22

Matthew Mott


Details Diff
Initial RegistryTest which tests getting some key values

Strangely we don't yet have a unit test for the registry itself,
although registry functionality is exercised as a component of many
other tests.
mod - test/CMakeLists.txt Diff File
add - test/Registry.cpp Diff File

master a00e7e56

26.07.2023 19:16

Matthew Mott


Details Diff
Move string constant out of iregistry.h

On Linux this gives a warning about possible ODR violation by having a
defined string constant in a header file. The constant is only used in
XMLRegistry.cpp so does not need to be exposed as part of the interface.
mod - include/iregistry.h Diff File
mod - radiantcore/xmlregistry/XMLRegistry.cpp Diff File

master 1360d3fe

25.07.2023 19:01

Matthew Mott


Details Diff
Remove all exception-based string::convert implementations

Using exceptions to detect conversion failures is terrible for
performance, and the need for an explicit specialisation for every type
so that a different std::sto[??]() function can be called negates the
benefit of using templates altogether.

There is now a generic implementation using stringstream, along with
specialisations for bool (which behaves differently to the usual
stream extraction) and std::string (which is a no-op).

The separate tryConvertTo{Float,Int}() which were introduced to improve
performance in certain hot code paths, are unaffected by this change.
mod - libs/string/convert.h Diff File

master 45ae7f0f

19.07.2023 19:32

Matthew Mott


Details Diff
Test string conversion to Vector3/4
mod - test/Basic.cpp Diff File

master f3640e07

19.07.2023 19:29

Matthew Mott


Details Diff
Fix bug in string conversion to Vector4

A stream extraction failure sets failbit, not badbit, therefore we need
to detect the error with fail().
mod - libs/string/convert.h Diff File

master 98e97c98

19.07.2023 19:12

Matthew Mott


Details Diff
Add tests for (rather strange) string-to-bool conversion
mod - test/Basic.cpp Diff File

master 8edc66a7

19.07.2023 18:31

Matthew Mott


Details Diff
Test string conversion to all basic numeric types
mod - test/Basic.cpp Diff File

master 0c0d6a7b

18.07.2023 19:27

Matthew Mott


Details Diff
Add basic tests for our string conversion functions
mod - test/Basic.cpp Diff File

master 97950da7

12.07.2023 19:26

Matthew Mott


Details Diff
Remove unneeded static methods from XYWnd

getViewTypeStr() was never called at all; getViewTypeTitle() can be
replaced with a simple map.
mod - radiant/xyview/XYWnd.cpp Diff File
mod - radiant/xyview/XYWnd.h Diff File

master 78d266d3

11.07.2023 19:36

Matthew Mott


Details Diff
Remove some duplication in XYWnd::snapToGrid()
mod - radiant/xyview/XYWnd.cpp Diff File

master ea20e9e6

06.06.2023 19:26

Matthew Mott


Details Diff
Streamline X/Y/Z members of RotateManipulator

Introduce a new struct template XYZ<T> which defines .x, .y and .z
members (but otherwise provides no functionality beyond mere
aggregation). This is used in RotateManipulator to reduce the need to
manually define separate _memberX, _memberY and _memberZ triplets for
various purposes.

The circle visibility members are removed entirely rather than placed in
an XYZ<bool>, since they are never referenced outside the function which
sets their values.
add - libs/math/XYZ.h Diff File
mod - radiantcore/selection/BasicSelectable.h Diff File
mod - radiantcore/selection/manipulators/Renderables.h Diff File
mod - radiantcore/selection/manipulators/RotateManipulator.cpp Diff File
mod - radiantcore/selection/manipulators/RotateManipulator.h Diff File
 First  Prev  1 2 3 4 5 6 7 8 ... 30 ... 60 ... 90 ... 120 ... 150 ... 180 ... 210 ... 240 ... 261 262 263  Next  Last