Changesets: DarkRadiant

undosystem 918a1ce2

26.10.2021 04:13

greebo


Details Diff
0005408: Refactoring Affected Issues
0005408
mod - radiantcore/undo/UndoSystem.cpp Diff File
mod - radiantcore/undo/UndoSystem.h Diff File

undosystem bb0e005a

26.10.2021 04:00

greebo


Details Diff
0005408: Remove unused method Affected Issues
0005408
mod - include/iundo.h Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File
mod - radiantcore/undo/UndoSystem.h Diff File

undosystem 62f57ba5

26.10.2021 03:51

greebo


Details Diff
0005408: Use the passed IMapRootNode to acquire the UndoSystem the nodes are connecting to Affected Issues
0005408
mod - include/iundo.h Diff File
mod - libs/ObservedUndoable.h Diff File
mod - libs/scene/Node.cpp Diff File
mod - libs/scene/Node.h Diff File
mod - libs/scene/SelectableNode.cpp Diff File
mod - libs/scene/SelectableNode.h Diff File
mod - libs/scene/TraversableNodeSet.cpp Diff File
mod - libs/scene/TraversableNodeSet.h Diff File
mod - radiantcore/brush/Brush.cpp Diff File
mod - radiantcore/brush/Brush.h Diff File
mod - radiantcore/brush/BrushNode.cpp Diff File
mod - radiantcore/brush/Face.cpp Diff File
mod - radiantcore/brush/Face.h Diff File
mod - radiantcore/entity/EntityNode.cpp Diff File
mod - radiantcore/entity/KeyValue.cpp Diff File
mod - radiantcore/entity/KeyValue.h Diff File
mod - radiantcore/entity/ModelKey.cpp Diff File
mod - radiantcore/entity/ModelKey.h Diff File
mod - radiantcore/entity/SpawnArgs.cpp Diff File
mod - radiantcore/entity/SpawnArgs.h Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.cpp Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.h Diff File
mod - radiantcore/entity/light/LightNode.cpp Diff File
mod - radiantcore/entity/light/LightNode.h Diff File
mod - radiantcore/map/RootNode.cpp Diff File
mod - radiantcore/map/RootNode.h Diff File
mod - radiantcore/model/StaticModel.cpp Diff File
mod - radiantcore/model/StaticModel.h Diff File
mod - radiantcore/model/StaticModelNode.cpp Diff File
mod - radiantcore/patch/Patch.cpp Diff File
mod - radiantcore/patch/Patch.h Diff File
mod - radiantcore/patch/PatchNode.cpp Diff File
mod - radiantcore/undo/StackFiller.h Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File

undosystem 1381730c

25.10.2021 19:31

greebo


Details Diff
0005408: No IMapFileChangeTracker reference is needed anymore when acquiring an undo state saver. Affected Issues
0005408
mod - include/iundo.h Diff File
mod - libs/ObservedUndoable.h Diff File
mod - libs/scene/BasicRootNode.h Diff File
mod - libs/scene/Node.cpp Diff File
mod - libs/scene/Node.h Diff File
mod - libs/scene/SelectableNode.cpp Diff File
mod - libs/scene/SelectableNode.h Diff File
mod - libs/scene/TraversableNodeSet.cpp Diff File
mod - libs/scene/TraversableNodeSet.h Diff File
mod - radiantcore/brush/Brush.cpp Diff File
mod - radiantcore/brush/Brush.h Diff File
mod - radiantcore/brush/BrushNode.cpp Diff File
mod - radiantcore/brush/Face.cpp Diff File
mod - radiantcore/brush/Face.h Diff File
mod - radiantcore/entity/EntityNode.cpp Diff File
mod - radiantcore/entity/KeyValue.cpp Diff File
mod - radiantcore/entity/KeyValue.h Diff File
mod - radiantcore/entity/ModelKey.cpp Diff File
mod - radiantcore/entity/ModelKey.h Diff File
mod - radiantcore/entity/SpawnArgs.cpp Diff File
mod - radiantcore/entity/SpawnArgs.h Diff File
mod - radiantcore/entity/doom3group/Doom3GroupNode.cpp Diff File
mod - radiantcore/map/RootNode.cpp Diff File
mod - radiantcore/model/StaticModel.cpp Diff File
mod - radiantcore/model/StaticModel.h Diff File
mod - radiantcore/model/StaticModelNode.cpp Diff File
mod - radiantcore/patch/Patch.cpp Diff File
mod - radiantcore/patch/Patch.h Diff File
mod - radiantcore/patch/PatchNode.cpp Diff File
mod - radiantcore/undo/StackFiller.h Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File
mod - radiantcore/undo/UndoSystem.h Diff File

undosystem 9a3824fc

25.10.2021 18:44

greebo


Details Diff
0005408: Rename interface header file to imapfilechangetracker.h Affected Issues
0005408
mod - include/imap.h Diff File
mod - include/precompiled_interfaces.h Diff File

undosystem d228c9c0

25.10.2021 18:44

greebo


Details Diff
0005408: Rename interface header file to imapfilechangetracker.h Affected Issues
0005408
mod - include/imap.h Diff File
mod - include/precompiled_interfaces.h Diff File
mod - libs/ObservedUndoable.h Diff File
mod - libs/UndoFileChangeTracker.h Diff File
mod - libs/scene/BasicRootNode.h Diff File
mod - libs/scene/TraversableNodeSet.cpp Diff File
mod - radiantcore/brush/Face.h Diff File
mod - radiantcore/entity/ModelKey.h Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - radiantcore/map/MapResource.cpp Diff File
mod - radiantcore/map/autosaver/AutoSaver.cpp Diff File
mod - radiantcore/map/autosaver/AutoSaver.h Diff File
mod - radiantcore/model/StaticModel.h Diff File
mod - radiantcore/patch/Patch.h Diff File
mod - radiantcore/undo/StackFiller.h Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File
mod - tools/msvc/include.vcxproj Diff File
mod - tools/msvc/include.vcxproj.filters Diff File

undosystem 86112a39

25.10.2021 18:41

greebo


Details Diff
0005408: Change IMapFileChangeTracker interface to use more descriptive names, add documentation. Affected Issues
0005408
mod - include/iundo.h Diff File
mod - include/mapfile.h Diff File

undosystem 0e6762ba

25.10.2021 18:18

greebo


Details Diff
0005408: The MapResource class no longer calls the internal GlobalMap() singleton to notify about status changes - it could be any map root node firing the change signal, not just the one loaded as primary map. The MapResource now offers a "modified status changed" signal which is subscribed by the main Map class owning it. As another refactoring step, the UndoFileChangeTracker is no longer using a single callback functor, since this can easily overridden if two MapResources are sharing the same root node (which is a valid use case during renaming). Affected Issues
0005408
mod - include/imapresource.h Diff File
mod - include/mapfile.h Diff File
mod - libs/UndoFileChangeTracker.h Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - radiantcore/map/Map.h Diff File
mod - radiantcore/map/MapResource.cpp Diff File
mod - radiantcore/map/MapResource.h Diff File
mod - test/UndoRedo.cpp Diff File

undosystem dc44cc06

25.10.2021 16:47

greebo


Details Diff
0005408: Remove the old pointer-to-member-based state machine in UndoFileChangeTracker. Remove the corresponding methods and the calls to it from UndoSystem. Affected Issues
0005408
mod - include/iundo.h Diff File
mod - include/mapfile.h Diff File
mod - libs/UndoFileChangeTracker.h Diff File
mod - radiantcore/undo/StackFiller.h Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File
mod - radiantcore/undo/UndoSystem.h Diff File

undosystem 2144bcbc

25.10.2021 16:21

greebo


Details Diff
0005408: Fix change tracker registration/deregistration leak when handling root nodes in the MapResource class. Affected Issues
0005408
mod - radiantcore/map/MapResource.cpp Diff File
mod - radiantcore/map/MapResource.h Diff File

undosystem b5439e45

25.10.2021 15:38

greebo


Details Diff
0005408: Change UndoSystem::Tracker interface which is implemented by the IMapFileChangeTracker. The MapResource is now monitoring the tracked change count and maintains the map modified state accordingly. Affected Issues
0005408
mod - include/iundo.h Diff File
mod - libs/UndoFileChangeTracker.h Diff File
mod - radiantcore/map/MapResource.cpp Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File

undosystem a53ba84f

24.10.2021 16:05

greebo


Details Diff
0005408: After some restructuring and a few paper cuts, the UndoSystem is now a child of the IMapRootNode implementations.
The GlobalUndoSystem() accessor now refers to the GlobalMapModule()'s undo system, the undo system module has been transformed into the GlobalUndoSystemFactory.
I'm not entirely happy with the way the Map module is subscribing to each map resource's undo system on map change, since the root node of a MapResource is not always available.
Affected Issues
0005408
mod - include/imap.h Diff File
mod - include/iundo.h Diff File
mod - libs/scene/BasicRootNode.h Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiantcore/CMakeLists.txt Diff File
mod - radiantcore/brush/BrushModule.cpp Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - radiantcore/map/Map.h Diff File
mod - radiantcore/map/RootNode.cpp Diff File
mod - radiantcore/map/RootNode.h Diff File
mod - radiantcore/undo/UndoSystem.cpp Diff File
mod - radiantcore/undo/UndoSystem.h Diff File
add - radiantcore/undo/UndoSystemFactory.cpp Diff File
mod - test/UndoRedo.cpp Diff File
mod - tools/msvc/DarkRadiantCore.vcxproj Diff File
mod - tools/msvc/DarkRadiantCore.vcxproj.filters Diff File

undosystem 3c688847

24.10.2021 07:13

greebo


Details Diff
0005408: Migrate UI classes to subscribe to the IMap postUndo/postRedo signals instead of the GlobalUndoSystem() Affected Issues
0005408
mod - plugins/dm.editing/AIEditingPanel.cpp Diff File
mod - radiant/textool/TexTool.cpp Diff File
mod - radiant/ui/lightinspector/LightInspector.cpp Diff File
mod - radiant/ui/merge/MergeControlDialog.cpp Diff File
mod - radiant/ui/patch/PatchInspector.cpp Diff File
mod - radiant/ui/surfaceinspector/SurfaceInspector.cpp Diff File
mod - radiantcore/selection/shaderclipboard/ShaderClipboard.cpp Diff File

undosystem 1154843d

24.10.2021 07:04

greebo


Details Diff
0005408: Prepare to move the postUndo/postRedo signals to the IMap interface. Subscribers should keep getting notified after changing maps, so it's better if they subscribe to IMap instead of the GlobalUndoSystem. Add corresponding unit tests. Affected Issues
0005408
mod - include/imap.h Diff File
mod - radiantcore/map/Map.cpp Diff File
mod - radiantcore/map/Map.h Diff File
mod - test/UndoRedo.cpp Diff File

undosystem 4f676735

24.10.2021 05:35

greebo


Details Diff
0005408: Set up a test featuring two unrelated scene graphs. The test fails since the main scene undo command affects the second scene. Affected Issues
0005408
mod - test/UndoRedo.cpp Diff File

undosystem 0a891f9d

24.10.2021 05:14

greebo


Details Diff
0005408: Test the map file change tracker which should be tagging the map as modified or unmodified depending on the position in the undo history. Affected Issues
0005408
mod - test/UndoRedo.cpp Diff File

undosystem 28c612e5

24.10.2021 03:42

greebo


Details Diff
0005408: Add test corresponding to issue number 2118 Affected Issues
0005408
mod - test/UndoRedo.cpp Diff File
add - test/resources/tdm/def/moveable.def Diff File
add - test/resources/tdm/def/mover_door.def Diff File
add - test/resources/tdm/def/tdm_frobable.def Diff File

undosystem d9dda734

23.10.2021 16:53

greebo


Details Diff
0005408: One more test documenting the current behaviour when undoing/redoing scene node removals Affected Issues
0005408
mod - test/UndoRedo.cpp Diff File

undosystem bf68b4f3

23.10.2021 14:55

greebo


Details Diff
0005408: Add a few tests covering the most important behaviour of the undo system Affected Issues
0005408
mod - test/UndoRedo.cpp Diff File

undosystem eff78cb7

23.10.2021 14:05

greebo


Details Diff
0005408: Start creating a few unit tests to check the existing behaviour Affected Issues
0005408
mod - test/CMakeLists.txt Diff File
add - test/UndoRedo.cpp Diff File
mod - tools/msvc/Tests/Tests.vcxproj Diff File
mod - tools/msvc/Tests/Tests.vcxproj.filters Diff File

master 7e6b051e

23.10.2021 05:12

greebo


Details Diff
0005785: Fix a face selected using Ctrl-Shift-LMB preventing any other scene element from showing up in the texture tool. Affected Issues
0005785
mod - radiantcore/selection/textool/TextureToolSceneGraph.cpp Diff File

master fae8ba07

23.10.2021 05:08

greebo


Details Diff
0005785: Adjust TexToolRotateSelected algorithm to respect the texture aspect ratio Affected Issues
0005785
mod - radiantcore/selection/algorithm/Texturing.cpp Diff File
mod - radiantcore/selection/textool/TextureToolSelectionSystem.cpp Diff File
mod - test/TextureTool.cpp Diff File

master 94c045a2

23.10.2021 04:18

greebo


Details Diff
0005785: Add (failing) unit test checking patch texture rotation Affected Issues
0005785
mod - test/TextureManipulation.cpp Diff File

master 7089876c

23.10.2021 04:04

greebo


Details Diff
0005785: Add IPatch::getTextureAspectRatio() and corresponding unit test Affected Issues
0005785
mod - include/ipatch.h Diff File
mod - libs/SurfaceShader.h Diff File
mod - radiantcore/brush/Face.cpp Diff File
mod - radiantcore/patch/Patch.cpp Diff File
mod - radiantcore/patch/Patch.h Diff File
mod - test/TextureManipulation.cpp Diff File

master 5a8213b7

22.10.2021 18:18

greebo


Details Diff
Rewrite portable brush export unit test, the last post-comma digit can differ between builds.
mod - test/MapExport.cpp Diff File
 First  Prev  1 2 3 ... 30 ... 60 ... 87 88 89 90 91 92 93 ... 120 ... 150 ... 180 ... 210 ... 240 ... 260 261 262  Next  Last