View Issue Details

IDProjectCategoryView StatusLast Update
0004187DarkRadiantGeneralpublic19.06.2016 16:53
Reportercoldtobi Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionfixed 
PlatformLinux OSDebianOS Version8 /Jessie
Product Version2.0.2 
Target Version2.0.3Fixed in Version2.0.3 
Summary0004187: configure.ac: needs call to AM_GNU_GETTEXT_VERSION, does not find de.po
DescriptionI was looking into packagein darkradiant for Debian and while on it I found a issue with the localiazation.

one thing is to ad AM_GNU_GETTEXT_VERSION to configure.ac, otherwise autoreconf won't install all required files and fail later in the build ("missing ABOUT-NLS")

Example patch (not sure what version of gettext you require; I used the latest in Debian)

[code]
AM_GNU_GETTEXT_VERSION(0.19.4)
AM_GNU_GETTEXT([external])
[/code]
Steps To Reproduce- unpack source
- issue autoreconf -if

autoreconf: configure.ac: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
configure.ac:8: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:8: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:8: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
Makefile.am: installing './INSTALL'
Makefile.am: installing './COPYING' using GNU General Public License v3 file
Makefile.am: Consider adding the COPYING file to the version control system
Makefile.am: for your code, to avoid questions about which license your project uses
configure.ac:8: error: required file './ABOUT-NLS' not found
autoreconf: automake failed with exit status: 1
TagsNo tags attached.

Activities

greebo

greebo

30.07.2015 11:15

administrator   ~0007676

I'm not really an expert on automake, but I'm happy to commit the patch if it's safe for other systems than Debian as well? Will it affect building on other automake platforms?
coldtobi

coldtobi

30.07.2015 19:53

reporter   ~0007678

automake is pretty portable, so I guess there won't be problems.

Also the documentation for AM_GNU_GETTEXT_VERSION does not indicate any platform dependencies.
Of course, you can choose an older gettext version, like 0.18.1 to ensure better availability on other platforms...

Hoever, it is easy to test; just run autoreconf ...
greebo

greebo

29.12.2015 09:06

administrator   ~0007926

I've added

AM_GNU_GETTEXT_VERSION(0.18.1)

to configure.ac, let's hope this does the trick.

Issue History

Date Modified Username Field Change
29.07.2015 08:19 coldtobi New Issue
30.07.2015 11:14 greebo Status new => acknowledged
30.07.2015 11:15 greebo Note Added: 0007676
30.07.2015 11:15 greebo Status acknowledged => feedback
30.07.2015 19:53 coldtobi Note Added: 0007678
30.07.2015 19:53 coldtobi Status feedback => new
29.12.2015 09:05 greebo Assigned To => greebo
29.12.2015 09:05 greebo Status new => assigned
29.12.2015 09:05 greebo Target Version => 2.0.3
29.12.2015 09:06 greebo Note Added: 0007926
29.12.2015 09:06 greebo Status assigned => resolved
29.12.2015 09:06 greebo Fixed in Version => 2.0.3
29.12.2015 09:06 greebo Resolution open => fixed
19.06.2016 16:53 greebo Status resolved => closed