View Issue Details

IDProjectCategoryView StatusLast Update
0000460DarkRadiantGUIpublic31.12.2008 18:20
ReporterSneaksieDave Assigned Togreebo  
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.9.4 
Target Version0.9.9Fixed in Version0.9.9 
Summary0000460: Cannot use 'Choose model' for existing to change skin
DescriptionVery minor:

If you create a model anew, the model is created with whichever skin you chose at the time of creation.

However, if you select a previously created model, go to the model field, and hit 'Choose model...' (as if to change the model), if you choose the same model but with a different skin, the model is not changed, the skin is not added.
TagsNo tags attached.

Activities

orbweaver

orbweaver

11.12.2007 21:10

developer   ~0000924

This is a UI problem -- you are editing only a single key ("model"), so it would be incorrect for the Model Selector to change another key ("skin") outside of the current PropertyEditor. The ModelSelector should have an option whether to display skins or not, and if it is invoked from the EntityInspector the skins should not be shown.
orbweaver

orbweaver

17.12.2007 09:38

developer   ~0000926

Investigated how to hide the skins. Not adding them during construction if a parameter is set does not work because the dialog is persistent, and will not be constructed more than once. The most appropriate tool appears to be the GtkTreeModelFilter, which wraps a GtkTreeModel and provides filtering capabilities, but unfortunately (1) this seems to break sorting, because the GtkTreeView expects the underlying GtkTreeModel to implement the GtkTreeSortable interface (which GtkTreeStore does, but GtkTreeModelFilter doesn't), and (2) it seems impossible to reset the GtkTreeModelFilterVisibleFunc once it has been set, meaning that this cannot be used to switch filtering on and off.

More investigation needed.
greebo

greebo

15.04.2008 11:45

administrator   ~0001139

Last edited: 15.04.2008 11:46

How about adding a submenu to the orthoview's context menu?

Like this:
+
|-Create Entity
----------------
|-Model... >>> Create...
|          >>> Change Model...
|          >>> Change Skin...
|          >>> Surround with Monsterclip
|          >>> Surround with Playerclip
----------------
.... 


orbweaver

orbweaver

15.04.2008 16:41

developer   ~0001140

That would be reasonable from a usability point of view, but the issue with skins being displayed in the "Select model" dialog for the ModelPropertyEditor would still need to be solved somehow. It might be easiest just to create two GtkTreeStore's in parallel and switch the GtkTreeView between the two models depending on whether skins should be displayed or not.
greebo

greebo

30.06.2008 14:06

administrator   ~0001399

I think the solution of having two separate treemodels in the background is a pragmatic one.

Do you mind if I look into this?
greebo

greebo

29.12.2008 08:09

administrator   ~0002269

Fixed by maintaining two separate treemodels.

Issue History

Date Modified Username Field Change
11.12.2007 16:53 SneaksieDave New Issue
11.12.2007 21:10 orbweaver Note Added: 0000924
11.12.2007 21:10 orbweaver Status new => confirmed
12.12.2007 10:37 orbweaver Status confirmed => assigned
12.12.2007 10:37 orbweaver Assigned To => orbweaver
12.12.2007 21:07 orbweaver Target Version => 0.9.5
17.12.2007 09:38 orbweaver Note Added: 0000926
21.12.2007 16:33 orbweaver Target Version 0.9.5 => 0.9.6
05.04.2008 08:02 greebo Target Version 0.9.6 => 0.9.7
13.04.2008 07:45 orbweaver Severity trivial => minor
15.04.2008 11:45 greebo Note Added: 0001139
15.04.2008 11:46 greebo Note Edited: 0001139
15.04.2008 16:41 orbweaver Note Added: 0001140
30.06.2008 14:06 greebo Note Added: 0001399
20.08.2008 19:39 greebo Target Version 0.9.7 => 0.9.8
07.12.2008 07:36 greebo Target Version 0.9.8 => 0.9.9
29.12.2008 08:08 greebo Assigned To orbweaver => greebo
29.12.2008 08:09 greebo Note Added: 0002269
29.12.2008 08:09 greebo Status assigned => resolved
29.12.2008 08:09 greebo Fixed in Version => 0.9.9
29.12.2008 08:09 greebo Resolution open => fixed
29.12.2008 08:10 greebo Projection none => minor fix
29.12.2008 08:10 greebo ETA none => < 1 day
29.12.2008 08:10 greebo Build => 3989
31.12.2008 18:20 SneaksieDave Status resolved => closed