0004710: Changing entity class from the spawnargs moves it to the Active Layer

ID	Project	Category	View Status	Date Submitted	Last Update

0004710	DarkRadiant	Map Editing	public	23.12.2017 20:24	09.01.2020 19:25

Reporter	Spooks	Assigned To	greebo
Priority	normal	Severity	normal	Reproducibility	sometimes
Status	closed	Resolution	fixed
Product Version	2.5.0
Target Version	2.6.0	Fixed in Version	2.6.0

Summary	0004710: Changing entity class from the spawnargs moves it to the Active Layer
Description	I have had several instances in my WIP where I had to change entities from an LOD entity back to a func_static. Whenever I've done this (via the copy/paste spawnarg command) I found that the converted func_statics were now in the Default layer, rather than the one they were in, originally.
Additional Information	I've set the reproducibility to "Sometimes" since, on a fresh map a couple of weeks ago, I could not reproduce the problem. I just experienced the bug for the second time, however, so it's definitely real.
Tags	No tags attached.

greebo 28.12.2017 06:33 administrator ~0009898	For clarification, you've been changing the class by copy/pasting the "classname" keyvalue over the target entity?

greebo 28.12.2017 06:48 administrator ~0009899	Nevermind, I can see the issue in the code. The changed entity will get moved to the Active Layer, which might be the "Default" layer of any other layer currently marked with the asterisk symbol. Child primitives are remaining in their own layer, so things get a bit skewed by that operation. I'll fix the code to let the affected entity retain its layer assignments.

greebo 28.12.2017 06:54 administrator ~0009900	Resolved in 7bf7d1e

Date Modified	Username	Field	Change
23.12.2017 20:24	Spooks	New Issue
24.12.2017 05:23	greebo	Status	new => acknowledged
28.12.2017 06:33	greebo	Note Added: 0009898
28.12.2017 06:48	greebo	Note Added: 0009899
28.12.2017 06:48	greebo	Status	acknowledged => confirmed
28.12.2017 06:48	greebo	Assigned To	=> greebo
28.12.2017 06:48	greebo	Status	confirmed => assigned
28.12.2017 06:49	greebo	Product Version	2.4.0 => 2.5.0
28.12.2017 06:49	greebo	Target Version	=> 2.6.0
28.12.2017 06:54	greebo	Note Added: 0009900
28.12.2017 06:54	greebo	Status	assigned => resolved
28.12.2017 06:54	greebo	Fixed in Version	=> 2.6.0
28.12.2017 06:54	greebo	Resolution	open => fixed
28.12.2017 06:54	greebo	Summary	Changing entity class from the spawnargs reverts it to Default Layer => Changing entity class from the spawnargs moves it to the Active Layer
28.12.2019 11:00	greebo	Status	resolved => closed
09.01.2020 19:25	greebo	Changeset attached	=> DarkRadiant master 7bf7d1e1

DarkRadiant: master 7bf7d1e1 28.12.2017 07:53 greebo Details Diff	Resolve 0004710: Changing entity class from the spawnargs reverts it to Default Layer		Affected Issues 0004710
	mod - libs/entitylib.h		Diff File