View Issue Details

IDProjectCategoryView StatusLast Update
0005216The Dark ModScript/Defpublic03.12.2020 04:35
ReporterBikerdude Assigned Tonbohr1more  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
PlatformPCOSWindowsOS Version10
Product VersionSVN 
Target VersionTDM 2.09Fixed in VersionTDM 2.09 
Summary0005216: atdm:lamp_wall_gasflame03_lit - playing lit sound when extinguished/unlit
DescriptionI did a search in an export of all the bug trackers and didnt find anything with 'gasflame'. As I could have sworn this got fixed ages ago..?
Steps To Reproduce1. load up any map with this entity in
2. douse it with a water arrow or set as 'extinguished' '1'
3. player cant still hear the gas sound
TagsNo tags attached.

Activities

Bikerdude

Bikerdude

16.04.2020 16:10

reporter   ~0012366

This has been broken since 2.0.
Bikerdude

Bikerdude

07.05.2020 12:25

reporter   ~0012473

I have tried finding a work around for this, but got nowhere.
Bikerdude

Bikerdude

09.10.2020 21:15

reporter   ~0012806

Can someone point me where I need to look to try and resolve this..?
Dragofer

Dragofer

10.10.2020 09:20

developer   ~0012813

The entity is set up in tdm_lights_static_gas.def. Probably a problem with the snd spawnargs not being correctly set.
Bikerdude

Bikerdude

10.10.2020 09:43

reporter   ~0012814

Thanks, I will have a look and post back.
Bikerdude

Bikerdude

02.12.2020 14:57

reporter   ~0013069

I found and fixed the issue -

1. the entity 'atdm:lamp_wall_gasflame03_unlit' had sound args incorrectly added, that should have been added to the attached flame entity.
2. I added the missing sound args and lowered the volume of the 'light_gasflame' entity.

-----------------------------------------

// Fixed gasflame03 entity - this need to replace the exiting section 'tdm_lights_static_gas.def' starting on line 109 //

entityDef atdm:lamp_wall_gasflame03_unlit
{
    "inherit" "atdm:torch_wall"
    "model" "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
     "editor_displayFolder" "Lights/Model Lights, Static/Switchable/Gas/"
    "editor_usage" "An unlit wall-mounted gas lamp with an open top. "

    "extinguished" "1"
    "noshadows_lit" "1" // turn off shadow when lit
    "noshadows" "1" // lit, so has no shadows

    "light_center" "-1 0 7"
    "editor_setKeyValue light_center" "-1 0 7"

    "def_attach" "light_gasflame_unlit"
    "pos_attach" "flame" // At the attach point called "flame"...
    "attach_pos_name_1" "flame" // ... which is defined here.
    "name_attach" "flame" // Give it a name to pass along spawnargs
    "attach_pos_origin_1" "-1 0 7.5" // Offset the flame

    "skin" "lights/gaslight_brass_unlit"
    "skin_lit" "lights/gaslight_brass"
    "skin_unlit" "lights/gaslight_brass_unlit"
    "texture" "lights/biground1"
}


entityDef atdm:lamp_wall_gasflame03_lit
{
    "inherit" "atdm:lamp_wall_gasflame03_unlit"
    "editor_displayFolder" "Lights/Model Lights, Static/Gas"
    "editor_usage" "A lit wall-mounted gas lamp with an open top. Can be put out with water arrows."
    
    "def_attach" "light_gasflame"
    "pos_attach" "flame" // At the attach point called "flame"...
    "attach_pos_name_1" "flame" // ... which is defined here.
    "name_attach" "flame" // Give it a name to pass along spawnargs
    "attach_pos_origin_1" "-1 0 7.5" // Offset the flame
    "extinguished" "0"
    "skin" "lights/gaslight_brass"

}

// Fixed light_gasflame entity - this need to replace the exiting section in 'tdm_lights.def" starting on line 866 //

entitydef light_gasflame
{
    "inherit" "light_extinguishable"

    "editor_usage" "Static extinguishable candle flame with attached glow. (Light origin does not move to simulate flickering)"
    "editor_displayFolder" "Lights/Light Sources/Candle Flames"

    "mins" "-1 -1 -2"
    "maxs" "1 1 2"

    "model_lit" "tdm_fire_candle.prt"
    "model_extinguished" "tdm_smoke_candleout.prt"
    
    "falloff" "0"
    "texture" "lights/biground_candleflicker_shadow"
    "_color" "0.80 0.6 0.23"
    "light_radius" "230 230 210"

    "snd_lit" "gaslight"
    "snd_extinguished" "tdm_candle_extinguish"
    
    "s_volume" "-15"

    "sr_radius_4" "5"
    "sr_magnitude_4" "0.1"
    
    "should_be_vert" "1"
    
    "canBeBlownOut" "1"
    "editor_setKeyValue canBeBlownOut" "1"
}

--------------------------------------------------------

Can someone on the team please confirm and commit please.
nbohr1more

nbohr1more

02.12.2020 15:56

developer   ~0013072

Ill try to review this tonight
Bikerdude

Bikerdude

02.12.2020 16:40

reporter   ~0013073

Grand.
nbohr1more

nbohr1more

03.12.2020 04:34

developer   ~0013081

Rev 16028

I decreased the audio -10

-15 made it so you had to be right up against the lamp to hear it.

My understanding is that the audio should clue the player about how the light works from a distance.

Issue History

Date Modified Username Field Change
14.04.2020 14:19 Bikerdude New Issue
16.04.2020 16:10 Bikerdude Note Added: 0012366
07.05.2020 12:25 Bikerdude Note Added: 0012473
09.10.2020 21:15 Bikerdude Note Added: 0012806
10.10.2020 09:20 Dragofer Note Added: 0012813
10.10.2020 09:43 Bikerdude Note Added: 0012814
02.12.2020 14:57 Bikerdude Note Added: 0013069
02.12.2020 15:55 nbohr1more Assigned To => nbohr1more
02.12.2020 15:55 nbohr1more Status new => assigned
02.12.2020 15:56 nbohr1more Note Added: 0013072
02.12.2020 16:40 Bikerdude Note Added: 0013073
03.12.2020 04:34 nbohr1more Note Added: 0013081
03.12.2020 04:35 nbohr1more Status assigned => resolved
03.12.2020 04:35 nbohr1more Resolution open => fixed
03.12.2020 04:35 nbohr1more Fixed in Version => TDM 2.09
03.12.2020 04:35 nbohr1more Target Version => TDM 2.09