View Issue Details

IDProjectCategoryView StatusLast Update
0006173DarkRadiantMap Editingpublic13.01.2024 05:34
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status closedResolutionfixed 
Product Version3.6.0 
Target Version3.7.0Fixed in Version3.7.0 
Summary0006173: Def parsing problem in tdm_playertools_lockpicks.def
DescriptionThe decl parser seems to have problems with this file, the triangle and snake lockpick defs are not recognised properly.

The problem lies within the double quotes in the comment strings, like:
// this"
TagsNo tags attached.

Activities

greebo

greebo

18.11.2022 11:13

administrator  

tdm_playertools_lockpicks.def (1,335 bytes)   
/**
 * These are the various lockpick definitions.
 */

entityDef atdm:playertool_lockpick_base
{
	"inherit"				"atdm:playertool"

	"editor_usage"			"Base Lockpick (do not use)"

	"model"					"" // to be defined in the subclasses

	"lockpick_type"			"" // to be defined in the subclasses
	"inv_category"			"#str_02389"	// Lockpicks"

	"inv_name"				"" // to be defined in the subclasses
	"inv_icon"				"" // to be defined in the subclasses

	"inv_cont_use"			"1"	// This use is continously going on
	"inv_use_on_frob"		"1"	// use lockpicks when frobbing things

    "inv_frob_distance_cap"	"40" // maximum frob distance when this item is selected
}


entityDef atdm:playertools_lockpick_snake
{
	"inherit"				"atdm:playertool_lockpick_base"

	"editor_usage"			"Snake Lockpick"

	"model"					"models/darkmod/player_equipment/lockpick_snake.lwo"
	"lockpick_type"			"s"

	"inv_name"			"#str_02201"		// Snake Lockpick
	"inv_icon"				"guis/assets/hud/inventory_icons/lockpick_snake_icon"
}

entityDef atdm:playertools_lockpick_triangle
{
	"inherit"				"atdm:playertool_lockpick_base"

	"editor_usage"			"Triangle Lockpick"

	"model"					"models/darkmod/player_equipment/lockpick_triangle.lwo"
	"lockpick_type"			"t"

	"inv_name"			"#str_02200"		// Triangle Lockpick
	"inv_icon"				"guis/assets/hud/inventory_icons/lockpick_triangle_icon"
}
tdm_playertools_lockpicks.def (1,335 bytes)   

Related Changesets

DarkRadiant: master 2329d409

18.11.2022 15:14

greebo


Details Diff
0006173: Add unit test covering the problematic sequences Affected Issues
0006173
mod - test/DefBlockSyntaxParser.cpp Diff File

DarkRadiant: master 2204fe17

18.11.2022 17:23

greebo


Details Diff
0006173: Fix DefBlockSyntaxTokeniserFunc to deal with quotes within comments Affected Issues
0006173
mod - libs/parser/DefBlockSyntaxParser.h Diff File
mod - test/DefBlockSyntaxParser.cpp Diff File

Issue History

Date Modified Username Field Change
18.11.2022 11:13 greebo New Issue
18.11.2022 11:13 greebo File Added: tdm_playertools_lockpicks.def
18.11.2022 11:14 greebo Status new => acknowledged
18.11.2022 17:24 greebo Changeset attached => DarkRadiant master 2329d409
18.11.2022 17:24 greebo Changeset attached => DarkRadiant master 2204fe17
18.11.2022 17:24 greebo Assigned To => greebo
18.11.2022 17:24 greebo Status acknowledged => assigned
18.11.2022 17:24 greebo Target Version => 3.7.0
18.11.2022 17:24 greebo Description Updated
18.11.2022 17:24 greebo Status assigned => resolved
18.11.2022 17:24 greebo Resolution open => fixed
18.11.2022 17:24 greebo Fixed in Version => 3.7.0
13.01.2024 05:34 greebo Status resolved => closed