 |
Committed at rev 6083 |
 |
The same issue happens for light passing through visportals. Before 0005172, this could happen only if static light happens to be almost exactly on a plane with several visportals, so nobody caught it. After 0005172, the code runs for dynamic lights as well, and this the issue happens as easily as for view/player. I added test map FloodLightThroughPortals_Overflow.map. Grab the candle (with heavily increased light radius) and try to cross some visportal between rooms. |
|
|
If the source point is within 0.1 distance from portal plane, then the code allows to go through the portal both directions. Also in this case it does not clip the light beam, because that would generate imprecise light beam. This allows passing through several portals on same plane many times --- not infinite though, because passing through same portal twice on single light beam path is forbidden. I was trying to invent some solid solution that would guarantee no complexity explosion from such "pass-through" portals, without any dependency on geometry/floats. But I quickly gave up and decided to reuse with SteveL's solution. Basically, we allow the pass-through code path only when the source point lies on the visportal polygon (with tolerance up to 1.0 doom unit). If the source point is on the portal plane but it is far outside the portal winding, then we use the usual code with clipping. I only made a tiny improvement here: SteveL's code checks point against bounding box of the portal. Now point is precisely checked against the polygon/winding of the portal. Committed in svn rev 10464. |
- Anonymous
