0005824: 2.14pre2: Spawnarg field should not be changed when selection has "differing values"

ID	Project	Category	View Status	Date Submitted	Last Update

0005824	DarkRadiant	GUI	public	25.11.2021 19:03	19.08.2022 15:33

Reporter	Dragofer	Assigned To	greebo
Priority	normal	Severity	normal	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	2.14.0
Target Version	2.14.0	Fixed in Version	2.14.0

Summary	0005824: 2.14pre2: Spawnarg field should not be changed when selection has "differing values"
Description	One of the new features in DR 2.14 is to show all spawnargs of selected entities in the entity inspector. If clicking on a spawnarg of an entity, then selecting another entity which has a different value for that spawnarg, then the spawnarg field for manual entry is overwritten by "[differing values]". This makes it quite easy to accidentally apply spawnargs with the value "[differing values]" when clicking on the checkmark.
Steps To Reproduce	1) Create two stagecoach models. 2) Select the first stagecoach and click on its "name" spawnarg in the entity. The spawnarg fields for manual entry now read "name" "func_static_1". 3) Expand the selection to the second stagecoach using Shift + LMB. The spawnarg fields for manual entry now read "name" "[differing values]". This is the bug, my expected value is still "name" "func_static_1". 4) Deselect both stagecoaches by pressing Escape. The spawnarg fields for manual entry now read "name" "func_static_2" instead of "func_static_1".
Tags	No tags attached.

DarkRadiant: master d75a62a1 27.11.2021 05:27 greebo Details Diff	0005824: First part of the fix, don't write the multi-value placeholder to the entry box on updates	Affected Issues 0005824
	mod - include/version.h	Diff File
	mod - radiant/ui/einspector/EntityInspector.cpp	Diff File
	mod - radiant/ui/einspector/EntityInspector.h	Diff File
DarkRadiant: master 55adce1a 27.11.2021 05:50 greebo Details Diff	0005824: Add unit test to assert the desired behaviour of the spawnarg collection when all entities are removed	Affected Issues 0005824
	mod - test/EntityInspector.cpp	Diff File
DarkRadiant: master 92b2fe61 27.11.2021 06:17 greebo Details Diff	0005824: Implement the special algorithm for removing all entities from the selection	Affected Issues 0005824
	mod - libs/selection/CollectiveSpawnargs.h	Diff File
	mod - libs/selection/EntitySelection.h	Diff File

Date Modified	Username	Field	Change
25.11.2021 19:03	Dragofer	New Issue
25.11.2021 19:04	Dragofer	Description Updated
26.11.2021 05:09	greebo	Status	new => acknowledged
26.11.2021 10:38	Dragofer	Note Added: 0014567
27.11.2021 05:26	greebo	Status	acknowledged => confirmed
27.11.2021 05:27	greebo	Assigned To	=> greebo
27.11.2021 05:27	greebo	Status	confirmed => assigned
27.11.2021 06:17	greebo	Target Version	=> 2.14.0
27.11.2021 06:17	greebo	Changeset attached	=> DarkRadiant master d75a62a1
27.11.2021 06:17	greebo	Changeset attached	=> DarkRadiant master 55adce1a
27.11.2021 06:17	greebo	Changeset attached	=> DarkRadiant master 92b2fe61
27.11.2021 06:18	greebo	Status	assigned => resolved
27.11.2021 06:18	greebo	Resolution	open => fixed
27.11.2021 06:18	greebo	Fixed in Version	=> 2.14.0
19.08.2022 15:33	greebo	Status	resolved => closed

Dragofer 26.11.2021 10:38 developer ~0014567	As an aside, maybe the checkmark to apply the spawnarg should do nothing or even post an error message if attempting to apply "[differing values]" as a spawnarg value.