 |
Hi I'm taking a look into this. Thanks. |
|
|
Am able to consistently reproduce the issue. Have debugged the code and understand what 'seems' to be happening. Basically in when one clicks 'resume' from the main menu with mouse button (attack) there is no transition, no pause and reset of the buttons state. The effect of which is in player.cpp -> Weapon_Combat() -> approx line 3691 where the call to FireWeapon is made immediatly. What needs to happen is post click of 'resume' mouse button attack state needs to pass through a release and the press process in order to trigger again. Now in process of working out why this does not happen.... |
 |
I guess this piece of code gets called: if ( ( usercmd.buttons & BUTTON_ATTACK ) && !weaponGone ) { FireWeapon(); ? Looking at the code, it might be hard to detct that the BUTTON_ATTACK came from the menu and when we are in this routine, that the menu was just closed. I see two basic ways to fix this: * in the menu, stop the button to propagate (this might be hard) * in the menu (GUI), set a variable/c_var that tells "heh, this button was just clicked but inside the GUI". We technially need only do this for the "Resume game" button. Then the C++ code can check that variable and if true, reset it to false and ignore the click. But you are probably onto this already :) Just trying to give some hints. |
|
|
Tested as fix successful. Sent PM to Tels. game_local.h 435: // Solarsplace 19th Nov 2010 - Bug tracker id 0002424 bool mainMenuExitHasDisabledAttack; game_local.cpp 224: // Solarsplace 19th Nov 2010 - Bug tracker id 0002424 mainMenuExitHasDisabledAttack = false; game_local.cpp 3454: // Solarsplace 19th Nov 2010 - Bug tracker id 0002424 mainMenuExitHasDisabledAttack = true; player.cpp 7084: *** This must be added just after these lines: // grab out usercmd usercmd_t oldCmd = usercmd; usercmd = gameLocal.usercmds[ entityNumber ]; buttonMask &= usercmd.buttons; usercmd.buttons &= ~buttonMask; // Solarsplace 19th Nov 2010 - Bug tracker id 0002424 bool allowAttack = false; if ( gameLocal.mainMenuExitHasDisabledAttack && ( usercmd.buttons & BUTTON_ATTACK ) ) { allowAttack = false; } else { allowAttack = true; gameLocal.mainMenuExitHasDisabledAttack = false; } player.cpp 7259: // Solarsplace 19th Nov 2010 - Bug tracker id 0002424 - Addition to existing condition if (frobbedEnt != NULL && usercmd.buttons & BUTTON_ATTACK && !(oldButtons & BUTTON_ATTACK) && allowAttack) 7279: // Solarsplace 19th Nov 2010 - Bug tracker id 0002424 - Addition to existing condition } else if ( health > 0 && allowAttack) { |
 |
Cool. I've been busted a few times because of this one. |
|
|
Should be fixed with revison 0004333. Thank you Solarsplace! |
- Anonymous
