View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002547The Dark ModScript/Defpublic16.01.2011 10:2305.10.2017 17:32
Reportertels Assigned To 
PrioritylowSeveritynormalReproducibilityhave not tried
Status closedResolutionunable to reproduce 
Product VersionTDM 1.03 
Target VersionTDM 2.05Fixed in VersionTDM 2.05 
Summary0002547: Stim Response for lights need updating
DescriptionFunctions defined in script/tdm_response_effects.script seem to not work together with our tdm_light_holder script. They do call simply $light.Off() instead of the better $light.LightsOff() if available.

Also, the light fade script manually fades the light, instead of just calling Fade().

So make a testmap, and then update them and see if anything breaks or things work now (multiple flame objects f.i.).
Additional InformationExample:

void effect_light_off_action(entity owner, entity stimEnt, string effectPostfix, float magnitude, float threadNum) {
        if (!isActive(owner, effectPostfix)) return;

        // Search for something like "sr_effect_1_1_argN"
        string argRoot = "sr_effect_" + effectPostfix + "_arg";

        // Retrieve the light target entity
        entity lightTarget = getTargetEntity(owner.getKey(argRoot + "1"), owner);

        lightTarget.setRadius(0);
        lightTarget.Off();
        // Check for a "extinguished" model
        string extModel = lightTarget.getKey("model_extinguished");
        if (extModel != "") {
                lightTarget.setModel(extModel);
        }
}

This f.i. misses the skin change. Also the "setRadius(0)" is susp.
TagsNo tags attached.

Relationships

related to 0004186 resolvedSteveL Response effect to turn light off stops it ever illuminating again 

Activities

nbohr1more

nbohr1more

11.04.2011 22:42

developer   ~0003801

As I believe that this tracker seems to be related to your fix in 2546 (which I see requires a bit of an expensive snoop operation), I will state that there are anecdotal statements about performance drops for combined light entities from a number of folk. (This is stated in comparison to v1.03.)

I know that you have code comment for possible optimizations like caching but I wasn't sure if this is the tracker for those concerns or if another should be created.

(Maybe a test map with x-number of candles bench-marked in v1.03 verses v1.05 ?)
VanishedOne

VanishedOne

30.08.2015 12:44

reporter   ~0007748

Has this been fixed now? See SteveL's updated script following 0004186
and 0004195

(The comment about the manual fade still looks pertinent, though.)
nbohr1more

nbohr1more

05.10.2017 17:31

developer   ~0009401

The current tdm_response_effects.script is wildly different than what is discussed here thought the Fade() comment still probably applies.

Issue History

Date Modified Username Field Change
16.01.2011 10:23 tels New Issue
11.04.2011 22:42 nbohr1more Note Added: 0003801
30.08.2015 12:44 VanishedOne Note Added: 0007748
31.08.2015 17:29 SteveL Relationship added related to 0004186
05.10.2017 17:31 nbohr1more Note Added: 0009401
05.10.2017 17:32 nbohr1more Status new => closed
05.10.2017 17:32 nbohr1more Resolution open => unable to reproduce
05.10.2017 17:32 nbohr1more Fixed in Version => TDM 2.05
05.10.2017 17:32 nbohr1more Target Version => TDM 2.05