Changesets: DarkRadiant

declmanager 02dab15d

07.07.2022 10:34

greebo


Details Diff
0005977: Migrate reminaining calls to eclass manager signals to declaration manager signals. No signals anymore on the IEClassManager interface Affected Issues
0005977
mod - include/ieclass.h Diff File
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - radiantcore/eclass/EClassManager.cpp Diff File
mod - radiantcore/eclass/EClassManager.h Diff File

declmanager 66162ee4

07.07.2022 09:05

greebo


Details Diff
0005977: Remove a lot of dead eclass code Affected Issues
0005977
mod - include/ieclass.h Diff File
mod - radiantcore/CMakeLists.txt Diff File
mod - radiantcore/eclass/EClassManager.cpp Diff File
mod - radiantcore/eclass/EClassManager.h Diff File
rm - radiantcore/eclass/EClassParser.cpp Diff
rm - radiantcore/eclass/EClassParser.h Diff
mod - tools/msvc/DarkRadiantCore.vcxproj Diff File
mod - tools/msvc/DarkRadiantCore.vcxproj.filters Diff File

declmanager d90cd7b0

07.07.2022 08:53

greebo


Details Diff
0005977: Fix ISoundShader implementation, remove redundant class members Affected Issues
0005977
mod - plugins/sound/SoundShader.cpp Diff File
mod - plugins/sound/SoundShader.h Diff File

declmanager c4f19c87

07.07.2022 08:38

greebo


Details Diff
0005977: Fix IEntityClass::getModName and getDefFileName implementations. Add corresponding unit test. Affected Issues
0005977
mod - radiantcore/eclass/EClassParser.cpp Diff File
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File
mod - test/EntityClass.cpp Diff File
mod - test/RadiantTest.h Diff File

declmanager 1328ab4c

07.07.2022 07:41

greebo


Details Diff
0005977: Migrate the EntityInspector code that refreshes the view when defs are reloaded Affected Issues
0005977
mod - radiant/ui/einspector/EntityInspector.cpp Diff File

declmanager 89bac80d

07.07.2022 07:28

greebo


Details Diff
0005977: Nullify the IEntityClass parent on clear(), i.e. when a new syntax block is assigned Affected Issues
0005977
mod - radiantcore/eclass/EntityClass.cpp Diff File

declmanager 0f89b34f

07.07.2022 05:25

greebo


Details Diff
0005977: More unit test cases covering the BasicDefTokeniser.
This could easily use like dozens of more cases given the complexity of the tokeniser functor.
Affected Issues
0005977
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - test/DefTokenisers.cpp Diff File

declmanager 05abf6c0

07.07.2022 05:15

greebo


Details Diff
0005977: Fix DefTokeniserFunc behaviour when running out of non-delimiter tokens after the final closing quote. This fixes the DefTokeniser unit test. Affected Issues
0005977
mod - libs/parser/DefTokeniser.h Diff File

declmanager 78a76c5c

07.07.2022 04:58

greebo


Details Diff
0005977: Decl implementations need to protect themselves against parser::ParseException when tokenising their syntax blocks. Affected Issues
0005977
mod - radiantcore/eclass/Doom3ModelDef.h Diff File
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File

declmanager 7bea2b6a

07.07.2022 04:57

greebo


Details Diff
0005977: Add unit test covering some faulty behaviour in DefTokeniser when running into empty quotes at the end of a syntax block Affected Issues
0005977
mod - test/CMakeLists.txt Diff File
mod - tools/msvc/Tests/Tests.vcxproj Diff File
mod - tools/msvc/Tests/Tests.vcxproj.filters Diff File

declmanager 2cca3421

07.07.2022 04:45

greebo


Details Diff
0005977: MainFrame is using the DeclManager's signals to block updates during reloadDecls Affected Issues
0005977
mod - include/ideclmanager.h Diff File
mod - radiant/ui/mainframe/MainFrame.cpp Diff File
mod - radiant/ui/mainframe/MainFrame.h Diff File
mod - radiantcore/decl/DeclarationManager.cpp Diff File
mod - radiantcore/decl/DeclarationManager.h Diff File
mod - test/DeclManager.cpp Diff File

declmanager d4323b5b

07.07.2022 03:32

greebo


Details Diff
0005977: Fix build Affected Issues
0005977
mod - plugins/dm.editing/AIHeadChooserDialog.cpp Diff File

master cfca3659

06.07.2022 19:27

orbweaver


Details Diff
0000401: test calling a command with args as a statement string Affected Issues
0000410
mod - test/CommandSystem.cpp Diff File

declmanager b5b3bbc6

06.07.2022 16:52

greebo


Details Diff
0005977: Decl typenames are treated case-insensitively now Affected Issues
0005977
mod - radiantcore/decl/DeclarationFolderParser.cpp Diff File
mod - radiantcore/decl/DeclarationFolderParser.h Diff File
mod - radiantcore/decl/DeclarationManager.cpp Diff File
mod - radiantcore/decl/DeclarationManager.h Diff File

declmanager 7ae1bbc1

06.07.2022 15:08

greebo


Details Diff
0005977: Add unit test checking that the typename is compared case-insensitively (fails).
Attempt to fix Linux build failure due to "None" being defined in some X11 header
Affected Issues
0005977
mod - include/ideclmanager.h Diff File
mod - include/idecltypes.h Diff File
mod - test/DeclManager.cpp Diff File
mod - test/resources/tdm/testdecls/numbers.decl Diff File

master 2c2dfdb8

05.07.2022 20:22

orbweaver


Details Diff
0000401: test calling a command with an argument list Affected Issues
0000410
mod - test/CommandSystem.cpp Diff File

master a2b332e7

05.07.2022 19:45

orbweaver


Details Diff
0000401: expand command-with-args unit test

Test that we can receive both a string and an integer argument. Get rid
of the local struct since it's not adding any value. Also confirm that
the command is not called if the wrong argument types are provided.
Affected Issues
0000410
mod - test/CommandSystem.cpp Diff File

master e54c61d7

05.07.2022 19:12

orbweaver


Details Diff
0000401: test calling a Command with an int argument Affected Issues
0000410
mod - test/CommandSystem.cpp Diff File

declmanager 3de422ef

04.07.2022 16:52

greebo


Details Diff
0005977: Unhook the existing eclass parse infrastructure, redirect lookups and walkers to the GlobalDeclarationManager Affected Issues
0005977
mod - radiantcore/decl/DeclarationManager.cpp Diff File
mod - radiantcore/eclass/EClassManager.cpp Diff File
mod - radiantcore/eclass/EClassManager.h Diff File
mod - radiantcore/eclass/EClassParser.cpp Diff File
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File

declmanager b0a33a09

04.07.2022 16:06

greebo


Details Diff
0005977: Add parse guards to all the locations where the def contents need to have been processed. Affected Issues
0005977
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File

declmanager 26fcfa73

03.07.2022 16:50

greebo


Details Diff
0005977: Start changing the EntityClass methods to lazy-parse itself from the syntax block when any of the public methods are invoked.
This requires the const-ness to be dropped from most methods - the alternative would be to keep the const-ness but ensure that the instance is parsed before any of the public methods can be safely invoked. Which is something we cannot promise at this point.
Affected Issues
0005977
mod - include/ieclass.h Diff File
mod - libs/eclass.h Diff File
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - plugins/dm.conversation/ConversationCommandInfo.cpp Diff File
mod - plugins/dm.difficulty/DifficultySettings.cpp Diff File
mod - plugins/dm.editing/AIVocalSetPreview.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File
mod - radiantcore/entity/EntityModule.cpp Diff File
mod - radiantcore/map/aas/AasFileManager.cpp Diff File
mod - test/EntityClass.cpp Diff File

declmanager 3d03b3f5

03.07.2022 15:30

greebo


Details Diff
0005977: Remove the getModelpath/setModelPath and getSkin/setSkin methods from the EntityClass type, no code is using these values after they've been set.
Instead the _isFixedSize flag is set based on the occurrence of a "model" attribute on the class or any of its ancestors. This is needed to give the correct hints to the algorithm in getClassType().
Affected Issues
0005977
mod - radiantcore/eclass/EClassParser.cpp Diff File
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File

declmanager 654566a3

03.07.2022 14:38

greebo


Details Diff
0005977: Create the entity instances based on the type returned by IEntityClass::getClassType() Affected Issues
0005977
mod - radiantcore/entity/EntityModule.cpp Diff File

declmanager 903dc836

03.07.2022 14:32

greebo


Details Diff
0005977: Introduce IEntityClass::Type enumeration which should serve as new basis for determining which C++ types should be created for a certain entity class. The logic has been taken from existing code in EntityModule, which is going to be migrated in the next step.
Added unit tests covering the distinction criteria, including scenarios where the relevant attributes are inherited from a parent.
Affected Issues
0005977
mod - include/ieclass.h Diff File
mod - radiantcore/eclass/EntityClass.cpp Diff File
mod - radiantcore/eclass/EntityClass.h Diff File
mod - test/EntityClass.cpp Diff File
mod - test/resources/tdm/def/base.def Diff File
mod - test/resources/tdm/def/bucket.def Diff File
mod - test/resources/tdm/def/player.def Diff File

declmanager 824123c6

03.07.2022 12:45

greebo


Details Diff
0005977: Add unit test checking that loading a map with an entity referencing a missing entityDef doesn't discard its child primitives, even after saving Affected Issues
0005977
mod - test/EntityClass.cpp Diff File
add - test/algorithm/FileUtils.h Diff File
mod - test/algorithm/Scene.h Diff File
add - test/resources/tdm/maps/missing_entitydef.map Diff File
mod - tools/msvc/Tests/Tests.vcxproj Diff File
mod - tools/msvc/Tests/Tests.vcxproj.filters Diff File
 First  Prev  1 2 3 ... 30 ... 52 53 54 55 56 57 58 ... 60 ... 90 ... 120 ... 150 ... 180 ... 210 ... 240 ... 264 265 266  Next  Last