DarkRadiant: master be4a96e6

Diff Back to Repository
Author Committer Branch Timestamp Parent
orbweaver orbweaver master 04.12.2024 19:28 master 74a669f9
Changeset Remove CallSuper antipattern from RenderPreview::setupSceneGraph()

setupSceneGraph() is now an empty virtual method which subclasses are
free to override or not as they wish (all of them do, except
MapPreview).

The single line in the original default implementation (setting the
current render time to 0) is now moved up into the calling method, so
that subclasses are no longer required to call the parent implementation
to avoid breaking the base class behaviour.
mod - libs/wxutil/menu/FilterPopupMenu.cpp Diff File
mod - libs/wxutil/menu/FilterPopupMenu.h Diff File
mod - libs/wxutil/menu/PopupMenu.cpp Diff File
mod - libs/wxutil/menu/PopupMenu.h Diff File
mod - libs/wxutil/preview/EntityPreview.cpp Diff File
mod - libs/wxutil/preview/ParticlePreview.cpp Diff File
mod - libs/wxutil/preview/RenderPreview.cpp Diff File
mod - libs/wxutil/preview/RenderPreview.h Diff File
mod - radiant/ui/animationpreview/AnimationPreview.cpp Diff File
mod - radiant/ui/common/MapPreview.h Diff File
mod - radiant/ui/materials/editor/MaterialPreview.cpp Diff File
mod - radiant/ui/modelselector/ModelTreeView.cpp Diff File
mod - radiantcore/filters/BasicFilterSystem.h Diff File