Source Control Integration - The Dark Mod Bugtracker

master 64a7d31e 2020-03-17 04:10:16 greebo Details Diff	Add virtual dtor	Attach Issues:
	mod - include/ilayer.h	Diff File
layersystem_restructuring baa7b474 2020-03-17 04:04:32 greebo Details Diff	Remove now unused LayerCommandTarget class.	Attach Issues:
	mod - radiant/Makefile.am	Diff File
	rm - radiant/layers/LayerCommandTarget.cpp	Diff File
	rm - radiant/layers/LayerCommandTarget.h	Diff File
	mod - radiant/layers/LayerManager.h	Diff File
	mod - radiant/layers/LayerModule.cpp	Diff File
layersystem_restructuring b99c2944 2020-03-17 04:04:32 greebo Details Diff	Remove now unused LayerCommandTarget class.	Attach Issues:
	mod - radiant/Makefile.am	Diff File
	rm - radiant/layers/LayerCommandTarget.cpp	Diff File
	rm - radiant/layers/LayerCommandTarget.h	Diff File
	mod - radiant/layers/LayerManager.h	Diff File
	mod - radiant/layers/LayerModule.cpp	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj.filters	Diff File
layersystem_restructuring dea548b9 2020-03-17 04:00:16 greebo Details Diff	Register layer commands as single functions taking an argument. The built-in statements are defined in commandsystem.xml.	Attach Issues:
	mod - install/commandsystem.xml	Diff File
	mod - radiant/layers/LayerModule.cpp	Diff File
layersystem_restructuring eabe55b0 2020-03-15 03:55:23 greebo Details Diff	Layer Control Dialog needs to be aware of map root changes when it's being shown	Attach Issues:
	mod - radiant/ui/layers/LayerControlDialog.cpp	Diff File
	mod - radiant/ui/layers/LayerControlDialog.h	Diff File
layersystem_restructuring 32af0e9d 2020-03-13 19:07:13 greebo Details Diff	Remove GlobalLayerSystem() callback and migrate all code to use the ILayerManager interface in the root node. This proved to be a bit tricky since there are situations where a node is not directly connected to a root node through its ancestry (e.g. during cloning or map deserialising).	Attach Issues:
	mod - include/ilayer.h	Diff File
	mod - libs/scenelib.h	Diff File
	mod - radiant/brush/BrushModule.cpp	Diff File
	mod - radiant/entity/EntityCreator.cpp	Diff File
	mod - radiant/layers/LayerCommandTarget.cpp	Diff File
	mod - radiant/layers/LayerInfoFileModule.cpp	Diff File
	mod - radiant/layers/LayerInfoFileModule.h	Diff File
	mod - radiant/layers/LayerManager.cpp	Diff File
	mod - radiant/layers/LayerManager.h	Diff File
	mod - radiant/layers/LayerModule.cpp	Diff File
	mod - radiant/layers/LayerUsageBreakdown.cpp	Diff File
	mod - radiant/map/algorithm/Clone.h	Diff File
	mod - radiant/map/algorithm/Import.cpp	Diff File
	mod - radiant/map/format/portable/PortableMapReader.cpp	Diff File
	mod - radiant/map/format/portable/PortableMapWriter.cpp	Diff File
	mod - radiant/patch/PatchCreators.cpp	Diff File
	mod - radiant/selection/algorithm/Entity.cpp	Diff File
	mod - radiant/selection/algorithm/Group.cpp	Diff File
	mod - radiant/selection/algorithm/Primitives.cpp	Diff File
	mod - radiant/selection/algorithm/Transformation.cpp	Diff File
	mod - radiant/ui/layers/LayerContextMenu.cpp	Diff File
	mod - radiant/ui/layers/LayerControl.cpp	Diff File
	mod - radiant/ui/layers/LayerControlDialog.cpp	Diff File
	mod - radiant/ui/layers/LayerOrthoContextMenuItem.cpp	Diff File
	mod - radiant/ui/layers/LayerOrthoContextMenuItem.h	Diff File
	mod - radiant/ui/mapinfo/LayerInfoTab.cpp	Diff File
layersystem_restructuring 194b593c 2020-03-13 09:00:24 greebo Details Diff	Change LayerValidityCheckWalker to use the root node's LayerManager	Attach Issues:
	mod - libs/scene/LayerValidityCheckWalker.h	Diff File
layersystem_restructuring 848b232b 2020-03-13 08:20:06 greebo Details Diff	Rename LayerSystem class to LayerManager.	Attach Issues:
	mod - radiant/Makefile.am	Diff File
	mod - radiant/layers/LayerCommandTarget.cpp	Diff File
	mod - radiant/layers/LayerModule.cpp	Diff File
	mod - radiant/ui/layers/LayerContextMenu.cpp	Diff File
	mod - radiant/ui/layers/LayerControl.cpp	Diff File
	mod - radiant/ui/layers/LayerControlDialog.cpp	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj.filters	Diff File
layersystem_restructuring 23307e92 2020-03-13 07:21:10 greebo Details Diff	Introduce ILayerModule which can create several layer systems to be hosted by the map root node.	Attach Issues:
	mod - include/ilayer.h	Diff File
	mod - include/imap.h	Diff File
	mod - libs/scene/BasicRootNode.h	Diff File
	add - radiant/layers/LayerModule.cpp	Diff File
	mod - radiant/layers/LayerSystem.cpp	Diff File
	mod - radiant/layers/LayerSystem.h	Diff File
	mod - radiant/map/RootNode.cpp	Diff File
	mod - radiant/map/RootNode.h	Diff File
	mod - radiant/map/format/Doom3MapFormat.cpp	Diff File
	mod - radiant/map/format/Quake3MapFormat.cpp	Diff File
	mod - radiant/map/format/Quake4MapFormat.cpp	Diff File
	mod - radiant/map/format/portable/PortableMapFormat.cpp	Diff File
	mod - radiant/ui/UserInterfaceModule.cpp	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj.filters	Diff File
layersystem_restructuring bc1727f9 2020-03-12 17:29:07 greebo Details Diff	Return the layer list by ref-to-const	Attach Issues:
	mod - include/ilayer.h	Diff File
	mod - libs/scene/LayerValidityCheckWalker.h	Diff File
	mod - libs/scene/Node.cpp	Diff File
	mod - libs/scene/Node.h	Diff File
	mod - radiant/layers/LayerSystem.cpp	Diff File
	mod - radiant/layers/LayerUsageBreakdown.cpp	Diff File
	mod - radiant/layers/SetLayerSelectedWalker.h	Diff File
	mod - radiant/map/format/portable/PortableMapWriter.cpp	Diff File
layersystem_restructuring f37dc031 2020-03-11 15:49:03 greebo Details Diff	Handle more than one possible prefab format in PrefabPopulator class	Attach Issues:
	mod - radiant/ui/prefabselector/PrefabPopulator.cpp	Diff File
	mod - radiant/ui/prefabselector/PrefabPopulator.h	Diff File
layersystem_restructuring 1c52da23 2020-03-11 15:32:09 greebo Details Diff	Enable prefab export in portable format.	Attach Issues:
	mod - radiant/map/MapFileManager.cpp	Diff File
	mod - radiant/map/format/portable/PortableMapFormat.cpp	Diff File
master b9732a93 2020-03-10 21:24:10 orbweaver Details Diff	Add documentation for the Difficulty editor	Attach Issues:
	add - doc/img/DifficultyEditor.png	Diff File
	mod - doc/manual.adoc	Diff File
	mod - doc/manual.html	Diff File
portable_map_format 8ba24231 2020-03-10 17:00:59 greebo Details Diff	Instead of re-writing groups on the fly when inserting into the target scene, the new approach is to remove any conflicts before starting to migrate the nodes. This is similar to the approach taken when removing the name conflicts (NamespaceManager::ensureNoConflicts).	Attach Issues:
	mod - radiant/map/algorithm/Import.cpp	Diff File
portable_map_format 9b075992 2020-03-10 13:35:18 greebo Details Diff	Expand the map marge/import code to handle incoming selection group assignments, assigning new group IDs not in conflict with the target scene.	Attach Issues:
	mod - include/iselectiongroup.h	Diff File
	mod - libs/scene/SelectableNode.cpp	Diff File
	mod - libs/scene/SelectableNode.h	Diff File
	mod - radiant/map/algorithm/Import.cpp	Diff File
portable_map_format 51aa21b0 2020-03-10 13:33:39 greebo Details Diff	Allow string::join to handle non-string types by using the string::to_string convertor	Attach Issues:
	mod - libs/string/join.h	Diff File
portable_map_format f0ed1c9b 2020-03-10 04:10:53 greebo Details Diff	Move map merge functions to Import.h file. Rename and refactor a few classes to reduce code duplication.	Attach Issues:
	mod - libs/scenelib.h	Diff File
	mod - radiant/map/Map.cpp	Diff File
	mod - radiant/map/algorithm/Import.cpp	Diff File
	mod - radiant/map/algorithm/Import.h	Diff File
	rm - radiant/map/algorithm/Merge.h	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj.filters	Diff File
portable_map_format 84c8feb5 2020-03-09 15:52:16 greebo Details Diff	Move common conflict handling code to map::algorithm namespace	Attach Issues:
	mod - radiant/map/Map.cpp	Diff File
	mod - radiant/map/algorithm/Import.cpp	Diff File
	mod - radiant/map/algorithm/Import.h	Diff File
	mod - radiant/selection/algorithm/Transformation.cpp	Diff File
portable_map_format 6bb8f7ef 2020-03-09 15:27:56 greebo Details Diff	Fix 0005173: Remove Namespace.connect() calls when importing nodes from any source, be it the clipboard, a prefab file or when cloning nodes from the current map. This fixes the console warnings about nodes being attached to the same namespace again. This is basically a follow-up of commit 3575385 made in 2012.	Affected Issues 0005173
	mod - radiant/map/Map.cpp	Diff File
	mod - radiant/selection/algorithm/Transformation.cpp	Diff File
portable_map_format e43b36ff 2020-03-09 14:42:36 greebo Details Diff	Handle undoable operations in a correct way. Low-level algorithm shouldn't start undoable operations on their own, this is the responsibility of calling code. This fixes the crash occurring in ff33068. Creating another undoable operation when a previous one is already opened will lead to an assertion now.	Attach Issues:
	mod - radiant/selection/algorithm/Group.cpp	Diff File
	mod - radiant/selection/group/SelectionGroupManager.cpp	Diff File
	mod - radiant/selection/group/SelectionGroupManager.h	Diff File
	mod - radiant/undo/Stack.h	Diff File
master 09145952 2020-03-03 20:49:34 orbweaver Details Diff	Minor tweak to DifficultyEditor .fbp file Set the global properties in the .fbp file to specify that we are generating XML code (not C++ which is the default), and that the output file should be named 'difficultyeditor'. This causes wxFormBuilder to automatically write the correct .xrc file when pressing F8. Also removed the internal border inside the left-hand tree panel, so that the inserted tree view is horizontally aligned with the buttons.	Attach Issues:
	mod - install/ui/difficultyeditor.fbp	Diff File
	mod - install/ui/difficultyeditor.xrc	Diff File
master 2b2c39d1 2020-03-02 20:55:07 orbweaver Details Diff	Show useful difficulty names in the Difficulty editor The default difficulty names are contained within the 'difficultyMenu' entity def stored inside the mod data itself; however these names are intended to be translated using the mod-specific translation system, which is not read or processed by DarkRadiant. Therefore the names actually shown in the GUI were meaningless string table entries like '#str_03000', rather than the user-friendly names like 'Easy'. Rather than try to support the entire mod translation system, which would be a massive task, a simple string table lookup is performed based on the contents of additional <string> nodes which have been added to the darkmod.game file.	Affected Issues 0005210
	mod - install/games/darkmod.game	Diff File
	mod - libs/gamelib.h	Diff File
	mod - plugins/dm.difficulty/DifficultySettingsManager.cpp	Diff File
master 28358ed0 2020-02-26 21:36:27 orbweaver Details Diff	Fix assertion failure on opening Difficulty editor Tab images were placed into a wxImageList but this list was never set on the wxNotebook with SetImageList(), causing an assertion failure.	Attach Issues:
	mod - plugins/dm.difficulty/DifficultyDialog.cpp	Diff File
master 8ee8e421 2020-02-25 21:19:06 orbweaver Details Diff	Remove close button from modal dialogs A user reported that accidentally closing dialogs such as the Objectives editor with the top-right close button can result in data loss, because the dialog treats this as "Cancel" and does not prompt to save changes. Now the close button is removed, so a user must explicitly choose to click one of the main buttons at the bottom. I don't know for sure whether the wxSYSTEM_MENU style is needed, but since it was part of the wxDEFAULT_DIALOG_STYLE and I'm not in a position to test its removal (it only has an effect on Windows according to the docs), it is left in for now.	Affected Issues 0005209
	mod - libs/wxutil/dialog/DialogBase.cpp	Diff File
master a6c3540f 2020-02-25 21:18:20 orbweaver Details Diff	Move DialogBase method bodies into a separate .cpp file	Attach Issues:
	mod - libs/wxutil/Makefile.am	Diff File
	add - libs/wxutil/dialog/DialogBase.cpp	Diff File
	mod - libs/wxutil/dialog/DialogBase.h	Diff File

Changesets: DarkRadiant