DarkRadiant: master dfafe34c
| Author | Committer | Branch | Timestamp | Parent |
|---|---|---|---|---|
| orbweaver | orbweaver | master | 24.02.2022 20:29 | master 475bbef5 |
| Changeset | Remove Matrix3 column accessor methods Although reinterpret_cast happens to work with Eigen matrices, it is inherently dangerous since it relies on assumptions about the internal layout. These accessor methods were not actually used outside of tests, and for test purposes they don't offer anything that can't be achieved using zx(), zy() etc. The AccessMatrixColumnVectors test is removed entirely (since it only existed to test these methods), while the call to zCol() in ConstructTranslationMatrix is removed since the test already compares the entire list of matrix coefficients with the expected values. |
|||
| mod - libs/math/Matrix3.h | Diff File | |||
| mod - test/math/Matrix3.cpp | Diff File | |||
