View Issue Details

IDProjectCategoryView StatusLast Update
0003127The Dark ModCodingpublic24.09.2017 21:20
Reportertels Assigned To 
PrioritynormalSeveritynormalReproducibilitysometimes
Status newResolutionopen 
Summary0003127: Find out why DDS loading skips light textures for modern machines
DescriptionThe following code can be found in renderer/Image_load.cpp around line 1340. This should probably be removed and checked for:

        // god i love last minute hacks :-)
        if ( com_machineSpec.GetInteger() >= 1 && com_videoRam.GetInteger() >= 128 && imgName.Icmpn( "lights/", 7 ) == 0 ) {
                return false;
        }
TagsNo tags attached.

Relationships

related to 0003684 new Investigate GPL Renderer Improvements 

Activities

nbohr1more

nbohr1more

13.09.2017 21:20

developer   ~0009214

Last edited: 13.09.2017 21:22

View 2 revisions

LOL, this may be worse now...

https://github.com/fholger/thedarkmod/commit/5c7bcf57e53e87022efebfc679fe007eaf064dfb

if ( com_videoRam.GetInteger() >= 128 && imgName.Icmpn( "lights/", 7 ) == 0 )

No DDS Lights for any video card over 128MB of RAM regardless of specs...

nbohr1more

nbohr1more

13.09.2017 21:38

developer   ~0009215

Note: DDS light textures suck, banding is awful as I recall. One possible use-case is low frequency (blurry) light textures where we do interpolation in the shader.

As a performance optimization to sacrifice quality? Maybe a dedicated cvar? r_useCompressedLights?
duzenko

duzenko

14.09.2017 09:52

developer   ~0009232

com_videoRam is not set anywhere other than the .cfg file so maybe just disable lights/???.dds?
Do we have compress and uncompressed pair to test on?
nbohr1more

nbohr1more

24.09.2017 21:20

developer   ~0009349

No. Tels may have tried testing them at one time but we have no in-house examples.

I can create one if you are interested in this but I suspect it's fine as is anyway.

Issue History

Date Modified Username Field Change
11.05.2012 13:42 tels New Issue
11.05.2012 13:42 tels Summary Find out why DDS loading skips for light textures => Find out why DDS loading skips light textures for modern machines
13.09.2017 21:20 nbohr1more Note Added: 0009214
13.09.2017 21:22 nbohr1more Note Edited: 0009214 View Revisions
13.09.2017 21:38 nbohr1more Note Added: 0009215
14.09.2017 09:52 duzenko Note Added: 0009232
24.09.2017 15:26 nbohr1more Relationship added related to 0003684
24.09.2017 21:20 nbohr1more Note Added: 0009349