 |
You should delete the folder before updating, not after. Otherwise you lose the Training Mission and St. Lucia. Still would be nice if it gave a reason for the crash though. |
 |
Yeah, you are right about the sequence of deleting the fms folder. But you know how precise the instructions sometimes are and how well players read them. :-) Fixing the crashes is the easy part: In CMissionManager::SearchForNewMods() ~line 320 and CMissionManager::GenerateModList() ~line 448 there are iterators over directories. Adding the following code in those two methods right after the respective intial DM_LOG entry will fix the crashes. Actually it forces a shutdown of TDM and prevents the player to continue to the download menu or some other place, which would not make any sense, since downloads would fail anyway. if (!fs::is_directory(fmPath)) { DM_LOG(LC_MAINMENU, LT_ERROR)LOGSTRING("FM root folder does not exist: %s\r", fmPath.string().c_str()); gameLocal.Error("FM root folder does not exist: %s\rRun the tdm_update in order to restore it.\r", fmPath.string().c_str()); return XXX; } TDM would then exit with a console window as seen below. http://www.gnartsch.de/Thief-FM/beta/darkmod/FixFmsFolderMissing.jpg Of course some nice dialog with an explicit message would be better, but that seems out of scope of the gamex86.dll and therefor nothing I could debug. That console window is better then a crash anyways, since the gamma on my screen stays pretty high after a crash... and sometimes TDM is not really willing to die (and needs the CTRL-ALT-DEL salute despite of having crashed already). |
 |
Hmmmm, this was meant to be fixed in some changes quite a while back. Let me dig into this a bit more. |
|
|
Hopefully the final time that I have to claim to have fixed the missing "fms" folder issue. darkmod_src r5992 Previous fixes missed the case where both the fms folder and the currentfm.txt file are missing (e.g. fresh install where the fms folder wasn't created correctly or was removed for some reason). I will likely implement further checks in the game code to ensure that TDM doesn't crash if the fms folder is removed after TDM has been started (the current fix only does the check at game startup). |
|
|
Implemented extra error checking for missing "fms" directory based on gnartsch's suggestion. I think there are sufficient checks for this now, finally. darkmod_src r6018. |
- Anonymous
