| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003640 | The Dark Mod | Distribution | public | 30.12.2013 22:26 | 28.04.2014 20:06 |
| Reporter | gnartsch | Assigned To | taaaki | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | resolved | Resolution | fixed | ||
| Product Version | TDM 2.00 | ||||
| Summary | 0003640: Admin WebPage: Editing Mission Details pages produces/accepts trailing whitespaces in links | ||||
| Description | I am opening this bugtracker on behalf of Bikerdude, who is maintaining the mission database. The actual Category would probably rather read 'PHP scripting' or something like that. The problem is that the page Bikerdude needs to use in order to maintain the mission database (specifically misison&localization download links) seems to allow trailing whitespaces to be passed along into the database. Bikerdude says, that even creating the download links from scratch does not make those whitespaces disappear. (Which might indicate that those whitespaces are actually 'produced' by the web page code ?) The problem for the user is, that such links with trailing whitespaces will never find their way to the internal downloader. When the internal downloader requests the list of availlable missions from the server via a PHP script (http://www.thedarkmod.com/missiondb/get_available_missions.php), the server will filter those out before sending the XML with availlable missions back to the internal downloader on the gaming machine. Hence, any links with trailing whitespaces are not even availlable for downloading a mission. Just one of 0000040:0000011 examples: Bikerdude's 'Business as Usual' http://www.thedarkmod.com/missiondetails/?id=14 The webpage lists a mirror on Fidcal. Note that the link-description ends with some blanks, although the 'real link' seems to look fine. http://www.fidcal.com/darkuser/missions/TDM2testmissions/businessv3.pk4 The trailing blanks after '...' seem to be a clear indication that the actual link in the database contains those blanks as well. Comparing that with the output of the PHP script (http://www.thedarkmod.com/missiondb/get_available_missions.php) shows that such a mirror is not even listed there. <mission id="14" title="Business as Usual" releaseDate="2010-01-14" size="16" version="3" internalName="business3" type="single" author="Bikerdude"> <downloadLocation language="English" url="http://darkmod.taaaki.za.net/fms/business3.pk4"/> <downloadLocation language="English" url="http://www.southquarter.com/tdm/fms/TDM2testmissions/business3.pk4"/> <localisationPack url="http://darkmod.taaaki.za.net/fms/business_l10n.pk4"/> <localisationPack url="http://www.southquarter.com/tdm/fms/business_l10n.pk4"/> <localisationPack url="http://www.fidcal.com/darkuser/missions/business_l10n.pk4"/> </mission> Conclusion: The server filters out any download-links that do NOT end with '.pk4'. It would be better do fix the code in the admin web pages to not allow any trailing blanks be be passed on to the database. Unfortunately I do not have access to the admin portion of the web page, so I can neither help with reproducing these issues nor verify any fix. | ||||
| Tags | No tags attached. | ||||
 |
Some discussions on the blanks can be found here: http://forums.thedarkmod.com/topic/15254-tool-for-analyzing-mission-links-from-the-mission-list/page__view__findpost__p__329569 The best way to see the trailing blanks is to open the mission page with InternetExplorer and selecting 'View/Source' (Won't work with Firefox !) http://www.thedarkmod.com/missiondetails/?id=14 Here the relevant excerpt. Note that both the link and the description end with blanks (and sometimes there are also in links for other missions). (with some replaced characters in order to avoid this forum to mess with the html): [td][a href="http_//www.fidcal.com/darkuser/missions/TDM2testmissions/business3.pk4 "]http_//www.fidcal.com/darkuser/mis... [/a][/td] EDIT: I just attached a screenshot of the html source. And here a list of all links in the database affected by that issue: 'http://www.fidcal.com/darkuser/missions/TDM2testmissions/business3.pk4 ' 'http://darkmod.taaaki.za.net/fms/sound_alert_trainer.pk4 ' 'http://www.southquarter.com/tdm/fms/TDM2testmissions/thiefsden.pk4 ' 'http://www.fidcal.com/darkuser/missions/somewhere1_1.pk4 ' 'http://www.southquarter.com/tdm/fms/TDM2testmissions/siegeshop.pk4 ' 'http://www.southquarter.com/tdm/fms/TDM2testmissions/samhain.pk4 ' 'http://darkmod.taaaki.za.net/fms/solarescape1.pk4 ' 'http://www.fidcal.com/darkuser/missions/TDM2testmissions/oldhabits2.pk4 ' 'http://www.fidcal.com/darkuser/missions/timeofneed.pk4 ' |
 |
Should be fixed on my server now. Changes will take effect when the rest of the domains/sub-domains are migrated over to the new server. |
|
|
Looking to rewrite the mission db and release pages so hopefully I can add some improvements to the mission admin page. |
