 |
The problem is in idDeclFile::LoadAndParse The original doom3 engine lacked 3 types of decl that TDM supports. One of the three is the xdata decl. All decls are loaded by idLexer, which is used twice: once during game startup by the generic decl file loader used for all decl types, which loads the raw text of all definitions in all decl files, and again to parse the needed ones while a map is loading. By default, the generic decl loading procedure sets idLexer to disallow escape characters (e.g. \") in strings while loading a file. When it comes to parsing the xdata decls, an xdata-specific parser is used which *does* allow escape characters in strings. Whoever tested the xdata procedure evidently didn't try mixing single quotes with escaped double quotes in a single string. Just using escaped double quotes doesn't cause a problem, because the generic loader isn't trying to capture the string content, it's only looking for the closing brace } at the end of the xdata definition, trying to find the first one that's *not* embedded in a string. When it sees a string like "\n\n\"Im a bug test case\"" (no single quote in there), it interprets "\n\n\" as a string, then Im a bug test case\ as a series of keywords which it doesn't try to parse, then "" as an empty string. It chokes on "\n\n\"I'm a bug test case\"" (with the single quote) because the single quote occurs outside of what it thinks is the string, so it interpets it as the start of a new single quoted string which isn't closed before the end of the line. Adding an extra single quote to balance it, e.g. "\n\n\"I'm a b'ug test case\"" makes it work ok again. |
|
|
Fortunately the generic loader is aware of the individual decl type, including xdata, so we can allow escape chars in strings for xdata decls without changing the loading of any other decl type. |
|
|
At rev 6476: DeclManager.cpp |
- Anonymous
