View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004372 | The Dark Mod | SEED | public | 14.09.2016 16:13 | 18.09.2016 05:45 |
Reporter | nbohr1more | Assigned To | nbohr1more | ||
Priority | normal | Severity | normal | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Platform | ALL | ||||
Product Version | TDM 2.04 | ||||
Target Version | TDM 2.05 | Fixed in Version | TDM 2.05 | ||
Summary | 0004372: lod_bias does not affect func_emitter | ||||
Description | The lod_bias wiki indicates that a typical use-case for lod_bias is to hide particle emitters but it seems that the default func_emitter entity does not respect the setting. In previous demonstrations, func_emitter_multiple was used to manage particle LOD: http://forums.thedarkmod.com/topic/12107-announcement-seed-system/?p=248646 I see that emitter.cpp has no lod_bias logic so rather than playing with new entity logic, it may be better to simply add a condition check there. | ||||
Tags | No tags attached. | ||||
Related commits: https://github.com/svn2github/TheDarkMod_SVN_Unofficial/commit/c977898699770125f9f6b09e92ccdddd763a8f2e https://github.com/svn2github/TheDarkMod_SVN_Unofficial/commit/c60ca4b156ff8396ed1ba1944049a52cfe2ee167 |
|
My first two attempts failed. I was able to get the code to compile but the particle spawns are still happening. The third attempt to add a detection for idFuncEmitter failed as it seems that idEntity isn't a parent to func_emitter? I believe that may be why Tels added func_smoke to Misc.cpp rather than Entity.cpp. Func_smoke uses update particles rather than update visuals so perhaps that is the missing change in Emitter.cpp? Another option is to cut this off right at the renderer level in the same place r_skipParticles is checked. (If a per entity check can be done there and doesn't incur a big performance hit.) |
|
Emitter.cpp Src rev 6623 Binary at 14594 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
14.09.2016 16:13 | nbohr1more | New Issue | |
14.09.2016 16:13 | nbohr1more | Status | new => assigned |
14.09.2016 16:13 | nbohr1more | Assigned To | => nbohr1more |
14.09.2016 17:35 | nbohr1more | Note Added: 0008317 | |
17.09.2016 14:37 | nbohr1more | Note Added: 0008319 | |
18.09.2016 05:29 | nbohr1more | Note Added: 0008320 | |
18.09.2016 05:29 | nbohr1more | Note Edited: 0008320 | |
18.09.2016 05:41 | nbohr1more | Note Edited: 0008320 | |
18.09.2016 05:45 | nbohr1more | Status | assigned => resolved |
18.09.2016 05:45 | nbohr1more | Resolution | open => fixed |
18.09.2016 05:45 | nbohr1more | Fixed in Version | => TDM 2.05 |