View Issue Details

IDProjectCategoryView StatusLast Update
0004515The Dark ModSaving/Loadingpublic15.09.2017 04:02
Reporterduzenko Assigned Toduzenko  
Status resolvedResolutionfixed 
Product VersionSVN 
Target VersionTDM 2.06Fixed in VersionTDM 2.06 
Summary0004515: Game save does not work for a newly downloaded mission (Debugger)
DescriptionI just noticed this.
I installed a new mission (Inn Business), loaded it but could not save game.
Apparently the savegames folder does not get created.
Steps To ReproduceInstall a new mission.
Load mission.
Hit F4 - nothing happens.
In console type "savegame" - an error prints out.
TagsNo tags attached.




01.05.2017 08:53

administrator   ~0008819

I have noticed it too.

It happens only if you run TDM from SVN assets repository.
If you run release TDM with pk4, it works properly (not sure about this, it is necessary to check).

As far as I understood, the routine idFileSystemLocal::CreateOSPath is responsible for creating all the directories not yet present when saving a game. However, it does nothing because of this check:

    if ( strstr( OSPath, ".." ) || strstr( OSPath, "::" ) ) {
#ifdef _DEBUG
        common->DPrintf( "refusing to create relative path \"%s\"\n", OSPath );

In the considered case, the path is indeed absolute, but it contains one ".." term. Perhaps if this path was properly collapsed instead of simply concatenating several path strings, this issue would not happen.


01.05.2017 19:22

developer   ~0008821

Great insight!
I fixed the idFileSystemLocal::CreateOSPath to allow .. in the middle and it should work now.


02.05.2017 01:40

developer   ~0008824

Quicksave is working for me. I have the default F5 == save and F9 == load keymappings.


03.05.2017 09:42

developer   ~0008830

Apparently it only happened when run under debugger but now should be fixed

Issue History

Date Modified Username Field Change
30.04.2017 08:21 duzenko New Issue
30.04.2017 18:41 duzenko Summary Game save does not for a new mission => Game save does not work for a newly downloaded mission
01.05.2017 08:53 stgatilov Note Added: 0008819
01.05.2017 19:22 duzenko Note Added: 0008821
02.05.2017 01:39 nbohr1more Assigned To => duzenko
02.05.2017 01:39 nbohr1more Status new => feedback
02.05.2017 01:40 nbohr1more Note Added: 0008824
03.05.2017 09:42 duzenko Note Added: 0008830
03.05.2017 09:42 duzenko Status feedback => assigned
15.09.2017 04:02 nbohr1more Status assigned => resolved
15.09.2017 04:02 nbohr1more Resolution open => fixed
15.09.2017 04:02 nbohr1more Fixed in Version => TDM 2.06
15.09.2017 04:02 nbohr1more Summary Game save does not work for a newly downloaded mission => Game save does not work for a newly downloaded mission (Debugger)