View Issue Details

IDProjectCategoryView StatusLast Update
0004641The Dark ModGraphicspublic19.12.2018 19:32
Reporterduzenko Assigned Toduzenko  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product VersionSVN 
Target VersionTDM 2.07Fixed in VersionTDM 2.07 
Summary0004641: Shadow maps
DescriptionKnown issues:
 X Slow with many small/distant lights
 X Dynamic models shadows missing
 X Objects not in player's view don't cast shadows
 X No softening
 X Might not work on nVidia at all
 X No quality config (fixed at 6x 256^2)
 X No-shadow entities cast shadows (candle foot, torch stand, etc)
    Transparent surfaces cast solid shadows
 X Gap between occluder and its shadow (e.g. grates in StLucia)
Steps To Reproducer_shadows 2
Additional InformationUseful info
http://www.opengl-tutorial.org/intermediate-tutorials/tutorial-16-shadow-mapping/
TagsNo tags attached.

Relationships

child of 0003684 new Investigate GPL Renderer Improvements 

Activities

duzenko

duzenko

29.10.2017 11:44

developer   ~0009527

Fixed: Dynamic models shadows missing
At revision: 7259
duzenko

duzenko

29.10.2017 17:30

developer   ~0009528

Rev 7260: nVidia fix
duzenko

duzenko

04.11.2017 09:15

developer   ~0009540

Disabled shadow volume calculation when in shadow maps mode.
Switching back to SV mode may require quick save/load.
duzenko

duzenko

05.11.2017 17:03

developer   ~0009559

Added config cvars: r_shadowMapSize & r_fboDepthBits.
Automatic error margin/shadow gap based on shadow map size.
duzenko

duzenko

06.11.2017 10:08

developer   ~0009564

Culling front sides for shadow maps to work around the shadow acne.
Forcing includeBackFaces in R_CreateLightTris.
duzenko

duzenko

06.11.2017 11:09

developer   ~0009565

2x2 shadow map linear filtering.
No self-shadowing.
duzenko

duzenko

09.11.2017 12:57

developer   ~0009566

Added automatic mip selection based on light screen size
duzenko

duzenko

11.11.2017 13:27

developer   ~0009567

Disabled culling in shadow map mode as a workaround for "Objects not in player's view don't cast shadows"
duzenko

duzenko

12.11.2017 10:46

developer   ~0009582

Fixed: No-shadow entities cast shadows (candle foot, torch stand, etc)
duzenko

duzenko

18.11.2017 15:44

developer   ~0009634

Switched to the ersatz distance-to-light hardener as my first attempt at the pcss method failed.

It now combines @stgatilov's fixed sample distribution and the new noise sample.
stgatilov

stgatilov

11.06.2018 10:06

administrator   ~0010515

Is this issue "done" already, or there is something remaining to do?

The issue name sounds too generic and may easily get anger from the do-not-touch-anything-for-207 crowd =)
I think it would be better to either mark this issue as resolved in 2.06 (and move the remaining improvements to other issues) or remove the target=2.07.

Enabling shadow maps in 2.07 is clearly not a good idea, and it's better to not set target=2.07 otherwise =)
duzenko

duzenko

11.06.2018 10:10

developer   ~0010516

2.06 branched before this was started.
This is "done" in functionality, but FPS is too low in some scenes.
stgatilov

stgatilov

11.06.2018 10:16

administrator   ~0010517

As a related note for future, here you can see my comments about shadow maps and my prototype of softening shader:
  http://forums.thedarkmod.com/topic/18818-soft-shadow-progress/page-14#entry419844
nbohr1more

nbohr1more

19.12.2018 19:32

developer   ~0010981

Shadow Maps work in 2.07 and there is a menu option to used them.
Further changes would be enhancements issues.

Issue History

Date Modified Username Field Change
29.10.2017 08:58 duzenko New Issue
29.10.2017 08:58 duzenko Status new => assigned
29.10.2017 08:58 duzenko Assigned To => duzenko
29.10.2017 08:59 duzenko Description Updated View Revisions
29.10.2017 11:44 duzenko Note Added: 0009527
29.10.2017 11:45 duzenko Description Updated View Revisions
29.10.2017 11:45 duzenko Description Updated View Revisions
29.10.2017 15:49 nbohr1more Relationship added child of 0003684
29.10.2017 17:30 duzenko Note Added: 0009528
29.10.2017 17:30 duzenko Description Updated View Revisions
04.11.2017 08:36 duzenko Description Updated View Revisions
04.11.2017 09:15 duzenko Note Added: 0009540
05.11.2017 17:03 duzenko Note Added: 0009559
05.11.2017 17:03 duzenko Description Updated View Revisions
06.11.2017 09:42 duzenko Additional Information Updated View Revisions
06.11.2017 10:08 duzenko Note Added: 0009564
06.11.2017 11:09 duzenko Note Added: 0009565
09.11.2017 12:57 duzenko Note Added: 0009566
09.11.2017 12:57 duzenko Description Updated View Revisions
11.11.2017 13:27 duzenko Note Added: 0009567
11.11.2017 13:27 duzenko Description Updated View Revisions
12.11.2017 10:46 duzenko Note Added: 0009582
12.11.2017 10:46 duzenko Description Updated View Revisions
18.11.2017 15:44 duzenko Note Added: 0009634
11.06.2018 10:06 stgatilov Note Added: 0010515
11.06.2018 10:10 duzenko Note Added: 0010516
11.06.2018 10:16 stgatilov Note Added: 0010517
22.06.2018 15:00 Springheel Target Version TDM 2.07 => TDM 2.08
19.12.2018 19:32 nbohr1more Note Added: 0010981
19.12.2018 19:32 nbohr1more Status assigned => resolved
19.12.2018 19:32 nbohr1more Resolution open => fixed
19.12.2018 19:32 nbohr1more Fixed in Version => TDM 2.07
19.12.2018 19:32 nbohr1more Target Version TDM 2.08 => TDM 2.07