View Issue Details

IDProjectCategoryView StatusLast Update
0005173DarkRadiantMap Editingpublic08.11.2020 18:35
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionfixed 
Product Version2.6.0 
Target Version2.8.0Fixed in Version2.8.0 
Summary0005173: ConnectNamespacedWalker Warning when cloning selection containing links and targets
DescriptionWhen cloning a small set of entities targeting each other yields warnings in the console about redundant attaching of nodes going on:

ConnectNamespacedWalker: node 'light_4' is already attached to namespace at 0000000011945310
ConnectNamespacedWalker: node 'light_5' is already attached to namespace at 0000000011945310
ConnectNamespacedWalker: node 'light_6' is already attached to namespace at 0000000011945310
Steps To Reproduce- Open the attached map, it contains three lights targeting each other in a triangle
- Drag-select all three lights
- Hit space to clone them
- Check the console for the warnings

The warning doesn't affect the functionality of keeping links intact when cloning the selection.
TagsNo tags attached.

Activities

greebo

greebo

09.03.2020 15:24

administrator  

lights.map (477 bytes)   
Version 2
// entity 0
{
"classname" "light"
"name" "light_1"
"light_center" "0 0 0"
"light_radius" "137 126 320"
"origin" "55 525 0"
"target0" "light_2"
}
// entity 1
{
"classname" "light"
"name" "light_2"
"light_center" "0 0 0"
"light_radius" "137 126 320"
"origin" "1112 552 0"
"target0" "light_3"
}
// entity 2
{
"classname" "light"
"name" "light_3"
"light_center" "0 0 0"
"light_radius" "137 126 320"
"origin" "406 -157 0"
"target0" "light_1"
}
lights.map (477 bytes)   
greebo

greebo

09.03.2020 15:29

administrator   ~0012253

This is now fixed in a feature branch (commit 6bb8f7e) and can be set to resolved once the changes are merged to master.

Related Changesets

DarkRadiant: portable_map_format 6bb8f7ef

2020-03-09 15:27:56

greebo

Details Diff
Fix 0005173: Remove Namespace.connect() calls when importing nodes from any source, be it the clipboard, a prefab file or when cloning nodes from the current map. This fixes the console warnings about nodes being attached to the same namespace again. This is basically a follow-up of commit 3575385 made in 2012. Affected Issues
0005173
mod - radiant/map/Map.cpp Diff File
mod - radiant/selection/algorithm/Transformation.cpp Diff File

Issue History

Date Modified Username Field Change
09.03.2020 15:24 greebo New Issue
09.03.2020 15:24 greebo File Added: lights.map
09.03.2020 15:24 greebo Assigned To => greebo
09.03.2020 15:24 greebo Status new => confirmed
09.03.2020 15:24 greebo Assigned To greebo =>
09.03.2020 15:24 greebo Assigned To => greebo
09.03.2020 15:24 greebo Status confirmed => assigned
09.03.2020 15:28 greebo Changeset attached => DarkRadiant portable_map_format 6bb8f7ef
09.03.2020 15:28 greebo Resolution open => fixed
09.03.2020 15:29 greebo Note Added: 0012253
11.03.2020 15:10 greebo Status assigned => resolved
11.03.2020 15:10 greebo Fixed in Version => 2.8.0
08.11.2020 18:35 greebo Status resolved => closed