View Issue Details

IDProjectCategoryView StatusLast Update
0005176DarkRadiantGUIpublic08.11.2020 18:34
ReporterDragofer Assigned Togreebo  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionreopened 
Product Version2.7.0 
Target Version2.8.0Fixed in Version2.8.0 
Summary0005176: Let DR remember the shader in ShaderClipboard after closing
DescriptionSomething I'd appreciate is if DR remembered what was in your ShaderClipboard in your previous DR session (in other words, the texture that gets applied when you draw a new brush or ctrl + mmb to paste onto a brush surface/patch).

Currently when you start DR -> open a map -> start drawing a brush it'll be textured with _default aka "shader not found". If you then apply a real texture its scale will be far too small, because it seems "_default" has a very different texture scale than what's typical for TDM textures. So my routine every time I start DR & open a map is to copy the texture from the first brush I see.
TagsNo tags attached.

Activities

greebo

greebo

28.03.2020 16:02

administrator   ~0012318

Should this be tied to the map you're working on, or DarkRadiant as a whole?
Dragofer

Dragofer

28.03.2020 17:43

developer   ~0012320

Having thought about it, I figured I'd post a thread in the forums since I don't see a clearly preferable answer.
https://forums.thedarkmod.com/index.php?/topic/20317-most-recent-shader-instead-of-shader-not-found-_default-at-map-start/
greebo

greebo

05.04.2020 16:17

administrator   ~0012333

Well, talk about overwhelming feedback XD
I think it's up to you to decide what it should be associated with. If we need a tie-breaker, storing it DR-wide is the slightly easier thing to do, from a coding perspective.
Dragofer

Dragofer

07.04.2020 21:49

developer   ~0012340

Come to think of it, the best would likely be to make it map-specific as that'd most facilitate picking up where one has left off.
For brand-new maps the first shader could continue being _default, but it'd be nice to (in a separate ticket) adjust _default in such a way that the scale will be somewhat ok when it gets replaced by a real material.
greebo

greebo

08.04.2020 04:49

administrator   ~0012342

Alright then :)
Dragofer

Dragofer

24.04.2020 10:49

developer   ~0012377

Just tested this: the last shader from the previous session is indeed in the ShaderClipboard now when I start a new session, but when I draw a brush or create a patch it's still textured with _default.
greebo

greebo

24.04.2020 13:50

administrator   ~0012383

Right, should be fixed in source now.

Related Changesets

DarkRadiant: master b2abd530

2020-04-20 11:03:03

greebo

Details Diff
0005176: Let DR remember the shader in ShaderClipboard after closing, it's saved in each map's root node properties Affected Issues
0005176
mod - radiant/selection/shaderclipboard/ShaderClipboard.cpp Diff File

DarkRadiant: master fe0ce19d

2020-04-24 13:50:04

greebo

Details Diff
0005176: To let newly created brushes use the last remembered shader, pre-select the stored material in the Media Browsers Affected Issues
0005176
mod - radiant/selection/shaderclipboard/ShaderClipboard.cpp Diff File

Issue History

Date Modified Username Field Change
11.03.2020 15:25 Dragofer New Issue
12.03.2020 04:52 greebo Status new => acknowledged
28.03.2020 16:02 greebo Status acknowledged => feedback
28.03.2020 16:02 greebo Note Added: 0012318
28.03.2020 17:43 Dragofer Note Added: 0012320
28.03.2020 17:43 Dragofer Status feedback => new
28.03.2020 17:43 Dragofer Assigned To => Dragofer
28.03.2020 17:43 Dragofer Status new => feedback
28.03.2020 17:43 Dragofer Assigned To Dragofer =>
05.04.2020 16:17 greebo Note Added: 0012333
07.04.2020 21:49 Dragofer Note Added: 0012340
07.04.2020 21:49 Dragofer Status feedback => new
08.04.2020 04:49 greebo Status new => confirmed
08.04.2020 04:49 greebo Note Added: 0012342
20.04.2020 10:50 greebo Assigned To => greebo
20.04.2020 10:50 greebo Status confirmed => assigned
20.04.2020 11:03 greebo Changeset attached => DarkRadiant master b2abd530
20.04.2020 11:04 greebo Target Version => 2.8.0
20.04.2020 11:04 greebo Status assigned => resolved
20.04.2020 11:04 greebo Resolution open => fixed
20.04.2020 11:04 greebo Fixed in Version => 2.8.0
24.04.2020 10:49 Dragofer Note Added: 0012377
24.04.2020 10:49 Dragofer Assigned To greebo =>
24.04.2020 10:49 Dragofer Status resolved => new
24.04.2020 10:49 Dragofer Resolution fixed => reopened
24.04.2020 11:16 Dragofer Status new => feedback
24.04.2020 13:50 greebo Changeset attached => DarkRadiant master fe0ce19d
24.04.2020 13:50 greebo Assigned To => greebo
24.04.2020 13:50 greebo Status feedback => assigned
24.04.2020 13:50 greebo Status assigned => resolved
24.04.2020 13:50 greebo Note Added: 0012383
08.11.2020 18:34 greebo Status resolved => closed