View Issue Details

IDProjectCategoryView StatusLast Update
0005199DarkRadiantMap Editingpublic08.11.2020 18:34
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionfixed 
Product Version2.7.0 
Target Version2.8.0Fixed in Version2.8.0 
Summary0005199: It's possible to delete the classname spawnarg through the context menu
DescriptionThe Entity Inspector view does prevent the user from entering an empty value to the classname spawnarg, but it's still possible to delete the spawnarg entirely by using the context menu option.

While the entity doesn't immediately break, the map will refuse to load again after saving since the parser relies on every entity having a classname property.
TagsNo tags attached.

Activities

Dragofer

Dragofer

24.04.2020 12:05

developer   ~0012381

"Delete property" is now grayed out, but I can still use "Cut spawnarg(s)" to get rid of the classname spawnarg, and DR crashes when I try to select that entity afterwards. Note that the "classname" spawnarg may be part of a larger selection of multiple spawnargs, so it may be best to test if "classname" is amongst them when deciding whether to gray out "Cut spawnarg(s)".
greebo

greebo

24.04.2020 14:56

administrator   ~0012387

Right, cutting classnames should be covered now
Dragofer

Dragofer

25.04.2020 09:58

developer   ~0012401

"Name" is also a mandatory spawnarg that might accidentally get deleted if the mapper blanket selects a lot of spawnargs and cuts them (i.e. to delete them). Maybe this fix should be expanded to include this as well?

greebo

greebo

25.04.2020 10:16

administrator   ~0012402

The "name" spawnarg is not strictly necessary. DR will automatically assign names to an entity without names, or when creating them. The game seems to not care about this too much either.

Related Changesets

DarkRadiant: master 8667f96a

2020-03-28 15:10:46

greebo

Details Diff
0005199: Prevent classname spawnarg from being deleted through the Entity Inspector's context menu Affected Issues
0005199
mod - radiant/ui/einspector/EntityInspector.cpp Diff File

DarkRadiant: master 44ffe939

2020-04-24 14:55:45

greebo

Details Diff
0005199: Prevent classname spawnarg from being removed by Cutting them out.
Also, prevent the Entity Inspector from crashing DR if an entity should have an empty classname.
Affected Issues
0005199
mod - radiant/ui/einspector/EntityInspector.cpp Diff File

Issue History

Date Modified Username Field Change
28.03.2020 08:59 greebo New Issue
28.03.2020 08:59 greebo Status new => confirmed
28.03.2020 09:00 greebo Target Version => 2.8.0
28.03.2020 15:10 greebo Assigned To => greebo
28.03.2020 15:10 greebo Status confirmed => assigned
28.03.2020 15:11 greebo Status assigned => resolved
28.03.2020 15:11 greebo Resolution open => fixed
28.03.2020 15:11 greebo Fixed in Version => 2.8.0
28.03.2020 15:12 greebo Changeset attached => DarkRadiant master 8667f96a
24.04.2020 12:05 Dragofer Assigned To greebo =>
24.04.2020 12:05 Dragofer Status resolved => feedback
24.04.2020 12:05 Dragofer Resolution fixed => reopened
24.04.2020 12:05 Dragofer Note Added: 0012381
24.04.2020 14:55 greebo Changeset attached => DarkRadiant master 44ffe939
24.04.2020 14:56 greebo Note Added: 0012387
24.04.2020 14:56 greebo Status feedback => new
24.04.2020 14:56 greebo Assigned To => greebo
24.04.2020 14:56 greebo Status new => resolved
24.04.2020 14:56 greebo Resolution reopened => fixed
25.04.2020 09:58 Dragofer Status resolved => feedback
25.04.2020 09:58 Dragofer Resolution fixed => reopened
25.04.2020 09:58 Dragofer Note Added: 0012401
25.04.2020 10:16 greebo Note Added: 0012402
25.04.2020 14:43 Dragofer Status feedback => resolved
25.04.2020 14:43 Dragofer Resolution reopened => fixed
08.11.2020 18:34 greebo Status resolved => closed