View Issue Details

IDProjectCategoryView StatusLast Update
0005344DarkRadiantMap Editingpublic27.09.2020 17:38
Reportergreebo Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version2.8.0 
Target Version2.8.1Fixed in Version2.8.1 
Summary0005344: Change CSG Merge such that only brushes sharing the same parent entity get merged
DescriptionTo avoid the problems mentioned in 0005336 the CSG merge algorithm should not try to merge brushes that don't belong to the same entity.
TagsNo tags attached.

Activities

Dragofer

Dragofer

27.09.2020 17:38

developer   ~0012785

After reading about this new change, I've just tried the following on 2.8.0:

1) Create a brush, texture it with a snow texture
2) Duplicate it and move the new brush so it's adjacent to the first
3) Convert both to func_static -> Select the func_static -> Hit CSG Merge -> DR crashes

So both brushes are in the same entity, but still crash DR when attempting to merge. That said, if I use "Select Group Parts" first, then select the 2 brushes individually, then the merge works fine.

Related Changesets

DarkRadiant: master 36b5bab6

2020-09-27 16:03:41

greebo

Details Diff
0005344: Add (failing) unit test asserting on the behaviour to be implemented Affected Issues
0005344
mod - test/CSG.cpp Diff File

DarkRadiant: master dc1df259

2020-09-27 16:19:30

greebo

Details Diff
0005344 & 0005336: CSG Merge now only handles brushes sharing the same parent entity.
This also fixes the crash in 0005336.
Affected Issues
0005336, 0005344
mod - radiantcore/brush/csg/CSG.cpp Diff File

Issue History

Date Modified Username Field Change
27.09.2020 15:56 greebo New Issue
27.09.2020 16:03 greebo Product Version => 2.8.0
27.09.2020 16:03 greebo Target Version => 2.8.1
27.09.2020 16:04 greebo Status new => confirmed
27.09.2020 16:19 greebo Changeset attached => DarkRadiant master 36b5bab6
27.09.2020 16:19 greebo Changeset attached => DarkRadiant master dc1df259
27.09.2020 16:20 greebo Assigned To => greebo
27.09.2020 16:20 greebo Status confirmed => assigned
27.09.2020 16:20 greebo Status assigned => resolved
27.09.2020 16:20 greebo Resolution open => fixed
27.09.2020 16:20 greebo Fixed in Version => 2.8.1
27.09.2020 17:38 Dragofer Note Added: 0012785