View Issue Details

IDProjectCategoryView StatusLast Update
0005399DarkRadiantGeneralpublic14.11.2020 13:10
ReporterMirceaKitsune Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSLinux openSUSEOS VersionRelease
Product Version2.8.0 
Target Version2.9.0Fixed in Version2.9.0 
Summary0005399: Conversation Editor won't add new actors, entity names are seen as null
DescriptionYesterday I was learning about how the conversation editor in DarkRadiant (Git master) works, and in the process discovered a bug with this editor. When adding actors to the conversation, renaming them doesn't work and the entity names are seen as null strings, causing them to not be validated nor saved with the conversation changes.

First of all: If you click the Validate All button to confirm your actor exists on the map, you get the following error:

"The actor cannot be found in the current map"

Not only the actor entity is definitely there so the error is wrong, but notice there are double spaces when referring to it, instead of the word atdm_ai_proguard_1. This indicates that the actor name you just introduced, even if it shows up accordingly in the menu, is being ignored by the code... in its place a null string appears to be seen.

I also noticed that if you click ok to close the windows and confirm all changes, the actors field is empty the next time you open the conversation editor and select that entity and conversation. The actors you just created in that menu aren't even being registered at all.

Currently the only workaround is to select your atdm:conversation_info and manually add "conv_1_actor_1 atdm_ai_proguard_1" as a spawnarg. After you do this the conservation editor finds the actors, will successfully validate them, and you can proceed to add conversation actions successfully.
Steps To ReproduceStart by going to "Map -> Conversations". Create or select a conversation entity in the first list, then create a new conversation below and select it then edit it. In the new window you have an actors field: Hit the add button to create a new actor. Double-click the New Actor entry then rename it to one of the AI's on the map, for example atdm_ai_proguard_1. Hit "Validate All" to see the error message with empty strings... press okay on everything then reopen the editor to confirm the actors were never added.
TagsBug, Glitch

Activities

MirceaKitsune

MirceaKitsune

11.11.2020 14:47

reporter  

TbjZEsZ.png (447,321 bytes)
greebo

greebo

14.11.2020 09:34

administrator   ~0012924

Re-opening as this breaks the wxMSW version. Needs more work.

Related Changesets

DarkRadiant: 2.9.0 982dd14d

2020-11-14 09:24:42

greebo

Details Diff
0005399: Fix Conversation Editor refusing to accept actor names Affected Issues
0005399
mod - plugins/dm.conversation/ConversationEditor.cpp Diff File

DarkRadiant: 2.9.0 2fbca0f4

2020-11-14 12:42:55

greebo

Details Diff
0005399: The behaviour of wxEVT_DATAVIEW_ITEM_EDITING_DONE is different in wx3.0 and wx3.1, so let's switch Affected Issues
0005399
mod - plugins/dm.conversation/ConversationEditor.cpp Diff File

DarkRadiant: 2.9.0 ef729644

2020-11-14 13:08:35

greebo

Details Diff
0005399: Adjust Mission Info dialog to handle the tree view edit events correctly Affected Issues
0005399
mod - plugins/dm.editing/MissionInfoEditDialog.cpp Diff File
mod - plugins/dm.editing/MissionInfoEditDialog.h Diff File

Issue History

Date Modified Username Field Change
11.11.2020 14:47 MirceaKitsune New Issue
11.11.2020 14:47 MirceaKitsune Tag Attached: Bug
11.11.2020 14:47 MirceaKitsune Tag Attached: Glitch
11.11.2020 14:47 MirceaKitsune File Added: TbjZEsZ.png
14.11.2020 08:50 greebo Status new => confirmed
14.11.2020 09:24 greebo Changeset attached => DarkRadiant 2.9.0 982dd14d
14.11.2020 09:25 greebo Target Version => 2.9.0
14.11.2020 09:25 greebo Assigned To => greebo
14.11.2020 09:25 greebo Status confirmed => assigned
14.11.2020 09:25 greebo Status assigned => resolved
14.11.2020 09:25 greebo Resolution open => fixed
14.11.2020 09:25 greebo Fixed in Version => 2.9.0
14.11.2020 09:34 greebo Assigned To greebo =>
14.11.2020 09:34 greebo Status resolved => assigned
14.11.2020 09:34 greebo Resolution fixed => reopened
14.11.2020 09:34 greebo Note Added: 0012924
14.11.2020 13:07 greebo Changeset attached => DarkRadiant 2.9.0 2fbca0f4
14.11.2020 13:08 greebo Changeset attached => DarkRadiant 2.9.0 ef729644
14.11.2020 13:10 greebo Assigned To => greebo
14.11.2020 13:10 greebo Status assigned => resolved
14.11.2020 13:10 greebo Resolution reopened => fixed