View Issue Details

IDProjectCategoryView StatusLast Update
0005523DarkRadiantGUIpublic05.02.2021 08:03
ReporterDragofer Assigned To 
PrioritylowSeveritytweakReproducibilityalways
Status acknowledgedResolutionopen 
Product Version2.11.0 
Summary0005523: Keying through Light Inspector textures adds many events to undo queue
DescriptionI've noticed that every time one highlights a texture in the Light Inspector (L), the "texture" spawnarg on the entity gets updated immediately. This can quickly add many events to the undo queue if one is using the arrow keys to navigate through the list.

For the rest of the Light Inspector's this instant updating is a good feature, but it's impractical for texture selection and doesn't really seem to have any benefits. It'd be better if the "texture" were only applied once the inspector is closed.
Steps To Reproduce1) Create a light
2) With the light selected, press L to open the Light Inspector
3) Select a light texture, then hold down the up or down arrow key for a while. The "texture" spawnarg on the entity is continually updated.
4) Close the Light Inspector and press undo until (3) and (1) are undone. This should only take 2 presses, but takes many more.
TagsNo tags attached.

Activities

greebo

greebo

05.02.2021 03:26

administrator   ~0013643

It's behaving like the Surface Inspector where many clicks on the scale buttons will introduce undo actions for each step.

I'm sceptical that making one part of the Light Inspector not applying its changes like the rest of the controls. When waiting until the close event of the dialog, it'd be an easy things for the mapper to change the selection (e.g. by hitting ESC) and then there is a different set of lights selected by the time the dialog is closed.

It has to be clear to the user that the texture change is not going to be applied until a certain action is done (maybe an "Apply Texture" button?). Or having a checkbox ("Immediately apply texture on selection") to control that auto-apply? I'd rather lean towards UI consistency than to save the actions on the undo stack, to be honest - but I'm open to hear mapper voices on how this should behave.
Dragofer

Dragofer

05.02.2021 08:03

developer   ~0013646

An "Apply Texture" action would make the Light Inspector's behaviour consistent with that of the Media Browser.
A checkbox "Immediately apply texture on selection" would let current mappers avoid having to reacclimatise, so it'd be a boon but not essential in the long term.

Issue History

Date Modified Username Field Change
04.02.2021 08:58 Dragofer New Issue
04.02.2021 09:08 Dragofer Steps to Reproduce Updated
05.02.2021 03:26 greebo Note Added: 0013643
05.02.2021 03:26 greebo Status new => acknowledged
05.02.2021 08:03 Dragofer Note Added: 0013646