View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005836 | DarkRadiant | Map Editing | public | 12.12.2021 20:46 | 19.08.2022 15:33 |
| Reporter | orbweaver | Assigned To | orbweaver | ||
| Priority | normal | Severity | normal | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.14.0 | ||||
| Target Version | 3.0.0 | Fixed in Version | 3.0.0 | ||
| Summary | 0005836: Changing multiple lights between omni/projected resets colours to black | ||||
| Description | 1. Select multiple lights. 2. In the Light Inspector (L), change all of the lights to Projected or back to Omnidirectional. Expected: Lights change shape, but retain their existing colour, exactly as if each had been selected and changed individually. Actual: All light colours get set to black. | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master 2cbe0648 15.12.2021 20:47 Details Diff |
0005836: avoid unwanted colour changes when adjusting multiple lights This appears to be a long-standing bug with the LightInspector. The multi-selection code is far too coercive, setting ALL properties from the dialog on ALL selected lights, rather than just the property which has changed. This commit fixes the unwanted colour changes when toggling multiple lights between omni and projected, but the bug still exists in other areas. |
Affected Issues 0005836 |
|
| mod - radiant/ui/lightinspector/LightInspector.cpp | Diff File | ||
| mod - radiant/ui/lightinspector/LightInspector.h | Diff File | ||
|
DarkRadiant: master 9305c559 16.12.2021 13:51 Details Diff |
0005836: changing multiple light options no longer affects size _onOptionToggle() now calls writeToAllEntities() with just the spawnargs which need to be written, rather than setting all properties including dimension vectors. |
Affected Issues 0005836 |
|
| mod - libs/wxutil/XmlResourceBasedWidget.h | Diff File | ||
| mod - radiant/ui/lightinspector/LightInspector.cpp | Diff File | ||
| mod - radiant/ui/lightinspector/LightInspector.h | Diff File | ||
|
DarkRadiant: master dce7cd42 21.12.2021 20:01 Details Diff |
0005836: light option flags are set individually Instead of setting all four option flags in one go (on all selected lights, regardless of current per-light option values), each checkbox is connected to its own lambda resulting in only the toggled option being applied to the selected lights. This means that you can now safely toggle "No shadows" with several lights selected, without unexpectedly overwriting the lights' individual settings for "Parallel", "No specular" etc. |
Affected Issues 0005836 |
|
| mod - radiant/ui/lightinspector/LightInspector.cpp | Diff File | ||
| mod - radiant/ui/lightinspector/LightInspector.h | Diff File | ||
|
DarkRadiant: master 16d3ab13 22.12.2021 20:30 Details Diff |
0005836: "ai_see" checkbox no longer overwrites light dimensions Connect the ai_see handler to its own lambda, instead of calling setValuesOnEntity() which also coerces all selected lights to the same shape. |
Affected Issues 0005836 |
|
| mod - radiant/ui/lightinspector/LightInspector.cpp | Diff File | ||
|
DarkRadiant: master 9d0fe8e2 28.12.2021 19:35 Details Diff |
0005836: changing multiple light shapes no longer changes texture Changing between Omni and Projected no longer replaces the "texture" spawnarg for all selected lights. |
Affected Issues 0005836 |
|
| mod - radiant/ui/lightinspector/LightInspector.cpp | Diff File | ||
|
DarkRadiant: master 3473cfbd 04.01.2022 20:11 Details Diff |
0005836: setValuesOnEntity() is now setLightVectorsOnEntity() All other value-setting has been moved into separate methods. |
Affected Issues 0005836 |
|
| mod - radiant/ui/lightinspector/LightInspector.cpp | Diff File | ||
| mod - radiant/ui/lightinspector/LightInspector.h | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 12.12.2021 20:46 | orbweaver | New Issue | |
| 12.12.2021 20:46 | orbweaver | Status | new => assigned |
| 12.12.2021 20:46 | orbweaver | Assigned To | => orbweaver |
| 28.12.2021 19:38 | orbweaver | Status | assigned => resolved |
| 28.12.2021 19:38 | orbweaver | Resolution | open => fixed |
| 28.12.2021 19:38 | orbweaver | Fixed in Version | => 3.0.0 |
| 28.12.2021 19:38 | orbweaver | Note Added: 0014620 | |
| 16.01.2022 06:49 | orbweaver | Changeset attached | => DarkRadiant master 2cbe0648 |
| 16.01.2022 06:49 | orbweaver | Changeset attached | => DarkRadiant master 9305c559 |
| 16.01.2022 06:49 | orbweaver | Changeset attached | => DarkRadiant master dce7cd42 |
| 16.01.2022 06:49 | orbweaver | Changeset attached | => DarkRadiant master 16d3ab13 |
| 16.01.2022 06:49 | orbweaver | Changeset attached | => DarkRadiant master 9d0fe8e2 |
| 16.01.2022 06:49 | orbweaver | Changeset attached | => DarkRadiant master 3473cfbd |
| 19.08.2022 15:33 | greebo | Status | resolved => closed |
