View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006189 | DarkRadiant | Saving and loading | public | 09.12.2022 13:35 | 13.01.2024 05:34 |
| Reporter | Dragofer | Assigned To | greebo | ||
| Priority | normal | Severity | normal | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 3.7.0 | ||||
| Target Version | 3.8.0 | Fixed in Version | 3.8.0 | ||
| Summary | 0006189: Changing Game/Project doesn't update loaded assets correctly | ||||
| Description | The File > Game/Project Setup... looks like it should be able to switch between projects without restarting TDM, but as far as I can tell this isn't working successfully and still requires a DR restart. For example, with this procedure: 0) Download Noble Affairs, unpack it into darkmod/fms/nobleaffairs. 1) Open DR, set Game/Project Setup... > DarkMod Path: (darkmod base install folder), Mission: (empty). 2) Restart DR. Open noble_affairs.map and look around a bit in the camera view. As expected you can see a lot of missing shaders, i.e. the water and ship surfaces. 3) Set Game/Project Setup... > DarkMod Path: (darkmod base install folder), Mission: nobleaffairs, click OK. DR hangs for a while, but then the textures are still missing. 4) Restart DR and open noble_affairs.map again. Now the custom textures are all shown properly. 5) Set Game/Project Setup... > DarkMod Path: (darkmod base install folder), Mission: (empty). DR hangs for a while, then the custom textures are gone again. You can see that changing the project setup can only clear custom assets (step 5), but not load them (step 3). | ||||
| Tags | No tags attached. | ||||
|
DarkRadiant: master b6411c27 30.12.2022 06:57 Details Diff |
0006189: Add first unit test checking the root cause |
Affected Issues 0006189 |
|
| mod - test/DeclManager.cpp | Diff File | ||
|
DarkRadiant: master ce599a9a 30.12.2022 07:05 Details Diff |
0006189: Add another unit test checking that the material description is cleared before reparsing it |
Affected Issues 0006189 |
|
| mod - test/Materials.cpp | Diff File | ||
|
DarkRadiant: master 701fcd84 30.12.2022 07:44 Details Diff |
0006189: One more unit test exposing the problem that the material changed handler is fired before the editor image is changed |
Affected Issues 0006189 |
|
| mod - test/Materials.cpp | Diff File | ||
|
DarkRadiant: master 0880f5e6 30.12.2022 07:45 Details Diff |
0006189: Update the editor image before emitting the material changed signal |
Affected Issues 0006189 |
|
| mod - radiantcore/shaders/CShader.cpp | Diff File | ||
|
DarkRadiant: master 57a3085b 30.12.2022 07:47 Details Diff |
0006189: Clear material description before reparsing |
Affected Issues 0006189 |
|
| mod - radiantcore/shaders/ShaderTemplate.cpp | Diff File | ||
|
DarkRadiant: master e6304ab8 30.12.2022 08:05 Details Diff |
0006189: Clear the syntax block invalidated flag when a new block has been assigned. Also ensure the base methods are invoked in all overrides. |
Affected Issues 0006189 |
|
| mod - libs/decl/EditableDeclaration.h | Diff File | ||
| mod - radiantcore/eclass/EntityClass.cpp | Diff File | ||
| mod - radiantcore/particles/ParticleDef.cpp | Diff File | ||
| mod - radiantcore/shaders/ShaderTemplate.cpp | Diff File | ||
| mod - test/DeclManager.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 09.12.2022 13:35 | Dragofer | New Issue | |
| 09.12.2022 13:41 | Dragofer | Summary | Changing Game/Project doesn't update loaded assets => Changing Game/Project doesn't update loaded assets correctly |
| 30.12.2022 05:30 | greebo | Status | new => confirmed |
| 30.12.2022 05:30 | greebo | Note Added: 0015648 | |
| 30.12.2022 06:56 | greebo | Assigned To | => greebo |
| 30.12.2022 06:56 | greebo | Status | confirmed => assigned |
| 30.12.2022 08:05 | greebo | Changeset attached | => DarkRadiant master b6411c27 |
| 30.12.2022 08:05 | greebo | Changeset attached | => DarkRadiant master ce599a9a |
| 30.12.2022 08:05 | greebo | Changeset attached | => DarkRadiant master 701fcd84 |
| 30.12.2022 08:05 | greebo | Changeset attached | => DarkRadiant master 0880f5e6 |
| 30.12.2022 08:05 | greebo | Changeset attached | => DarkRadiant master 57a3085b |
| 30.12.2022 08:05 | greebo | Changeset attached | => DarkRadiant master e6304ab8 |
| 30.12.2022 08:06 | greebo | Target Version | => 3.8.0 |
| 30.12.2022 08:07 | greebo | Status | assigned => resolved |
| 30.12.2022 08:07 | greebo | Resolution | open => fixed |
| 30.12.2022 08:07 | greebo | Fixed in Version | => 3.8.0 |
| 13.01.2024 05:34 | greebo | Status | resolved => closed |
