 |
Rev 16730 Revert changes to tdm_prop_items.def in Rev 16603 |
 |
I can't believe this change is the cause of the problem. Also, hash collision does not cause a crash. It is some kind of "use after delete" problem. Or some idDict is used from non-game thread: that can break access to any idDict, since they all store their strings in global pool. |
|
|
You can try to set "com_smp 0" and "r_useParallelAddModels 0". Most probably the issue will go away --- that means idDict is used from wrong thread. I don't think the problem is not fixed, it probably just stopped happening based of luck, or moved to a different place. |
|
|
Oh, the commit 16603 by Dragofer actually changes something. It replaces "replace_anim_idle_sit_tap01" animation from "idle_sit_drink" (which is last, so probably took effect?) to "bottle_putdown". Maybe the new animation was causing the problem? Maybe Dragofer can clarify what was done in the original commit?... |
|
|
Yeah, in idDeclEntityDef::Parse I see: while (1) { ... if ( dict.FindKey( token ) ) { src.Warning( "'%s' already defined", token.c_str() ); } dict.Set( token, token2 ); } So if entityDef describes some spawnarg twice, the last value should take effect. So the original commit was actually changing the value of "replace_anim_idle_sit_tap01" from "idle_sit_drink" to "bottle_putdown". Was it intended? |
|
|
Disabling com_smp and r_useParallelAddModels does not cure the crash, nor does changing to other defaults like hard stencil shadows (etc). Yes, I believe that the original replacement design is broken \ mistaken. Dragofer fixed the broken definition but in doing so, uncovered a bug in the way that the "pre_pickup_origin" is tracked. Reverting the def, prevents the bug from presenting itself in this mission. |
|
|
I removed duplicate spawnarg in svn rev 16732. It should give no warning again, but this time the effective spawnarg value should be as it was before rev 16603. |
|
|
Thank you! No crashes with the latest def version even with com_smp (etc) enabled. |
 |
It doesn't look like my change was fully intended. Before rev 16603 we had these spawnargs in this order: "replace_anim_idle_sit_tap01" "bottle_putdown" "replace_anim_idle_sit_tap01" "idle_sit_drink" I guess the double definition or something else about this caused a warning in my mod-wide bug hunt, so I commented one out: "replace_anim_idle_sit_tap01" "bottle_putdown" //"replace_anim_idle_sit_tap01" "idle_sit_drink" In fact "bottle_putdown" should've been the one that got commented out. Then this spawnarg would've been consistent with the other idle sit anim replacements: "replace_anim_idle_sit_shift1" "idle_sit_drink" "replace_anim_idle_sit_cough01" "idle_sit_drink" "replace_anim_idle_sit_armdrop01" "idle_sit_drink" Rev 16732 now appears to be the correct fix to the original issue with the def. |
- Anonymous
