View Issue Details

IDProjectCategoryView StatusLast Update
0006354The Dark ModGraphicspublic12.01.2025 12:34
Reporterstgatilov Assigned Tostgatilov  
PrioritynormalSeveritynormalReproducibilityN/A
Status resolvedResolutionfixed 
Product VersionTDM 2.11 
Target VersionTDM 2.13Fixed in VersionTDM 2.13 
Summary0006354: Envmap stage works very differently with bumpmap and without
DescriptionHaving bumpmap (even just _flat) selects different shader, which has several major differences.
Moreover, bumpmapped version cannot be tuned up/down by color spawnargs.

Given how long this issue has been around, it might be hard to change now.
But I think it is worth trying...
TagsNo tags attached.

Relationships

related to 0006340 resolvedstgatilov Discourage output color depending on input alpha due to gl_dst_alpha 

Activities

stgatilov

stgatilov

11.04.2024 21:08

administrator   ~0016637

In the end, I simply decided to use the very same parameters for bumpmapped mode as are already used for non-bumpmapped one:
 1) RGBA color speciified in material is applied
 2) fresnel math is removed (visual difference is negligible anyway)
 3) tonemapping is disabled

Committed this:
  r10704 Added a mode where environment mapping stage on bumpmapped surface acts like a on a non-bumpmapped surface.

But it is not yet enabled.
It is controlled by r_envmapBumpyBehavior cvar.
Setting to 1 switches to the new behavior.

Added an announcement regarding breaking changes:
  https://forums.thedarkmod.com/index.php?/topic/22402-213-environment-mapping-bumpmap/

The main problem is about color, since previously it was hardcoded to 0.4, and now whatever values was set will apply.
Here is the script which is going to fix this on all core assets and missions:
  r17018 Added a script to replace rgba colors with 0.4 on all environment map stages with bumpmap.
stgatilov

stgatilov

20.04.2024 13:24

administrator   ~0016658

Enabled new behavior by default:
  r10719 Set r_envmapBumpyBehavior to 1 (i.e. new behavior).
stgatilov

stgatilov

12.01.2025 12:34

administrator   ~0016945

I updated all missions in svn rev 483.
I got some timeout error, so maybe post-commit hook failed and the mirrors are borked =(

By the way, I think this update fixes behavior in 2.13, but does not change behavior in 2.12 and earlier.
It just comments out red/green/blue on envmap stage and adds rgba 0.4 there.
But these color settings were ignored in 2.12 and earlier, so the change in them does not change anything in 2.12.

Issue History

Date Modified Username Field Change
10.12.2023 11:25 stgatilov New Issue
10.12.2023 11:25 stgatilov Status new => assigned
10.12.2023 11:25 stgatilov Assigned To => stgatilov
10.12.2023 11:25 stgatilov Relationship added related to 0006340
11.04.2024 21:08 stgatilov Note Added: 0016637
20.04.2024 13:24 stgatilov Note Added: 0016658
08.01.2025 03:39 nbohr1more Status assigned => feedback
09.01.2025 13:24 nbohr1more Status feedback => resolved
09.01.2025 13:24 nbohr1more Resolution open => fixed
09.01.2025 13:24 nbohr1more Fixed in Version => TDM 2.13
12.01.2025 12:34 stgatilov Note Added: 0016945