View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0006511 | DarkRadiant | Compilation/Build | public | 31.03.2024 14:23 | 01.07.2025 18:48 |
Reporter | es20490446e | Assigned To | orbweaver | ||
Priority | high | Severity | major | Reproducibility | always |
Status | resolved | Resolution | no change required | ||
Platform | Linux | OS | Arch Linux | ||
Fixed in Version | 3.10.0 | ||||
Summary | 0006511: fails to compile: plugins/vcs/Repository.cpp: invalid conversion: ‘const git_commit**’ to ‘git_commit* const*’ | ||||
Description | darkradiant/src/darkradiant/plugins/vcs/Repository.cpp:370:49: error: invalid conversion from ‘const git_commit**’ to ‘git_commit* const*’ [-fpermissive] 370 | parentCommits.size(), parentCommits.data()); | ~~~~~~~~~~~~~~~~~~^~ | | | const git_commit** In file included from /usr/include/git2/repository.h:14, from /usr/include/git2/annotated_commit.h:11, from /usr/include/git2.h:11, from /home/es20490446e/Documents/Projects/Ikigai/darkradiant/darkradiant/src/darkradiant/plugins/vcs/Reference.h:5, from /home/es20490446e/Documents/Projects/Ikigai/darkradiant/darkradiant/src/darkradiant/plugins/vcs/Repository.h:5, from /home/es20490446e/Documents/Projects/Ikigai/darkradiant/darkradiant/src/darkradiant/plugins/vcs/Repository.cpp:1: /usr/include/git2/commit.h:369:28: note: initializing argument 10 of ‘int git_commit_create(git_oid*, git_repository*, const char*, const git_signature*, const git_signature*, const char*, const char*, const git_tree*, size_t, git_commit* const*)’ 369 | git_commit * const parents[]); | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~ | ||||
Tags | No tags attached. | ||||
https://gitlab.com/kicad/code/kicad/-/merge_requests/1882/diffs | |
Working on a patch... | |
Fix: https://github.com/codereader/DarkRadiant/pull/39 |
|
Eagerly awaiting the fix myself: I can no longer compile and use DarkRadiant over this issue. I use Manjaro Linux which switched to libgit 1.8 recently, this seems to be the cause with DR requiring a fix to support the newer library. Thank you for the pull request and I hope it can be merged ASAP. | |
Is there a specific version of libgit needed to trigger this issue? I cannot reproduce it either with the system installation of libgit2-1.5.1 on Debian 12, or a locally-compiled copy of the latest upstream libgit2-1.9.1 | |
It builds successfully for me using libgit2-1.9.1 on Zenned. | |
Sounds like there's nothing to fix on our side since the issue only occurs with old versions of libgit. Users on distributions which only package a problematic version of libgit can either (1) remove the libgit developer package (which will cause DarkRadiant's CMake not to build the Git plugin); (2) build a local version of the latest upstream libgit 1.9.1 or newer and use CMAKE_PREFIX_PATH to point CMake to it instead of the system-wide version; or (3) use the new CMake option ENABLE_GIT_PLUGIN=OFF which I have added in commit fd2a9e2d64d09ff4f094fa137868fa3c85438218 | |
Date Modified | Username | Field | Change |
---|---|---|---|
31.03.2024 14:23 | es20490446e | New Issue | |
31.03.2024 14:39 | es20490446e | Note Added: 0016605 | |
31.03.2024 14:45 | es20490446e | Note Added: 0016606 | |
31.03.2024 16:09 | es20490446e | Note Added: 0016608 | |
27.05.2024 16:28 | MirceaKitsune | Note Added: 0016711 | |
25.06.2025 17:55 | orbweaver | Relationship added | has duplicate 0006534 |
25.06.2025 17:56 | orbweaver | Severity | crash => major |
25.06.2025 17:56 | orbweaver | Status | new => acknowledged |
25.06.2025 17:56 | orbweaver | Category | Design/Coding => Compilation/Build |
25.06.2025 18:18 | orbweaver | Note Added: 0017050 | |
25.06.2025 22:56 | es20490446e | Note Added: 0017051 | |
01.07.2025 18:48 | orbweaver | Assigned To | => orbweaver |
01.07.2025 18:48 | orbweaver | Status | acknowledged => resolved |
01.07.2025 18:48 | orbweaver | Resolution | open => no change required |
01.07.2025 18:48 | orbweaver | Fixed in Version | => 3.10.0 |
01.07.2025 18:48 | orbweaver | Note Added: 0017052 |