View Issue Details

IDProjectCategoryView StatusLast Update
0006514DarkRadiantGUIpublic13.08.2024 18:59
ReporterMirceaKitsune Assigned Tojonri  
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSManjaroOS VersionStable
Product Version3.9.0 
Fixed in Version3.10.0 
Summary0006514: DarkRadiant crashes when typing in the Skin Name field of the Skin Editor menu
DescriptionDarkRadiant crashes when typing any characters inside the Skin Name field of the Skin Editor menu. DR is compiled from latest Git master. Attached log captured from the console.
Steps To Reproduce1. Go to Map - Skin Editor.
2. Select an editable skin in the fms directory.
3. Click inside the Skin Name field and type.

As soon as you attempt to type a character, DarkRadiant will immediately crash.
TagsCrash
Attached Files
log.txt (6,514 bytes)   
Gtk-Message: 16:02:30.781: Failed to load module "appmenu-gtk-module"
SIGSEGV signal caught: 11
0: /archive/mircea/Games/Quake/TheDarkMod/DarkRadiant_GIT/build/install/bin/../lib/darkradiant/modules/libradiantcore.so(_ZN6applog15SegFaultHandler14_handleSigSegvEi+0x4a7) [0x77b32d4e8ca7]
1: /usr/lib/libc.so.6(+0x40770) [0x77b33485a770]
2: ./darkradiant(+0x594cc0) [0x5e84f2707cc0]
3: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler23ProcessEventIfMatchesIdERK21wxEventTableEntryBasePS_R7wxEvent+0x72) [0x77b335d86e62]
4: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler23SearchDynamicEventTableER7wxEvent+0xd7) [0x77b335d87a97]
5: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler11TryHereOnlyER7wxEvent+0x25) [0x77b335d87df5]
6: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler19ProcessEventLocallyER7wxEvent+0x2f) [0x77b335d87e9f]
7: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler12ProcessEventER7wxEvent+0xda) [0x77b335d87fba]
8: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler18SafelyProcessEventER7wxEvent+0xb) [0x77b335d8a7fb]
9: /usr/lib/libwx_gtk3u_core-3.2.so.0(_ZN15wxTextEntryBase20SendTextUpdatedEventEP8wxWindow+0xc8) [0x77b33566d7f8]
10: /usr/lib/libwx_gtk3u_core-3.2.so.0(+0x653053) [0x77b335853053]
11: /usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x140) [0x77b33464d6c0]
12: /usr/lib/libgobject-2.0.so.0(+0x42a36) [0x77b33467ba36]
13: /usr/lib/libgobject-2.0.so.0(+0x33a42) [0x77b33466ca42]
14: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x37) [0x77b33466cc77]
15: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x94) [0x77b33466cd34]
16: /usr/lib/libgtk-3.so.0(+0x354be9) [0x77b334154be9]
17: /usr/lib/libgtk-3.so.0(gtk_window_propagate_key_event+0xcc) [0x77b334163fcc]
18: /usr/lib/libwx_gtk3u_core-3.2.so.0(+0x5d3a86) [0x77b3357d3a86]
19: /usr/lib/libgtk-3.so.0(+0x8c6cd) [0x77b333e8c6cd]
20: /usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x140) [0x77b33464d6c0]
21: /usr/lib/libgobject-2.0.so.0(+0x42a36) [0x77b33467ba36]
22: /usr/lib/libgobject-2.0.so.0(+0x33335) [0x77b33466c335]
23: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x37) [0x77b33466cc77]
24: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x94) [0x77b33466cd34]
25: /usr/lib/libgtk-3.so.0(+0x354cd5) [0x77b334154cd5]
26: /usr/lib/libgtk-3.so.0(+0x1eed2a) [0x77b333feed2a]
27: /usr/lib/libgtk-3.so.0(gtk_main_do_event+0x9b7) [0x77b333fef797]
28: /usr/lib/libgdk-3.so.0(+0x33b77) [0x77b333d39b77]
29: /usr/lib/libgdk-3.so.0(+0x8c438) [0x77b333d92438]
30: /usr/lib/libglib-2.0.so.0(+0x59f69) [0x77b3360d0f69]
31: /usr/lib/libglib-2.0.so.0(+0xb83a7) [0x77b33612f3a7]
32: /usr/lib/libglib-2.0.so.0(g_main_loop_run+0x127) [0x77b3360d1b97]
33: /usr/lib/libgtk-3.so.0(gtk_main+0x9f) [0x77b333fed2bf]
34: /usr/lib/libwx_gtk3u_core-3.2.so.0(_ZN14wxGUIEventLoop5DoRunEv+0x26) [0x77b3357bef76]
35: /usr/lib/libwx_baseu-3.2.so.0(_ZN15wxEventLoopBase3RunEv+0x32) [0x77b335cd8e52]
36: /usr/lib/libwx_gtk3u_core-3.2.so.0(_ZN8wxDialog9ShowModalEv+0x1c7) [0x77b3358274b7]
37: /archive/mircea/Games/Quake/TheDarkMod/DarkRadiant_GIT/build/install/bin/../lib/darkradiant/libwxutil.so(_ZN6wxutil10DialogBase9ShowModalEv+0xcb) [0x77b33631095b]
38: ./darkradiant(+0x597c82) [0x5e84f270ac82]
39: ./darkradiant(+0x597ce3) [0x5e84f270ace3]
40: /archive/mircea/Games/Quake/TheDarkMod/DarkRadiant_GIT/build/install/bin/../lib/darkradiant/modules/libradiantcore.so(_ZN3cmd13CommandSystem14executeCommandERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERKSt6vectorINS_8ArgumentESaISA_EE+0xa5) [0x77b32d378c55]
41: /archive/mircea/Games/Quake/TheDarkMod/DarkRadiant_GIT/build/install/bin/../lib/darkradiant/modules/libradiantcore.so(_ZN3cmd13CommandSystem7executeERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x53) [0x77b32d37e463]
42: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler23ProcessEventIfMatchesIdERK21wxEventTableEntryBasePS_R7wxEvent+0x72) [0x77b335d86e62]
43: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler23SearchDynamicEventTableER7wxEvent+0xd7) [0x77b335d87a97]
44: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler11TryHereOnlyER7wxEvent+0x25) [0x77b335d87df5]
45: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler19ProcessEventLocallyER7wxEvent+0x2f) [0x77b335d87e9f]
46: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler12ProcessEventER7wxEvent+0xda) [0x77b335d87fba]
47: /usr/lib/libwx_baseu-3.2.so.0(_ZN12wxEvtHandler18SafelyProcessEventER7wxEvent+0xb) [0x77b335d8a7fb]
48: /usr/lib/libwx_gtk3u_core-3.2.so.0(_ZN10wxMenuBase14DoProcessEventEPS_R7wxEventP8wxWindow+0x4e) [0x77b33563b1be]
49: /usr/lib/libwx_gtk3u_core-3.2.so.0(_ZN10wxMenuBase9SendEventEii+0xc3) [0x77b33563b2e3]
50: /usr/lib/libwx_gtk3u_core-3.2.so.0(+0x63602f) [0x77b33583602f]
51: /usr/lib/libgobject-2.0.so.0(g_closure_invoke+0x140) [0x77b33464d6c0]
52: /usr/lib/libgobject-2.0.so.0(+0x42a36) [0x77b33467ba36]
53: /usr/lib/libgobject-2.0.so.0(+0x33a42) [0x77b33466ca42]
54: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x37) [0x77b33466cc77]
55: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x94) [0x77b33466cd34]
56: /usr/lib/libgtk-3.so.0(gtk_widget_activate+0x7d) [0x77b33414128d]
57: /usr/lib/libgtk-3.so.0(gtk_menu_shell_activate_item+0xfd) [0x77b3340052ad]
58: /usr/lib/libgtk-3.so.0(+0x2055ea) [0x77b3340055ea]
59: /usr/lib/libgtk-3.so.0(+0x87829) [0x77b333e87829]
60: /usr/lib/libgobject-2.0.so.0(+0x33b73) [0x77b33466cb73]
61: /usr/lib/libgobject-2.0.so.0(g_signal_emit_valist+0x37) [0x77b33466cc77]
62: /usr/lib/libgobject-2.0.so.0(g_signal_emit+0x94) [0x77b33466cd34]
63: /usr/lib/libgtk-3.so.0(+0x354cd5) [0x77b334154cd5]
64: /usr/lib/libgtk-3.so.0(+0x1eec6b) [0x77b333feec6b]
65: /usr/lib/libgtk-3.so.0(gtk_main_do_event+0x9b7) [0x77b333fef797]
66: /usr/lib/libgdk-3.so.0(+0x33b77) [0x77b333d39b77]
67: /usr/lib/libgdk-3.so.0(+0x8c438) [0x77b333d92438]
68: /usr/lib/libglib-2.0.so.0(+0x59f69) [0x77b3360d0f69]
69: /usr/lib/libglib-2.0.so.0(+0xb83a7) [0x77b33612f3a7]
70: /usr/lib/libglib-2.0.so.0(g_main_loop_run+0x127) [0x77b3360d1b97]
71: /usr/lib/libgtk-3.so.0(gtk_main+0x9f) [0x77b333fed2bf]
72: /usr/lib/libwx_gtk3u_core-3.2.so.0(_ZN14wxGUIEventLoop5DoRunEv+0x26) [0x77b3357bef76]
73: /usr/lib/libwx_baseu-3.2.so.0(_ZN15wxEventLoopBase3RunEv+0x32) [0x77b335cd8e52]
74: /usr/lib/libwx_baseu-3.2.so.0(_ZN16wxAppConsoleBase8MainLoopEv+0x78) [0x77b335cb4f78]
75: /usr/lib/libwx_baseu-3.2.so.0(_Z7wxEntryRiPPw+0x50) [0x77b335d16410]
76: ./darkradiant(+0x1887fe) [0x5e84f22fb7fe]
77: /usr/lib/libc.so.6(+0x29cd0) [0x77b334843cd0]
78: /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x77b334843d8a]
79: ./darkradiant(+0x198265) [0x5e84f230b265]
log.txt (6,514 bytes)   

Relationships

has duplicate 0006239 closedorbweaver Crash in skin editor 

Activities

MirceaKitsune

MirceaKitsune

02.04.2024 13:19

reporter   ~0016613

Last edited: 02.04.2024 13:21

Further observations in the Skin Editor menu: Sometimes pressing the esc key in sub-menus or closing the skin editor also causes DR to crash. At some point the skin fields stop being selectable and editable, you need to switch to a different tab and back. Using the Save Skin button causes all changes to be lost and undone.
datiswous

datiswous

04.04.2024 09:26

reporter   ~0016615

I already reported about this in this bug report:

https://bugs.thedarkmod.com/view.php?id=6239

And in this forum topic:

https://forums.thedarkmod.com/index.php?/topic/21717-darkradiant-crashes-when-trying-to-change-the-name-of-a-newly-created-skin-in-the-skin-editor/

This was already happening in v. 3.7.0 but it seems nobody bothered to take a look.
orbweaver

orbweaver

13.08.2024 18:59

developer   ~0016811

This (and a few other ergonomic issues with the Skin Editor) should be fixed as of 318fd28d61bd91fc79a722f5161b37621fa79a16.

Related Changesets

DarkRadiant: master debc7152

24.04.2024 18:29

orbweaver


Details Diff
0006514: minor layout tweaks in Skin Editor

Remove low-information static labels; shorten button labels and set
correct stock wxIDs (although I'm not sure if the IDs do anything here).
Affected Issues
0006514
mod - install/ui/skineditor.fbp Diff File
mod - install/ui/skineditor.xrc Diff File
mod - radiant/ui/skin/SkinEditor.cpp Diff File

DarkRadiant: master b67318f5

24.04.2024 18:48

orbweaver


Details Diff
0006514: Skin Name text control only commits changes on ENTER

The previous event was emitted on every character change, which was far
too frequent and led to performance problems and strange behaviour. By
setting the PROCESS_ENTER style flag we can connect instead to an event
which is only emitted when the ENTER key is pressed, which is the more
usual behaviour when editing the name of something in a text field.
Affected Issues
0006514
mod - install/ui/skineditor.fbp Diff File
mod - install/ui/skineditor.xrc Diff File
mod - radiant/ui/skin/SkinEditor.cpp Diff File

DarkRadiant: master b3aaf558

19.06.2024 18:40

orbweaver


Details Diff
0006514: initial material replacement edit boxes

Add "Replace" and "With" text boxes underneath the skin editor's
material replacements list. The text boxes are populated with the
selected material information, although editing them does not have any
effect.
Affected Issues
0006514
mod - install/ui/skineditor.fbp Diff File
mod - install/ui/skineditor.xrc Diff File
mod - radiant/ui/skin/SkinEditor.cpp Diff File
mod - radiant/ui/skin/SkinEditor.h Diff File

DarkRadiant: master b97b7df6

25.06.2024 18:32

orbweaver


Details Diff
0006514: add "browse" buttons for Replace/With text boxes

These are using a relative path to the bitmap set directly in the
FBP/XRC file, rather than the "darkradiant:" art provider prefix, which
allows the icons to appear in wxFormBuilder. This works correctly in GTK
since the relative path between XRC and bitmap is the same, and
hopefully will work in Windows too.

The browse buttons show a material chooser to choose a new material for
the associated text box, although the chosen material is not yet being
applied to the skin.
Affected Issues
0006514
mod - install/ui/skineditor.fbp Diff File
mod - install/ui/skineditor.xrc Diff File
mod - radiant/ui/skin/SkinEditor.cpp Diff File
mod - radiant/ui/skin/SkinEditor.h Diff File

DarkRadiant: master c0a5a24b

02.07.2024 18:48

orbweaver


Details Diff
0006514: "Choose source material" disabled for wildcard row

The text entry was already disabled when the "*" row is selected; now
the browse button is also disabled.
Affected Issues
0006514
mod - radiant/ui/skin/SkinEditor.cpp Diff File
mod - radiant/ui/skin/SkinEditor.h Diff File

DarkRadiant: master a154a7fb

03.07.2024 18:19

orbweaver


Details Diff
0006514: replacement material is now applied to skin after browsing

If the browse button was clicked and the result was OK, call the
onReplacementEntryChanged method to apply the change to the data model.
This does not yet apply if the replacement material entry box is edited
manually.
Affected Issues
0006514
mod - radiant/ui/skin/SkinEditor.cpp Diff File

DarkRadiant: master 6fcd0d3f

03.07.2024 18:38

orbweaver


Details Diff
0006514: material text entries are read-only

Updating the skin on manual editing isn't yet implemented (and may not
be important) so keep the text entry boxes read-only for now.
Affected Issues
0006514
mod - install/ui/skineditor.fbp Diff File
mod - install/ui/skineditor.xrc Diff File

DarkRadiant: master 0ed4f4d9

03.07.2024 18:47

orbweaver


Details Diff
0006514: original material browse button now applies changes to list Affected Issues
0006514
mod - radiant/ui/skin/SkinEditor.cpp Diff File
mod - radiant/ui/skin/SkinEditor.h Diff File

DarkRadiant: master 4ba6b8d5

09.07.2024 18:54

orbweaver


Details Diff
0006514: remove custom MaterialSelectorColumn from SkinEditor

None of this ever worked on GTK, and trying to debug such a rarely-used
corner of the wxWidgets API seems like more trouble than it's worth now
that the separate entry boxes and browse buttons are providing the same
functionality.
Affected Issues
0006514
rm - radiant/ui/skin/MaterialSelectorColumn.h Diff
mod - radiant/ui/skin/SkinEditor.cpp Diff File
mod - radiant/ui/skin/SkinEditor.h Diff File

DarkRadiant: master 7f8db4fa

10.07.2024 18:31

orbweaver


Details Diff
0006514: autosize remapping list columns

Columns now expand to contain the (possibly long) material names, with
the widget showing a horizontal scrollbar if necessary.
Affected Issues
0006514
mod - radiant/ui/skin/SkinEditor.cpp Diff File

DarkRadiant: master 237069c1

16.07.2024 17:55

orbweaver


Details Diff
0006514: remove Style::fontsize member variable

Per-element font sizes are not used anywhere (and would be highly
unusual in a source code editor). The value is still currently
hard-coded, but is not stored separately in each Style object.
Affected Issues
0006514
mod - libs/wxutil/sourceview/SourceView.cpp Diff File
mod - libs/wxutil/sourceview/SourceView.h Diff File

DarkRadiant: master 3c5bf0d7

16.07.2024 18:49

orbweaver


Details Diff
0006514: improve size hinting of preferences dialog

- PrefPage no longer derives from wxScrolledWindow; instead it is just a
simple wxPanel. This causes it to report an accurate size hint,
instead of a suggested height of -1.
- All hard-coded sizes or screen proportions removed from PrefDialog.
The dialog is now sized entirely based on the size hints of the
contained panels.
- To prevent the dialog from become too large as a result of the lack of
scrollable panels, several redundant visibility toggles have been removed
from the Orthoview panel. All of the removed items are available in
the View -> Show menu so there is no need for them to be duplicated in
the Orthoview preferences.
Affected Issues
0006514
mod - radiant/ui/prefdialog/PrefDialog.cpp Diff File
mod - radiant/ui/prefdialog/PrefDialog.h Diff File
mod - radiant/ui/prefdialog/PrefPage.cpp Diff File
mod - radiant/ui/prefdialog/PrefPage.h Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File

DarkRadiant: master 5c220668

17.07.2024 18:39

orbweaver


Details Diff
0006514: remove placeholder "Game" page from preferences dialog

It's been 7 years since this placeholder was added; I doubt anyone's
still looking for the game settings here.
Affected Issues
0006514
mod - radiantcore/settings/GameManager.cpp Diff File

DarkRadiant: master ffe51db1

17.07.2024 18:52

orbweaver


Details Diff
0006514: remove "Settings" root node from preference page tree

All preference pages exist at the same level in the tree; this empty
root node was just a waste of space.
Affected Issues
0006514
mod - plugins/dm.gui/plugin.cpp Diff File
mod - plugins/vcs/GitModule.cpp Diff File
mod - radiant/camera/CameraSettings.cpp Diff File
mod - radiant/map/AutoSaveTimer.cpp Diff File
mod - radiant/settings/LocalisationModule.cpp Diff File
mod - radiant/ui/mainframe/MainFrame.cpp Diff File
mod - radiant/ui/texturebrowser/TextureBrowserManager.cpp Diff File
mod - radiant/xyview/GlobalXYWnd.cpp Diff File
mod - radiantcore/brush/BrushModule.cpp Diff File
mod - radiantcore/clipper/Clipper.cpp Diff File
mod - radiantcore/grid/GridManager.cpp Diff File
mod - radiantcore/map/autosaver/AutoSaver.cpp Diff File
mod - radiantcore/map/mru/MRU.cpp Diff File
mod - radiantcore/model/ModelFormatManager.cpp Diff File
mod - radiantcore/patch/PatchModule.cpp Diff File
mod - radiantcore/selection/RadiantSelectionSystem.cpp Diff File
mod - radiantcore/settings/PreferenceSystem.h Diff File
mod - radiantcore/undo/UndoSystemFactory.cpp Diff File

Issue History

Date Modified Username Field Change
02.04.2024 13:11 MirceaKitsune New Issue
02.04.2024 13:11 MirceaKitsune Tag Attached: Crash
02.04.2024 13:11 MirceaKitsune File Added: log.txt
02.04.2024 13:19 MirceaKitsune Note Added: 0016613
02.04.2024 13:21 MirceaKitsune Note Edited: 0016613
04.04.2024 09:26 datiswous Note Added: 0016615
04.04.2024 09:34 datiswous Relationship added related to 0006239
06.04.2024 13:47 jonri Assigned To => jonri
06.04.2024 13:47 jonri Status new => assigned
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master debc7152
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master b67318f5
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master b3aaf558
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master b97b7df6
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master c0a5a24b
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master a154a7fb
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 6fcd0d3f
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 0ed4f4d9
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 4ba6b8d5
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 7f8db4fa
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 237069c1
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 3c5bf0d7
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master 5c220668
23.07.2024 11:36 orbweaver Changeset attached => DarkRadiant master ffe51db1
13.08.2024 18:57 orbweaver Relationship replaced has duplicate 0006239
13.08.2024 18:59 orbweaver Status assigned => resolved
13.08.2024 18:59 orbweaver Resolution open => fixed
13.08.2024 18:59 orbweaver Fixed in Version => 3.10.0
13.08.2024 18:59 orbweaver Note Added: 0016811