View Issue Details

IDProjectCategoryView StatusLast Update
0006560The Dark ModCodingpublic27.07.2024 15:56
Reporterstgatilov Assigned Tostgatilov  
PrioritynormalSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product VersionTDM 2.12 
Target VersionTDM 2.13Fixed in VersionTDM 2.13 
Summary0006560: r_showTris wireframe has random colors
DescriptionNormally, r_showTris should draw all wireframe as white.
But there colors is randomized arbitrarily since recently.
TagsNo tags attached.

Activities

stgatilov

stgatilov

25.07.2024 10:38

administrator   ~0016804

I think it get broken when I refactored Attributes::EnableVertex[Regular|Shadow|Immediate].
This happens when ImmediateRendering is "flushed", but color override is set before that.
When color override is set, color vertex attribute is disabled... but then EnableVertexImmediate restores it back.
stgatilov

stgatilov

27.07.2024 15:56

administrator   ~0016805

Commits:
  r10839 Replaced GL_FloatColor and ColorOverride back to qglColor3f and similar in GUI tools.
  r10840 Now VAO, vertex formats, and attribute overrides are all managed by new VertexArrayState singleton. It makes sense because all these states get mixed in pretty weird way in OpenGL.
  r10841 Now VertexArrayState also manages VBO binds.
  r10842 Deleted glsl.h/cpp, where only a single function remained.
  r10843 Added forgetten cpp file for previous commit.

Now VertexArrayState manages everything, so there is less chance we mess up attributes.

Issue History

Date Modified Username Field Change
25.07.2024 10:18 stgatilov New Issue
25.07.2024 10:18 stgatilov Status new => assigned
25.07.2024 10:18 stgatilov Assigned To => stgatilov
25.07.2024 10:38 stgatilov Note Added: 0016804
27.07.2024 15:56 stgatilov Note Added: 0016805
27.07.2024 15:56 stgatilov Status assigned => resolved
27.07.2024 15:56 stgatilov Resolution open => fixed
27.07.2024 15:56 stgatilov Fixed in Version => TDM 2.13