 |
Addendum: Forgot to mention, the test map I created to reproduce the bug is attached to this issue as "absence_notice_test.zip". File contains a simple map that should demonstrate the problem behaviour if steps for reproduction are followed in TDM 2.13 and 2.12 |
 |
I wonder if the issue goes away with "g_lightQuotientAlgo 0". That's the cvar to restore the old code for light computations for AI and the like. |
|
|
I can confirm that "g_lightQuotientAlgo 0" restores normal behavior in TDM 2.13 with regard to noticing missing objects in the test map provided below. |
|
|
From https://bugs.thedarkmod.com/view.php?id=6546#c17056: =========================================== Supported blood markers and absence markers. The list of commits: r11002 If spawnarg "les_sample_invisible" = 1, then LightEstimateSystem checks samples with invisible materials as well. r11003 CAbsenceMarker now uses the model and transform of its owner (i.e. the missing item). r11006 Properly supported blood markers in Light Estimate System. r11007 Minor fix for debug visualization. r17335 Properly configured absence marker to be invisible but included in LES + added default box model. r17340 Updated spawnargs for atdm:blood_marker for proper handling in LES. With absence marker, I managed to solve the problem "the easy way". When absence marker is created, I set its model to the model of the entity that disappeared. Of course, the marker should be invisible, so set "invisible" skin in entityDef, which replaces all material with nodraw. But since LES normally ignore samples from invisible materials, I also added "les_sample_invisible" spawnarg so that it makes an exception this time. So the absence marker simply retains the samples of the model. This works OK most of the time, although sometimes some of these samples are permanently unlit because they are inside solids. For example, the paintings in Scroll of Remembrance partially overlap with their frames. So when player takes a painting, some of its samples end up inside the frame... and thus they are completely unlit because they are considered shadowed by the frame. As the result, light value decreases, which makes it harder for a guard to notice the absence. The blood marker was much harder to support, because its geometry is just a decal on other models (which is reapplied regularly). I had to implement the concept of "explicit model sampling", which one can set for an entity to override the sampling taken from model automatically. Implementing this concept was hell of a ride. I created three prototypes: making auxilliary rendermodel to be sampled, passing explicit sampling but storing it inside LES, passing explicit sampling and storing it inside entity itself. The last one looks the most sane, so I sticked to it. The explicit sampling is an inherent part of the entity state, so it is saved/restored in savegames... although it's not that important for blood markers, since they recreate themselves 2 times per second. So when the blood marker code applies a decal, it also generates a grid of sample points on the decal surfaces (hopefully a bit above the obstacles) and set it as override. Sadly, the entity still has to have some "rendermodel", even if it's invisible and LES ignores it too. That's because there is LightQuerySystem --- the counterpart which actually computes lighting inside renderer frontend. And this system reads entity transform from renderentity. And if a game entity has no model, it does not create a renderentity! =========================================== |
- Anonymous
