View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004291The Dark ModCodingpublic28.02.2016 19:0714.10.2024 04:29
ReporterAgent Jones Assigned ToDaft Mugi  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product VersionTDM 2.03 
Target VersionTDM 2.13Fixed in VersionTDM 2.13 
Summary0004291: List of missions in Downloadable Missions is not cleared if network connection is lost after update of mission list
DescriptionIn 2.03, trying to download a mission when connection was lost resulted in a crash.
In 2.12/64 #10651, it has unwanted cosmetic effects.

In both cases the issue seem to stem from that the list of missions in "Downloadable Missions" is not cleared if network connection is lost after update of mission list.

Proposed solutions: (both 1 and 2)
1) Clear the list of available missions if network is lost
2) When user clicks "Start Download", check if network is available and inform user if it is not available
Steps To ReproduceIn 2.03:
-Click on Download Missions, download mission list.
-Lose your connection.
-Select a mission and try to download it.
-Click OK when the connection error comes up.
-The _selectedMods list won't be wiped unless you change page. If you select something for download again the game will crash. The error occurs at line 596 in DownloadMenu.cpp [gui->SetStateString(va("dl_mission_name_%d", i), modIndex != -1 ? mods[modIndex]->title : "");]

In 2.12/64 #10651:
* Make sure computer is connected to the network
* From main menu, go to Missions - Download missions
* The list will update after connecting to the server
* Wait for the update to finish
* Remove network cable from computer
* From the list "Downloadable Missions", select a mission and click "More"
* A dialog reads "Failed to download the details XML file" (expected)
* From the list "Downloadable Missions", select a mission for download by moving it to the list "Selected for Download" and click "Start Download"
* A dialog titled "Mission Download Result" reads "1 mission(s) couldn't be downloaded. Please check your disk space (or maybe some file is write protected) and try again." (text is unexpected since it does not correctly identify the problem)
* Click OK
* A dialog titled "Unable to Contact Mission Archive" reads "Cannot connect to server" (correctly identifies the problem)
* Click OK
* The mission is automatically removed from the list "Selected for Download"
* The list "Downloadable Missions" keeps the list of the missions (possibly unexpected)
* Select a mission and click "Select for Download"
* A text appears in "Downloadable Missions" reading "No new mission packages available for download" (expected) but this is very difficult to read because the list of missions were not cleared (unexpected)
* Reinsert network cable.
* Select a mission and click "Selected for Download".
* Nothing happens (unexpected, since the list of missions is visible and missions can be selected)
Additional Informationas a fix, tell the game to clear the list if we've lost connection.
line 73, file DownloadMenu.cpp:

_selectedListTop = 0;
_selectedMods.Clear();
UpdateGUI(gui);
UpdateDownloadProgress(gui);
Tagsgui

Relationships

related to 0006339 resolvedDaft Mugi Revamp mission and download list screens 
related to 0005551 resolvedstgatilov Rework FM database to use SVN as primary storage 

Activities

nbohr1more

nbohr1more

02.01.2023 03:55

developer   ~0015665

Last edited: 02.01.2023 04:31

 Looks like the equivalent fix should now be at line 67 and should now be:

gui->DeleteStateVar("downloadSelectedList_item_0");
_selectedMods.Clear();
UpdateDownloadProgress(gui);
UpdateGUI(gui);
datiswous

datiswous

06.08.2024 17:07

reporter   ~0016810

Is this fixed or not?
Fiver

Fiver

05.10.2024 19:54

reporter   ~0016857

@datiswous: I tested this on 2.12 and I have updated the issue. It does not crash in 2.12, but there are some cosmetic issues which could possibly be resolved by the solution outlined by @nbohr1more. If it is not reassigned, I suggest it be set to state Acknowledged since it was last assigned in 2016 and it seems unlikely anyone is currently working on it.
Daft Mugi

Daft Mugi

05.10.2024 21:36

developer   ~0016859

Fixed as part of 0006339.
Included in TDM 2.13-dev (dev17121-10869).
Fiver

Fiver

13.10.2024 20:55

reporter   ~0016870

I tested this on 2.13/64 #10890:
1) The dialog "check your disk space" still appears (unexpected)
2) The list is now cleared after clicking OK on the dialog "Unable to Contact Mission Archive" (expected)
3) The list view is now completely empty (and it did not add the text "No new mission packages available for download" like before)

Overall, the implementation is an improvement and acceptable for the originally reported issue. Perhaps a new issue should be created to tweak for issues 1 and 3 (and some other unexpected behaviors) so that this issue can be set to fixed.

Issue History

Date Modified Username Field Change
28.02.2016 19:07 Agent Jones New Issue
28.02.2016 19:07 Agent Jones Status new => assigned
28.02.2016 19:07 Agent Jones Assigned To => Agent Jones
01.01.2023 19:02 nbohr1more Relationship added related to 0005551
02.01.2023 03:55 nbohr1more Note Added: 0015665
02.01.2023 04:31 nbohr1more Note Edited: 0015665
06.08.2024 17:07 datiswous Note Added: 0016810
05.10.2024 19:51 Fiver Severity crash => minor
05.10.2024 19:51 Fiver Summary Downloader crash after connection loss => List of missions in Downloadable Missions is not cleared if network connection is lost after update of mission list
05.10.2024 19:51 Fiver Description Updated
05.10.2024 19:51 Fiver Steps to Reproduce Updated
05.10.2024 19:53 Fiver Tag Attached: gui
05.10.2024 19:54 Fiver Note Added: 0016857
05.10.2024 21:29 Daft Mugi Assigned To Agent Jones => Daft Mugi
05.10.2024 21:35 Daft Mugi Relationship added related to 0006339
05.10.2024 21:36 Daft Mugi Note Added: 0016859
05.10.2024 21:37 Daft Mugi Status assigned => feedback
05.10.2024 21:37 Daft Mugi Target Version => TDM 2.13
13.10.2024 20:55 Fiver Steps to Reproduce Updated
13.10.2024 20:55 Fiver Note Added: 0016870
14.10.2024 00:54 Daft Mugi Status feedback => resolved
14.10.2024 04:29 nbohr1more Resolution open => fixed
14.10.2024 04:29 nbohr1more Fixed in Version => TDM 2.13