Source Control Integration - The Dark Mod Bugtracker

master e68aff09 14.09.2022 19:24 orbweaver Details Diff	0006095: test sorted list of Game objects Test that the IGameManager::getSortedGameList() method returns the vector of games in the expected order (defined by the "index" property in the XML file). To confirm which game is which, the getName() method is exposed on the pure virtual interface (it was already present on the implementing class).	Affected Issues 0006095
	mod - include/igame.h	Diff File
	mod - radiantcore/settings/Game.cpp	Diff File
	mod - radiantcore/settings/Game.h	Diff File
	mod - test/Game.cpp	Diff File
master 9b05e8bd 13.09.2022 20:01 orbweaver Details Diff	0006095: add a trivial test for the GameManager This may not turn out to be all that useful, since the RadiantTest sets up a fake game by responding on the message bus, and never actually loads any .game files. Currently it is testing only that the game manager can return the expected config struct which reflects the fake game info populated by RadiantTest.	Affected Issues 0006095
	mod - libs/string/split.h	Diff File
	mod - test/CMakeLists.txt	Diff File
	mod - test/DeclManager.cpp	Diff File
	mod - test/EntityClass.cpp	Diff File
	add - test/Game.cpp	Diff File
	mod - test/Particles.cpp	Diff File
	mod - test/RadiantTest.h	Diff File
master 06f210b2 11.09.2022 11:24 greebo Details Diff	0006093: Some pending threads might access user code that should be finished before all modules are shut down	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
master 5e1ddb1f 11.09.2022 11:07 greebo Details Diff	0006093: Don't immediately remove pending tasks from the lists	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
master 7a0364f7 11.09.2022 10:15 greebo Details Diff	0006093: Wait for all pending clean up tasks before leaving waitForTypedParsersToFinish()	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
	mod - radiantcore/decl/DeclarationManager.h	Diff File
master 36a765d8 11.09.2022 09:12 greebo Details Diff	0006093: It's possible to move the std::future, but that's not advisable as long as some other code holds a C++ reference to it...	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
	mod - radiantcore/decl/DeclarationManager.h	Diff File
master e8853081 11.09.2022 08:04 greebo Details Diff	0006093: Circumvent a problem during reloadDecls. When assigning the new syntax block to an existing declaration, the changed signal might trigger a new call to the DeclarationManager API, which waits for the parser tasks to finish. The finish tasks must not employ any locks, otherwise it will deadlock.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
master 75b01acf 11.09.2022 05:45 greebo Details Diff	0006093: More code to ensure that pending cleanup tasks are not interfering with module shutdown.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
	mod - radiantcore/decl/DeclarationManager.h	Diff File
master 137905aa 10.09.2022 19:03 greebo Details Diff	0006093: Fix another deadlock occurring when parsers are cleaned up in a worker thread.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
	mod - radiantcore/decl/DeclarationManager.h	Diff File
master 897be386 10.09.2022 16:38 greebo Details Diff	0006093: Don't release the lock while iterating over the container the code is processing.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
master 76c1c434 10.09.2022 15:27 greebo Details Diff	0006093: Log any exception occurring in the ThreadedDeclParser thread.	Affected Issues 0006093
	mod - libs/parser/ThreadedDeclParser.h	Diff File
master 09614dd8 10.09.2022 15:12 greebo Details Diff	0006093: Further tweak the DeclarationManager to wait for all parsers to finish before serving any queries. Since decls like Tables (or stricly speaking any decl) cannot be pinned down to a single directory, any running parser might be coming home with the decl type/name combination the client is looking for.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
	mod - test/DeclManager.cpp	Diff File
master 24399fa2 10.09.2022 14:07 greebo Details Diff	0006097: All xml::Document or xml::Node operations now require the mutex to be locked	Affected Issues 0006097
	mod - libs/xmlutil/Document.cpp	Diff File
	mod - libs/xmlutil/Node.cpp	Diff File
master 050f5e06 10.09.2022 13:56 greebo Details Diff	0006097: Every xml::Node now holds a reference to the owning xml::Document, which exposes its mutex to its Node friends.	Affected Issues 0006097
	mod - libs/xmlutil/Document.cpp	Diff File
	mod - libs/xmlutil/Document.h	Diff File
	mod - libs/xmlutil/Node.cpp	Diff File
	mod - libs/xmlutil/Node.h	Diff File
	mod - radiant/eventmanager/ShortcutSaver.h	Diff File
	mod - radiantcore/map/format/portable/PortableMapWriter.cpp	Diff File
	mod - radiantcore/xmlregistry/RegistryTree.cpp	Diff File
	mod - radiantcore/xmlregistry/RegistryTree.h	Diff File
	mod - radiantcore/xmlregistry/XMLRegistry.cpp	Diff File
	mod - test/XmlUtil.cpp	Diff File
master 28819a3b 10.09.2022 11:54 greebo Details Diff	0006097: Fix xmlutil::Node::addText implementation	Affected Issues 0006097
	mod - libs/xmlutil/Node.cpp	Diff File
master 4af30f87 10.09.2022 11:52 greebo Details Diff	0006097: Add more xmlutil::Node unit tests	Affected Issues 0006097
	mod - test/XmlUtil.cpp	Diff File
master b5b51c1f 10.09.2022 11:25 greebo Details Diff	0006097: Add xmlutil::Node unit tests	Affected Issues 0006097
	mod - test/XmlUtil.cpp	Diff File
	mod - test/resources/xml/testfile.xml	Diff File
master f8e1eaf2 10.09.2022 10:25 greebo Details Diff	0006097: Remove public access to the private xmlNodePtr, allow friend access to xmlutil::Document	Affected Issues 0006097
	mod - libs/xmlutil/Document.cpp	Diff File
	mod - libs/xmlutil/Node.cpp	Diff File
	mod - libs/xmlutil/Node.h	Diff File
	mod - radiantcore/map/format/portable/PortableMapWriter.cpp	Diff File
master 0f1d8655 10.09.2022 09:53 greebo Details Diff	0006093: Re-enable the disabled unit test	Affected Issues 0006093
	mod - test/DeclManager.cpp	Diff File
master c1348a64 10.09.2022 08:54 greebo Details Diff	0006097: xmlutil::Document unit tests	Affected Issues 0006097
	mod - test/XmlUtil.cpp	Diff File
	add - test/resources/xml/broken_file.xml	Diff File
	add - test/resources/xml/testfile.xml	Diff File
master ffb76029 10.09.2022 08:53 greebo Details Diff	0006097: Remove the dangerous copy-constructor which will trigger a crash as soon as the second copy goes out of scope.	Affected Issues 0006097
	mod - libs/xmlutil/Document.cpp	Diff File
	mod - libs/xmlutil/Document.h	Diff File
master 27923433 10.09.2022 07:57 greebo Details Diff	0006097: Start creating unit tests covering the xmlutil::Document type	Affected Issues 0006097
	mod - libs/xmlutil/Document.cpp	Diff File
	mod - test/CMakeLists.txt	Diff File
	add - test/XmlUtil.cpp	Diff File
	mod - test/algorithm/FileUtils.h	Diff File
	mod - tools/msvc/Tests/Tests.vcxproj	Diff File
	mod - tools/msvc/Tests/Tests.vcxproj.filters	Diff File
master dd095239 10.09.2022 06:11 greebo Details Diff	0006093: Signals are stored in a map that should not be modified simultaneously. Signals are only ever added once to the map (which needs to happen in a synchronised fashion), afterwards it's safe to hand out references to the existing signals.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File
	mod - radiantcore/decl/DeclarationManager.h	Diff File
master 8d7f4a34 10.09.2022 05:30 greebo Details Diff	0006093: Ensure that DefParser subclasses are invoking reset() before the destructor is taking the instance table apart.	Affected Issues 0006093
	mod - libs/parser/ThreadedDeclParser.h	Diff File
	mod - libs/parser/ThreadedDefLoader.h	Diff File
	mod - radiantcore/decl/DeclarationFolderParser.h	Diff File
master b0e32b22 10.09.2022 03:26 greebo Details Diff	0006093: Attempt to resolve the scenario of two threads attempting to delete the same parser instance, which can occur by moving the unique_ptr simultaneously.	Affected Issues 0006093
	mod - radiantcore/decl/DeclarationManager.cpp	Diff File

Changesets: DarkRadiant