Source Control Integration - The Dark Mod Bugtracker

textool f9cf7d08 30.09.2021 18:31 greebo Details Diff	0005746: Add unit test cycle-selecting over a few patch nodes covering the same UV space	Affected Issues 0005746
	mod - test/TextureTool.cpp	Diff File
master bfc72698 29.09.2021 19:48 Matthew Mott Details Diff	Add Matrix4 column setters New methods setXCol, setYCol and setZCol will replace the cast-based reference accessors. Covered by a unit test, but not yet used in real code.
	mod - libs/math/Matrix4.h	Diff File
	mod - test/math/Matrix4.cpp	Diff File
master 43b99afd 29.09.2021 19:12 Matthew Mott Details Diff	Replace calls to Matrix4::tCol().getVector3() with translation()
	mod - libs/Transformable.h	Diff File
	mod - libs/pivot.h	Diff File
	mod - radiantcore/entity/target/TargetLineNode.cpp	Diff File
	mod - radiantcore/map/algorithm/Export.cpp	Diff File
	mod - radiantcore/patch/PatchNode.cpp	Diff File
	mod - radiantcore/selection/algorithm/Transformation.cpp	Diff File
	mod - radiantcore/selection/manipulators/ManipulatorComponents.cpp	Diff File
	mod - radiantcore/selection/manipulators/RotateManipulator.cpp	Diff File
	mod - test/Selection.cpp	Diff File
textool 5a0e7bd4 29.09.2021 18:44 greebo Details Diff	Disable the warning that was emitted when no listeners are subscribed to a certain message type.
	mod - radiantcore/messagebus/MessageBus.h	Diff File
textool 5e524008 29.09.2021 03:59 greebo Details Diff	0005746: Implement TextureToolCycleSelectionTool (Alt-Shift-LMB)	Affected Issues 0005746
	mod - install/input.xml	Diff File
	mod - radiant/selection/SelectionMouseTools.cpp	Diff File
	mod - radiant/selection/SelectionMouseTools.h	Diff File
	add - radiant/textool/tools/TextureToolCycleSelectionTool.h	Diff File
	mod - radiant/textool/tools/TextureToolSelectionTool.h	Diff File
	mod - radiant/ui/mousetool/RegistrationHelper.h	Diff File
	mod - radiantcore/selection/textool/TextureToolSelectionSystem.cpp	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj	Diff File
	mod - tools/msvc/DarkRadiant.vcxproj.filters	Diff File
master 71966e76 28.09.2021 20:01 Matthew Mott Details Diff	Fix some incorrect uses of zCol3() A couple of missed cases where the value returned from zCol3() was treated as a reference.
	mod - radiantcore/brush/TextureProjection.cpp	Diff File
	mod - radiantcore/particles/RenderableParticleBunch.cpp	Diff File
master 8eca9e4d 28.09.2021 19:49 Matthew Mott Details Diff	Streamline Matrix4::translation() and tCol() translation() was calling tCol().getVector3(), but tCol() was constructing the Vector4 by appending the tw() component, only to have it stripped off again by the call to getVector3(). These methods are now flipped around so that translation() uses the Eigen API to extract the first 3 components directly, and tCol() then adds the tw() component to create a Vector4.
	mod - libs/math/Matrix4.h	Diff File
master 1aef650a 28.09.2021 19:35 Matthew Mott Details Diff	Remove Matrix4::tColRef() Another reinterpret_cast bites the dust.
	mod - libs/math/Matrix4.h	Diff File
	mod - test/math/Matrix4.cpp	Diff File
master 5e506898 28.09.2021 19:08 Matthew Mott Details Diff	ManipulationPivot no longer uses Matrix4::tcolRef() tCol().getVector3() can more clearly be expressed as Matrix4::translation(). The modifying version is replaced with a new Matrix4::setTranslation() method.
	mod - libs/math/Matrix4.h	Diff File
	mod - radiantcore/selection/ManipulationPivot.cpp	Diff File
	mod - radiantcore/selection/ManipulationPivot.h	Diff File
textool b1b827a4 28.09.2021 18:29 greebo Details Diff	0005746: Remove unnecessary code from TextureToolSelectionTool	Affected Issues 0005746
	mod - radiant/textool/tools/TextureToolSelectionTool.h	Diff File
textool 8ddd6f5e 28.09.2021 17:57 greebo Details Diff	0005746: Remove empty interface type, use the IOrthoViewBase type for the Texture Tool.	Affected Issues 0005746
	rm - include/itexturetoolview.h	Diff
	mod - radiant/textool/TexTool.h	Diff File
	mod - radiant/textool/tools/TextureToolMouseEvent.h	Diff File
	mod - tools/msvc/include.vcxproj	Diff File
textool eb8ed2d0 28.09.2021 04:28 greebo Details Diff	0005731: Icon tweak	Affected Issues 0005731
	mod - install/bitmaps/bulb_lit.png	Diff File
textool 3e59d2b5 27.09.2021 19:15 greebo Details Diff	0005731: Determine the theme based on the editor image's average pixel values	Affected Issues 0005731
	mod - include/itexturetoolcolours.h	Diff File
	mod - radiant/textool/TexTool.cpp	Diff File
	mod - radiant/textool/TexTool.h	Diff File
	mod - radiantcore/selection/textool/ColourSchemeManager.cpp	Diff File
textool 910037c7 27.09.2021 18:48 greebo Details Diff	0005731: Add icons and toggle events	Affected Issues 0005731
	add - install/bitmaps/bulb_lit.png	Diff File
	add - install/bitmaps/bulb_unlit.png	Diff File
	mod - install/user.xml	Diff File
	mod - radiant/textool/TexTool.cpp	Diff File
textool 2cd3a942 27.09.2021 05:16 greebo Details Diff	0005731: Add theme switch commands	Affected Issues 0005731
	mod - radiantcore/selection/textool/ColourSchemeManager.cpp	Diff File
textool 3fc073e5 27.09.2021 05:09 greebo Details Diff	0005731: Adjust the manipulator rendering routines	Affected Issues 0005731
	mod - include/itexturetoolcolours.h	Diff File
	mod - radiantcore/selection/textool/ColourSchemeManager.cpp	Diff File
	mod - radiantcore/selection/textool/TextureToolRotateManipulator.cpp	Diff File
textool 7157b927 27.09.2021 04:45 greebo Details Diff	0005731: Adjust the FaceNode/PatchNode rendering routines.	Affected Issues 0005731
	mod - include/itexturetoolcolours.h	Diff File
	mod - radiantcore/selection/textool/ColourSchemeManager.cpp	Diff File
	mod - radiantcore/selection/textool/FaceNode.cpp	Diff File
	mod - radiantcore/selection/textool/Node.cpp	Diff File
	mod - radiantcore/selection/textool/Node.h	Diff File
	mod - radiantcore/selection/textool/PatchNode.cpp	Diff File
textool c9846f72 27.09.2021 04:35 greebo Details Diff	0005731: Adjust the grid-painting routines	Affected Issues 0005731
	mod - include/itexturetoolcolours.h	Diff File
	mod - radiant/textool/TexTool.cpp	Diff File
	mod - radiantcore/selection/textool/ColourSchemeManager.cpp	Diff File
textool ab075a98 27.09.2021 04:17 greebo Details Diff	0005731: Start setting up colour schemes for the texture tool. Since this is supposed to be switched on a per-texture basis, I won't be tying this to the regular colour schemes used for the rest of the views.	Affected Issues 0005731
	add - include/itexturetoolcolours.h	Diff File
	mod - radiant/textool/TexTool.cpp	Diff File
	mod - radiantcore/CMakeLists.txt	Diff File
	add - radiantcore/selection/textool/ColourSchemeManager.cpp	Diff File
	mod - tools/msvc/DarkRadiantCore.vcxproj	Diff File
	mod - tools/msvc/DarkRadiantCore.vcxproj.filters	Diff File
	mod - tools/msvc/include.vcxproj	Diff File
textool 09d43a7a 27.09.2021 03:43 greebo Details Diff	0005732: Add unit test covering GridSnapRequest.	Affected Issues 0005732
	mod - test/Grid.cpp	Diff File
textool d1bc3319 27.09.2021 03:38 greebo Details Diff	0005732: Introduce GridSnapRequest message type which can be intercepted by the Texture Tool window.	Affected Issues 0005732
	mod - include/imessagebus.h	Diff File
	add - libs/messages/GridSnapRequest.h	Diff File
	mod - radiant/textool/TexTool.cpp	Diff File
	mod - radiant/textool/TexTool.h	Diff File
	mod - radiantcore/selection/algorithm/General.cpp	Diff File
	mod - tools/msvc/libs.vcxproj	Diff File
	mod - tools/msvc/libs.vcxproj.filters	Diff File
master 1173f2ab 26.09.2021 19:57 Matthew Mott Details Diff	ParticleNode no longer uses Matrix4::tColRef() Replace reference usages with direct assignment to the tx/y/z/w() matrix components.
	mod - radiantcore/particles/ParticleNode.cpp	Diff File
master 107673a1 26.09.2021 19:38 Matthew Mott Details Diff	Const Matrix4 column accessors no longer use reinterpret_cast Remove four instances of reinterpret_cast by constructing the return vector from a suitable Eigen method, in particular col(i) which returns the i'th column of a matrix, followed by head(n) which returns the first n elements.
	mod - libs/math/Matrix4.h	Diff File
master be2a97a3 26.09.2021 19:22 Matthew Mott Details Diff	Separate const and modifying Matrix4 column accessors Distinguish the methods which return a modifiable reference to columns by appending 'Ref' to the method name, i.e. xCol3Ref(), tColRef() etc. Calling code is updated to use these versions where a reference is required, either because it is assigned to as an lvalue or returned by const reference to a higher-level function. The remaining xCol3(), yCol3() etc methods now return by value. Changing a method from returning a reference to returning a value is potentially dangerous, because any calling code which continues to treat the returned value as if it were a reference (e.g. assigning to it) will do the wrong thing, and neither G++ nor CLang seem to be able to warn about this. Hopefully the combination of manual searching along with unit tests has ensured that there are no remaining uses of xCol3() which should be xCol3Ref().
	mod - libs/Transformable.h	Diff File
	mod - libs/math/Matrix4.h	Diff File
	mod - libs/pivot.h	Diff File
	mod - radiantcore/brush/TextureProjection.cpp	Diff File
	mod - radiantcore/particles/ParticleNode.cpp	Diff File
	mod - radiantcore/selection/ManipulationPivot.cpp	Diff File
	mod - radiantcore/selection/manipulators/RotateManipulator.cpp	Diff File
	mod - test/math/Matrix4.cpp	Diff File
textool 1da7e815 26.09.2021 19:15 greebo Details Diff	0005746: Remove unneeded field from TexTool class	Affected Issues 0005746
	mod - radiant/textool/TexTool.cpp	Diff File
	mod - radiant/textool/TexTool.h	Diff File

Changesets: DarkRadiant