Changesets: DarkRadiant

favourites feb0af63

2021-01-03 03:45:35

greebo

Details Diff
0005127: Set the correct decl::Type on the existing ResourceTreeView clients Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/uimanager/SoundChooser.cpp Diff File

favourites 1ca3d948

2021-01-03 03:42:08

greebo

Details Diff
0005127: Add methods to enable or disable favourite management features Affected Issues
0005127
mod - include/idecltypes.h Diff File
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File

favourites 046963be

2021-01-02 18:51:05

greebo

Details Diff
0005127: Migrate SoundChooser popup menu code Affected Issues
0005127
mod - radiant/uimanager/SoundChooser.cpp Diff File
mod - radiant/uimanager/SoundChooser.h Diff File

favourites 742890ef

2021-01-02 18:50:30

greebo

Details Diff
0005127: Add option to prepend custom menu items without having to derive from ResourceTreeView right away. Affected Issues
0005127
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File

favourites 07ee110c

2021-01-02 18:34:53

greebo

Details Diff
0005127: Migrate SoundChooser to use the ResourceTreeView classes Affected Issues
0005127
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - radiant/uimanager/SoundChooser.cpp Diff File
mod - radiant/uimanager/SoundChooser.h Diff File

favourites ebc5c979

2021-01-02 18:08:27

greebo

Details Diff
0005127: Harmonise the method first letter casing in the wxutil classes. When using types deriving from wxWidgets the mixed case is looking weird. Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowser.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File

favourites dbb8f971

2021-01-02 17:33:40

greebo

Details Diff
0005127: More streamlining with regards to TreeModel::PopulationFinishedEvent handling - let this always point to the ResourceTreeView since, move the event handler argument from the Populator constructors to a setter.
Handle item selection after population right in ResourceTreeView.
Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
mod - libs/wxutil/dataview/IResourceTreePopulator.h Diff File
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File
mod - libs/wxutil/dataview/ThreadedResourceTreePopulator.cpp Diff File
mod - libs/wxutil/dataview/ThreadedResourceTreePopulator.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File

favourites 70c696b7

2021-01-02 09:47:25

greebo

Details Diff
0005127: Adjustments to ThreadedEntityClassLoader Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File

favourites e329126f

2021-01-02 09:44:53

greebo

Details Diff
0005127: Move implementation to .cpp file. Affected Issues
0005127
mod - libs/wxutil/CMakeLists.txt Diff File
mod - libs/wxutil/dataview/IResourceTreePopulator.h Diff File
add - libs/wxutil/dataview/ThreadedResourceTreePopulator.cpp Diff File
mod - libs/wxutil/dataview/ThreadedResourceTreePopulator.h Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

favourites 06b3bb82

2021-01-02 09:37:31

greebo

Details Diff
0005127: It's easier to break an outer loop with an exception, use this in the MediaBrowserTreeView populator. Affected Issues
0005127
mod - libs/wxutil/dataview/ThreadedResourceTreePopulator.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File

favourites b13ba221

2021-01-02 09:18:39

greebo

Details Diff
0005127: Fix crashes when destroying Populator objects deriving from ThreadedResourceTreePopulator and introducing their own members.
Due to C++ dtor execution order threads will crash when the base class ThreadedResourceTreePopulator calls Delete().
The 100% solution would be to disallow subclassing from wxThread, but I'd like to keep the abstraction and the code re-use - therefore deriving classes must invoke EnsureStopped in their destructors. If they fail to do so, there's another safety measure in ResourceTreeView to call EnsureStopped before releasing the instance, to give classes a chance to clean up while the hierarchy is still intact.
Affected Issues
0005127
mod - libs/wxutil/dataview/IResourceTreePopulator.h Diff File
mod - libs/wxutil/dataview/ResourceTreeView.cpp Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File
mod - libs/wxutil/dataview/ThreadedResourceTreePopulator.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File

favourites 3a7b0130

2021-01-02 09:11:15

greebo

Details Diff
0005127: Fix a crash during shutdown due to _topLevelWindow pointing to a freed resource Affected Issues
0005127
mod - radiant/ui/mainframe/MainFrame.cpp Diff File

favourites b75f700c

2021-01-02 07:36:37

greebo

Details Diff
0005127: Remove a bit of unneeded code Affected Issues
0005127
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

favourites 44d25016

2021-01-02 06:41:32

greebo

Details Diff
0005127: Migrate ThreadedEntityClassLoader to derive from ThreadedResourceTreePopulator, to remove all the code dealing with wxThread. Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
mod - libs/wxutil/dataview/ThreadedResourceTreePopulator.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File

favourites a8498d4c

2021-01-02 06:01:48

greebo

Details Diff
0005127: Another abstraction to allow for non-threaded populator implementations. The ResourceTreeView is planned to work with the IResourceTreePopulator only. Affected Issues
0005127
add - libs/wxutil/dataview/IResourceTreePopulator.h Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

favourites 4b479e65

2021-01-02 04:47:04

greebo

Details Diff
0005127: Introduce base class for the threaded population helper. Hide the wxThread inheritance from client code. Affected Issues
0005127
add - libs/wxutil/dataview/ResourceTreePopulator.h Diff File
mod - libs/wxutil/dataview/ResourceTreeView.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

favourites 50f4751a

2021-01-02 03:20:24

greebo

Details Diff
0005127: Group some wxutil tree view classes in the wxutil/dataview/ folder Affected Issues
0005127
mod - libs/wxutil/CMakeLists.txt Diff File
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
mod - libs/wxutil/fsview/FileSystemView.h Diff File
mod - libs/wxutil/fsview/Populator.h Diff File
mod - plugins/dm.conversation/CommandEditor.h Diff File
mod - plugins/dm.conversation/ConversationDialog.cpp Diff File
mod - plugins/dm.conversation/ConversationDialog.h Diff File
mod - plugins/dm.conversation/ConversationEditor.h Diff File
mod - plugins/dm.conversation/ConversationEntity.h Diff File
mod - plugins/dm.difficulty/DifficultyEditor.cpp Diff File
mod - plugins/dm.difficulty/DifficultySettings.h Diff File
mod - plugins/dm.editing/AIHeadChooserDialog.h Diff File
mod - plugins/dm.editing/AIVocalSetChooserDialog.h Diff File
mod - plugins/dm.editing/MissionInfoEditDialog.cpp Diff File
mod - plugins/dm.editing/MissionInfoEditDialog.h Diff File
mod - plugins/dm.gui/GuiSelector.cpp Diff File
mod - plugins/dm.gui/GuiSelector.h Diff File
mod - plugins/dm.gui/ReadablePopulator.h Diff File
mod - plugins/dm.gui/ReadableReloader.h Diff File
mod - plugins/dm.gui/XDataSelector.h Diff File
mod - plugins/dm.gui/XdFileChooserDialog.h Diff File
mod - plugins/dm.objectives/ComponentsDialog.h Diff File
mod - plugins/dm.objectives/ObjectiveConditionsDialog.h Diff File
mod - plugins/dm.objectives/ObjectiveEntity.h Diff File
mod - plugins/dm.objectives/ObjectiveEntityFinder.h Diff File
mod - plugins/dm.objectives/ObjectivesEditor.h Diff File
mod - plugins/dm.stimresponse/ClassEditor.h Diff File
mod - plugins/dm.stimresponse/CustomStimEditor.h Diff File
mod - plugins/dm.stimresponse/EffectEditor.cpp Diff File
mod - plugins/dm.stimresponse/ResponseEditor.cpp Diff File
mod - plugins/dm.stimresponse/ResponseEditor.h Diff File
mod - plugins/dm.stimresponse/SREntity.h Diff File
mod - plugins/dm.stimresponse/StimResponse.h Diff File
mod - plugins/dm.stimresponse/StimTypes.cpp Diff File
mod - plugins/dm.stimresponse/StimTypes.h Diff File
mod - plugins/dm.stimresponse/precompiled.h Diff File
mod - radiant/eventmanager/GlobalKeyEventFilter.cpp Diff File
mod - radiant/ui/commandlist/CommandList.h Diff File
mod - radiant/ui/commandlist/CommandListPopulator.h Diff File
mod - radiant/ui/common/EntityChooser.h Diff File
mod - radiant/ui/common/ShaderSelector.cpp Diff File
mod - radiant/ui/common/ShaderSelector.h Diff File
mod - radiant/ui/common/TexturePreviewCombo.cpp Diff File
mod - radiant/ui/eclasstree/EClassTree.h Diff File
mod - radiant/ui/eclasstree/EClassTreeBuilder.cpp Diff File
mod - radiant/ui/eclasstree/EClassTreeBuilder.h Diff File
mod - radiant/ui/einspector/AddPropertyDialog.cpp Diff File
mod - radiant/ui/einspector/AddPropertyDialog.h Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File
mod - radiant/ui/einspector/SkinChooser.cpp Diff File
mod - radiant/ui/einspector/SkinChooser.h Diff File
mod - radiant/ui/entitylist/EntityList.cpp Diff File
mod - radiant/ui/entitylist/GraphTreeModel.h Diff File
mod - radiant/ui/entitylist/GraphTreeNode.h Diff File
mod - radiant/ui/filters/editor/FilterDialog.h Diff File
mod - radiant/ui/mapinfo/EntityInfoTab.h Diff File
mod - radiant/ui/mapinfo/LayerInfoTab.h Diff File
mod - radiant/ui/mapinfo/ModelInfoTab.h Diff File
mod - radiant/ui/mapinfo/ShaderInfoTab.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File
mod - radiant/ui/modelselector/MaterialsList.h Diff File
mod - radiant/ui/modelselector/ModelDataInserter.h Diff File
mod - radiant/ui/modelselector/ModelPopulator.h Diff File
mod - radiant/ui/modelselector/ModelSelector.h Diff File
mod - radiant/ui/mousetool/ToolMappingDialog.cpp Diff File
mod - radiant/ui/mousetool/ToolMappingDialog.h Diff File
mod - radiant/ui/particles/ParticleEditor.h Diff File
mod - radiant/ui/particles/ParticlesChooser.cpp Diff File
mod - radiant/ui/particles/ParticlesChooser.h Diff File
mod - radiant/uimanager/SoundChooser.cpp Diff File
mod - radiant/uimanager/SoundChooser.h Diff File
mod - radiant/uimanager/SoundShaderPreview.h Diff File
mod - radiant/uimanager/animationpreview/MD5AnimationViewer.h Diff File
mod - radiant/uimanager/colourscheme/ColourSchemeEditor.cpp Diff File
mod - radiant/uimanager/colourscheme/ColourSchemeEditor.h Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

favourites 1c447548

2021-01-02 03:00:57

greebo

Details Diff
0005127: Minor refactoring Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/ResourceTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File

favourites e643aa60

2021-01-01 16:34:32

greebo

Details Diff
0005127: Move more responsibilities to the ResourceTreeView class. It owns a reference to the TreeModel it's using, and it takes care of setting up the TreeModelFilter according to the selected view mode (show all vs. favourites only). As a benefit, the MediaBrowserTreeView specialisation is becoming slimmer, and the EntityClassChooser can re-use more code. Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
mod - libs/wxutil/ResourceTreeView.cpp Diff File
mod - libs/wxutil/ResourceTreeView.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowser.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowser.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File

favourites c2391a23

2020-12-30 16:17:41

greebo

Details Diff
0005127: Split MediaBrowser's treeview functionality into two classes: ResourceTreeView > MediaBrowserTreeView, with the ResourceTreeView managing the tree along with the context menu and favourite handling. The rest of the MediaBrowser tree functionality has been moved to the MediaBrowserTree, like populating, selection changing, etc.
The idea is to re-use the ResourceTreeView as common base view for EntityClassChooser, SoundSelector, and the other views that display "resources" that support favourites. The EntityClassChooser is WIP in this commit.
Affected Issues
0005127
mod - libs/wxutil/CMakeLists.txt Diff File
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
add - libs/wxutil/ResourceTreeView.cpp Diff File
add - libs/wxutil/ResourceTreeView.h Diff File
mod - radiant/CMakeLists.txt Diff File
mod - radiant/ui/mediabrowser/MediaBrowser.cpp Diff File
mod - radiant/ui/mediabrowser/MediaBrowser.h Diff File
add - radiant/ui/mediabrowser/MediaBrowserTreeView.cpp Diff File
add - radiant/ui/mediabrowser/MediaBrowserTreeView.h Diff File
mod - tools/msvc/DarkRadiant.vcxproj Diff File
mod - tools/msvc/DarkRadiant.vcxproj.filters Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

master 7127ccbb

2020-12-28 18:19:47

jonri

Details Diff
0005454: Improve resizing behavior of script dialogs Affected Issues
0005454
mod - libs/wxutil/dialog/Dialog.cpp Diff File

master 6b10c158

2020-12-28 17:12:39

greebo

Details Diff
0005469: Fix crash due to pybind11::dict being initialised too early. Affected Issues
0005469
mod - plugins/script/PythonModule.cpp Diff File
mod - plugins/script/PythonModule.h Diff File

favourites 2864d595

2020-12-27 18:15:38

greebo

Details Diff
0005127: Move common tree view item formatting code to wxutil.
Remove wxutil namespace specifies from EntityClassChooser, it's part of wxutil
Affected Issues
0005127
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
add - libs/wxutil/TreeViewItemStyle.h Diff File
mod - radiant/ui/mediabrowser/MediaBrowser.cpp Diff File
mod - tools/msvc/wxutillib.vcxproj Diff File
mod - tools/msvc/wxutillib.vcxproj.filters Diff File

favourites bd2a1b4e

2020-12-27 17:22:54

greebo

Details Diff
0005127: Prepare eclass tree to highlight favourites Affected Issues
0005127
mod - include/idecltypes.h Diff File
mod - libs/wxutil/EntityClassChooser.cpp Diff File
mod - libs/wxutil/EntityClassChooser.h Diff File
mod - radiantcore/decl/FavouritesManager.cpp Diff File

favourites 83546cd2

2020-12-27 16:51:16

greebo

Details Diff
0005127: Add unit test covering favourites persistence to user.xml Affected Issues
0005127
mod - test/Favourites.cpp Diff File
 First  Prev  1 2 3 4 5 6 7 ... 10 ... 20 ... 30 ... 40 ... 50 ... 60 ... 70 ... 80 ... 90 ... 95 96 97  Next  Last