Changesets: DarkRadiant

entityinspector db329035

21.10.2021 15:04

greebo


Details Diff
0005613: Brush (worldspawn only) selection unit tests Affected Issues
0005613
mod - test/EntityInspector.cpp Diff File
mod - test/resources/tdm/maps/entityinspector.map Diff File

entityinspector ac7464cf

21.10.2021 14:51

greebo


Details Diff
0005613: Intercept a crash when selecting worldspawn brushes Affected Issues
0005613
mod - libs/selection/CollectiveSpawnargs.h Diff File
mod - libs/selection/EntitySelection.h Diff File

master 5ceba5a3

20.10.2021 20:05

Matthew Mott


Details Diff
Add test for projected light not at origin

Confirm that the light's own origin transforms to [0, 0, 0, 0], and that the
target vector is relative to the light origin.
mod - test/Renderer.cpp Diff File

master becdab18

20.10.2021 19:50

Matthew Mott


Details Diff
Add further unit tests for projected light

These are just capturing the current behaviour, not necessarily ideal or
correct behaviour (although there does not appear anything obviously wrong with
the test transforms so far).
mod - test/HeadlessOpenGLContext.h Diff File
mod - test/Renderer.cpp Diff File

entityinspector e8c2bb76

20.10.2021 17:59

greebo


Details Diff
0005613: Disable the tree view if we're in merge mode and have more than one entity selected Affected Issues
0005613
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

entityinspector 56190d44

18.10.2021 18:14

greebo


Details Diff
0005613: Fix keys not re-appearing after de-selecting the one entity that was preventing the keys to show up Affected Issues
0005613
mod - libs/selection/CollectiveSpawnargs.h Diff File

entityinspector b7cba693

18.10.2021 17:39

greebo


Details Diff
0005613: One more test case covering a display problem when de-selecting entities Affected Issues
0005613
mod - test/EntityInspector.cpp Diff File

entityinspector 0a96b48c

17.10.2021 18:23

greebo


Details Diff
0005613: Help text is now handled in the idle loop, no need to do this detailed eclass queries for each and every key during scene selection changes Affected Issues
0005613
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

entityinspector fb0ed634

17.10.2021 17:31

greebo


Details Diff
0005613: Even if a scene::Node got deleted, we still need to notify the spawnarg collection about this. Add corresponding unit test. Affected Issues
0005613
mod - libs/selection/EntitySelection.h Diff File
mod - test/EntityInspector.cpp Diff File

entityinspector 464ec1fc

17.10.2021 17:30

greebo


Details Diff
0005613: Inherited properties can be displayed if there's a single classname shared by all selected entities. Affected Issues
0005613
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

entityinspector efcf6c7d

17.10.2021 15:36

greebo


Details Diff
0005613: EntityInspector no longer needs to implement Entity::Observer Affected Issues
0005613
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

entityinspector b9d53176

17.10.2021 15:34

greebo


Details Diff
0005613: Display the ambiguous values in italics (if supported) Affected Issues
0005613
mod - libs/wxutil/dataview/TreeViewItemStyle.h Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File

entityinspector f349ecc5

17.10.2021 15:14

greebo


Details Diff
0005613: Extend EntityInspector tests to prove that undo/redo is notifying the CollectiveSpawnargs values Affected Issues
0005613
mod - test/Entity.cpp Diff File
mod - test/EntityInspector.cpp Diff File
add - test/algorithm/Entity.h Diff File
mod - tools/msvc/Tests/Tests.vcxproj Diff File
mod - tools/msvc/Tests/Tests.vcxproj.filters Diff File

entityinspector b268207e

17.10.2021 14:48

greebo


Details Diff
0005613: Add an additional callback line between SpawnArgs and the owned KeyValue instance - once the instance gets a new value assigned (in whatever way) the SpawnArgs instance can trigger its notifyChange() method, which didn't happen before. Affected Issues
0005613
mod - radiantcore/entity/KeyValue.cpp Diff File
mod - radiantcore/entity/KeyValue.h Diff File
mod - radiantcore/entity/SpawnArgs.cpp Diff File
mod - test/Entity.cpp Diff File

entityinspector e610aa45

17.10.2021 14:08

greebo


Details Diff
0005613: Add first failing test checking the fact that changing a single key in an undoable operation will not trigger the Entity::Observer::onKeyChanged method as it should. This is the reason the Entity Inspector doesn't display the updated values after undo/redo. Affected Issues
0005613
mod - test/Entity.cpp Diff File

entityinspector af12115a

17.10.2021 07:31

greebo


Details Diff
0005613: Add test covering KeyObservers being notified on Undo/Redo of a single key value change Affected Issues
0005613
mod - test/Entity.cpp Diff File

entityinspector 27109f78

17.10.2021 07:25

greebo


Details Diff
0005613: Check KeyObserver persistence after undoing an operation. Make KeyValue sealed and noncopyable. Affected Issues
0005613
mod - radiantcore/entity/KeyValue.h Diff File
mod - test/Entity.cpp Diff File

entityinspector 0d15e808

17.10.2021 06:16

greebo


Details Diff
0005613: Long integration test covering the Entity::Observer behaviour on undo/redo. It already reveals odd behaviour when EntityKeyValue instances are directly changed in combination with key values being added or removed to a SpawnArgs collection during the same operation. Affected Issues
0005613
mod - test/Entity.cpp Diff File

entityinspector 66bd95d4

17.10.2021 05:11

greebo


Details Diff
0005613: Tests covering the EntityKeyValue observer behaviour on regular change and removal. Affected Issues
0005613
mod - test/Entity.cpp Diff File

entityinspector 2effcb45

17.10.2021 04:33

greebo


Details Diff
0005613: More test cases covering key value addition, removal and change Affected Issues
0005613
mod - test/Entity.cpp Diff File

entityinspector 6f1e2918

17.10.2021 04:21

greebo


Details Diff
0005613: Start creating unit tests covering the Entity::Observer behaviour Affected Issues
0005613
mod - test/Entity.cpp Diff File

entityinspector f060e712

17.10.2021 04:05

greebo


Details Diff
0005613: Entity KeyValue objects now hold a reference to the owning SpawnArgs instance. This is a preparation to notify the owner on Undo/Redo when just a single key value is being reverted to a previous state - right now the SpawnArgs owner doesn't get notified. Affected Issues
0005613
mod - radiantcore/entity/KeyValue.cpp Diff File
mod - radiantcore/entity/KeyValue.h Diff File
mod - radiantcore/entity/SpawnArgs.cpp Diff File

entityinspector 0429c9cc

17.10.2021 03:49

greebo


Details Diff
0005613: Module setup is not finished by the time the PropertyEditorFactory is registering the built-in types, so the sound module may or may not be available at that time. Disable the sound editor if the module is not present in the editor's constructor instead. Affected Issues
0005613
mod - radiant/ui/einspector/PropertyEditorFactory.cpp Diff File
mod - radiant/ui/einspector/PropertyEditorFactory.h Diff File
mod - radiant/ui/einspector/SoundPropertyEditor.cpp Diff File
mod - test/resources/tdm/maps/entityinspector.map Diff File

entityinspector a712aa77

17.10.2021 03:43

greebo


Details Diff
0005613: PropertyEditorFactory is no longer a static class and is now owned by the EntityInspector module. Affected Issues
0005613
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File
mod - radiant/ui/einspector/PropertyEditorFactory.cpp Diff File
mod - radiant/ui/einspector/PropertyEditorFactory.h Diff File

entityinspector e275e9dd

16.10.2021 18:23

greebo


Details Diff
0005613: Reorganise the whole PropertyEditor framework. Change virtual constructors to factory function object, to be able to use references in the property editor instances. Separate the IPropertyEditorDialog implementations from the editors. Affected Issues
0005613
mod - include/ientity.h Diff File
mod - include/ui/ientityinspector.h Diff File
mod - libs/selection/CollectiveSpawnargs.h Diff File
mod - libs/selection/EntitySelection.h Diff File
mod - plugins/dm.editing/AIEditingPanel.cpp Diff File
mod - plugins/dm.editing/AIHeadPropertyEditor.cpp Diff File
mod - plugins/dm.editing/AIHeadPropertyEditor.h Diff File
mod - plugins/dm.editing/AIVocalSetPropertyEditor.cpp Diff File
mod - plugins/dm.editing/AIVocalSetPropertyEditor.h Diff File
mod - plugins/dm.editing/plugin.cpp Diff File
mod - radiant/ui/einspector/AnglePropertyEditor.cpp Diff File
mod - radiant/ui/einspector/AnglePropertyEditor.h Diff File
mod - radiant/ui/einspector/BooleanPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/BooleanPropertyEditor.h Diff File
mod - radiant/ui/einspector/ClassnamePropertyEditor.cpp Diff File
mod - radiant/ui/einspector/ClassnamePropertyEditor.h Diff File
mod - radiant/ui/einspector/ColourPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/ColourPropertyEditor.h Diff File
mod - radiant/ui/einspector/EntityInspector.cpp Diff File
mod - radiant/ui/einspector/EntityInspector.h Diff File
mod - radiant/ui/einspector/EntityPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/EntityPropertyEditor.h Diff File
mod - radiant/ui/einspector/FloatPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/FloatPropertyEditor.h Diff File
mod - radiant/ui/einspector/ModelPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/ModelPropertyEditor.h Diff File
mod - radiant/ui/einspector/PropertyEditor.cpp Diff File
mod - radiant/ui/einspector/PropertyEditor.h Diff File
mod - radiant/ui/einspector/PropertyEditorFactory.cpp Diff File
mod - radiant/ui/einspector/PropertyEditorFactory.h Diff File
mod - radiant/ui/einspector/SkinPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/SkinPropertyEditor.h Diff File
mod - radiant/ui/einspector/SoundPropertyEditor.cpp Diff File
mod - radiant/ui/einspector/SoundPropertyEditor.h Diff File
mod - radiant/ui/einspector/TexturePropertyEditor.cpp Diff File
mod - radiant/ui/einspector/TexturePropertyEditor.h Diff File
mod - radiant/ui/einspector/Vector3PropertyEditor.cpp Diff File
mod - radiant/ui/einspector/Vector3PropertyEditor.h Diff File
 First  Prev  1 2 3 ... 30 ... 60 ... 89 90 91 92 93 94 95 ... 120 ... 150 ... 180 ... 210 ... 240 ... 261 262 263  Next  Last