View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001059 | The Dark Mod | Sound | public | 29.08.2008 09:09 | 14.09.2017 03:35 |
Reporter | Ishtvan | Assigned To | Ishtvan | ||
Priority | high | Severity | crash | Reproducibility | always |
Status | closed | Resolution | unable to reproduce | ||
Product Version | SVN | ||||
Summary | 0001059: Melee Strike Near AI Can Lead to Soundprop Crash | ||||
Description | When PropSoundS is called from an entity (in this case the melee weapon), SoundProp uses the origin of that entity as the origin of the sound (which is usually close enough). In that map, when you swing and hit the door handle, the origin of the melee weapon can end up outside the map at that instant. This means gameLocal->PointInArea returns -1, and this makes soundprop crash because it uses that as an index into an array. So I think a few things need to be fixed: 1. idEntity::PropSoundDirect and ::PropSoundS need to be able to take an origin argument (in this case it should be the collision point, not the origin of the melee weapon. 2. Soundprop needs better error handling for when the origin it's given is outside the map. If PointInArea returns -1, maybe check if the entity has a bindmaster, and use the origin of the bindmaster instead. Failing that, just abort the propagation gracefully if the sound originates outside the map. | ||||
Tags | No tags attached. | ||||
Soundprop will no longer crash, it just won't propagate the sound. We still have to relay sound origin coordinates other than the origin of the entity (in this case the collision contact coordinates). | |
No recent reports of this. Origin modifier code now exists in idEntity::PropSoundS This issue dates to Doom 3 closed source. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
29.08.2008 09:09 | Ishtvan | New Issue | |
29.08.2008 09:10 | Ishtvan | Status | new => assigned |
29.08.2008 09:10 | Ishtvan | Assigned To | => Ishtvan |
29.08.2008 09:10 | Ishtvan | Summary | Mele Strike Near AI Can Lead to Soundprop Crash => Melee Strike Near AI Can Lead to Soundprop Crash |
29.08.2008 09:10 | Ishtvan | Description Updated | |
30.08.2008 20:47 | Ishtvan | Note Added: 0001532 | |
14.09.2017 03:33 | nbohr1more | Relationship added | related to 0003660 |
14.09.2017 03:35 | nbohr1more | Note Added: 0009225 | |
14.09.2017 03:35 | nbohr1more | Status | assigned => closed |
14.09.2017 03:35 | nbohr1more | Resolution | open => unable to reproduce |