View Issue Details

IDProjectCategoryView StatusLast Update
0002250DarkRadiantDesign/Codingpublic24.09.2011 08:20
Reporteruser81Assigned Togreebo  
PrioritynormalSeveritynormalReproducibilityalways
Status closedResolutionfixed 
PlatformQx9650/HD5870OSWindows 7 x86 
Product Version1.3.2 
Target Version1.6.0Fixed in Version1.6.0 
Summary0002250: DR 1.3.1-1.4.0pre: Single pixel lines showing where joins in brush work.
DescriptionI can now see single pixel wide gap lines between all patch and brushwork at the point where they meet, this is annoying because before it would indicate if there was a minute missalignment - this is forcing me to treble check everything which is a right pain in the arse.
TagsNo tags attached.

Activities

greebo

greebo

10.06.2010 16:06

administrator   ~0003051

Is there a testmap available?

user81

11.06.2010 12:06

  ~0003058

ive attached a copy of very basic & cut down version of my cathedral map.

As I had a clean cut down map I tried something that didn't occur to me before and that was to export the whole assy as a prefab and the import into a blank map in DR131 and sure enough all the lines disappeared.

user81

11.06.2010 12:32

  ~0003062

I tried the prefab export/import on my full cathedral map and it didnt work, so I have attached my full map for you to have a play with. In the mean time I`ll still keep playing with this to find why it worked on the cut-down version and not the full version.

user81

11.06.2010 13:01

  ~0003063

Last edited: 21.06.2010 00:07

View 4 revisions

[update]

It seems the issue is directly related to that map and my other map, the only thing i can think of is they were first created in DR121 and something is being carried over?

I completely nuked DR and removed all releated folders on the c drive etc, then reinstalled. Then created a fresh map, then a box, then cutted and no lines. I loaded my map and then created a hollow box in the void and then cut the box up and sure enough the lines are back.

Grrrrr...

ungoliant

ungoliant

18.06.2010 14:47

reporter   ~0003072

I have this exact same problem with my map since 1.3.1, was going to report it. very annoying bug.

user81

21.06.2010 00:06

  ~0003084

This is still prevalent in 1.3.2.

user81

18.07.2010 17:14

  ~0003128

This is still prevalent in 1.4.0pre
greebo

greebo

18.07.2010 17:42

administrator   ~0003133

Is the issue also present in versions before 1.3.1?

user81

19.07.2010 21:23

  ~0003138

The only version I tested/used prior to 1.3.1 was 1.2.1 and that didn't have the issue.
grayman

grayman

06.10.2010 13:29

administrator   ~0003225

If at all possible, when this is fixed, could it be made toggle-able?

For example, if I have a plaster wall and split it at intervals to place wood columns, I can see exactly where I need to paint the columns' wood texture. Otherwise it's a hunt-and-peck to find the column brushes.

If there was a toggle, folks who like (and use) the lines can leave them as is, and those who don't like them can turn them off.

If a toggle is a royal pain to implement, then I'd be fine with going back to the "no lines" version.
greebo

greebo

20.02.2011 06:53

administrator   ~0003615

After performing a binary revision search I can say that the exact SVN revision this has been introduced is 5585.
greebo

greebo

20.02.2011 18:13

administrator  

gap_line_bug.map (7,019 bytes)   
Version 2
// entity 0
{
"classname" "worldspawn"
"editor_dr_stim_1000" "make_green_torch"
"editor_dr_stim_1001" "make_default_torch"
"origin" "0 0 0"
"editor_drLastCameraPos" "1529.41 2526.44 -757.999"
"editor_drLastCameraAngle" "-10.8 357.6 0"
"editor_drMapPos1" "1738.55 1171.14 -520.531"
"editor_drMapAngle1" "14.7001 87.8977 0"
"editor_drMapPos2" "414.798 255.441 -264.933"
"editor_drMapAngle2" "2.10002 84.5976 0"
"editor_drMapPos3" "-749.97 -1606.21 -470.066"
"editor_drMapAngle3" "-3.29998 6.59757 0"
"editor_drMapPos4" "1014.05 -953.679 -556.857"
"editor_drMapAngle4" "-10.2 355.498 0"
"editor_drMapPos5" "987.599 3513.79 -319.877"
"editor_drMapAngle5" "-61.1999 172.198 0"
"editor_drMapPos6" "-1032.5 -2840 739.5"
"editor_drMapAngle6" "-77.0999 175.798 0"
"editor_drMapPos7" "952.822 285.005 1366.04"
"editor_drMapAngle7" "-74.8 149.373 0"
"editor_drMapPos8" "976 424 320"
"editor_drMapAngle8" "-3 15.3467 0"
"editor_drMapPos9" "409.146 547.464 392.83"
"editor_drMapAngle9" "-16.8 284.947 0"
// primitive 0
{
brushDef3
{
( 0 0 1 777 ) ( ( 0 0.1428570002 10.929359436 ) ( -0.09960939739999999 0 59.313873291 ) ) "textures/common/caulk" 0 0 0
( 0 1 0 -2526.9936523438 ) ( ( 0 0.0180995464 241.9366455078 ) ( -0.0208333321 0 220.1666717529 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( 1 0 0 -1768 ) ( ( 0 0.0180995464 497.9276123047 ) ( -0.08333333580000001 0 82.5828094482 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 0 0 -1 -888 ) ( ( 0 0.1428570002 61.0712394714 ) ( -0.09960939739999999 0 59.313873291 ) ) "textures/common/caulk" 0 0 0
( 0 -1 0 2514.9936523438 ) ( ( 0 0.0180178992 241.9906005859 ) ( -0.0035574799 0 6.3019390106 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( -1 0 0 1720 ) ( ( 0 0.0180995464 497.9276123047 ) ( -0.08333333580000001 0 46.4171867371 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
}
}
// primitive 1
{
brushDef3
{
( 0 1 0 -2537.9968261719 ) ( ( 0.071428597 0 62.6072387695 ) ( 0 0.0664046034 55.4347991943 ) ) "textures/common/caulk" 0 0 0
( 0 -0.8426963091 0.5383892059 2537.7053222656 ) ( ( 0 0.0234083999 17.3696136475 ) ( -0.0035574799 0 6.3054966927 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( -1 0 0 1720 ) ( ( 0.0124039985 0.0198505372 16.7721252441 ) ( -0.08331918720000001 0.0520636216 5.9992465973 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 0 0 -1 -777 ) ( ( 0.4999809861 0 22.5505981445 ) ( 0 0.0142299002 25.2082996368 ) ) "textures/common/caulk" 0 0 0
( 0 0.8762159348 -0.4819187522 -2588.6457519531 ) ( ( 0 0.0353337005 18.3666610718 ) ( -0.0178570002 0 225.3480072021 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( 1 0 0 -1768 ) ( ( -0.0124039892 0.0198505428 16.7720966339 ) ( -0.08331918720000001 -0.0520637557 123.0008621216 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
}
}
// primitive 2
{
brushDef3
{
( 0 -1 0 2593.9968261719 ) ( ( 0.0714285001 0 5.3972511292 ) ( 0 0.0664070994 55.4330482483 ) ) "textures/common/caulk" 0 0 0
( 0 0.8426963091 0.5383892059 -1787.0078125 ) ( ( 0 0.0234079007 208.6923217773 ) ( -0.0178571995 0 20.3481197357 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 1 0 0 -1768 ) ( ( 0.0124033997 0.0198495984 465.1171569824 ) ( -0.0833115876 0.0520588569 49.5766906738 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 0 0 -1 -777 ) ( ( -0.500007987 0 28.517747879 ) ( 0 -0.0142299002 16.2292003632 ) ) "textures/common/caulk" 0 0 0
( 0 -0.8762159348 -0.4819187522 1908.0888671875 ) ( ( 0 0.0353328995 191.419128418 ) ( -0.0178571008 0 31.6515884399 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( -1 0 0 1720 ) ( ( -0.0124034071 0.019849591 465.1171569824 ) ( -0.0833115876 -0.0520588569 79.4233093262 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
}
}
// primitive 3
{
brushDef3
{
( 0 0 1 777 ) ( ( 0 0.1428570002 10.929359436 ) ( -0.09960939739999999 0 4.6770777702 ) ) "textures/common/caulk" 0 0 0
( 0 1 0 -2616.9936523438 ) ( ( 0 0.0180178992 241.9906005859 ) ( -0.0178571008 0 20.3661670685 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 1 0 0 -1768 ) ( ( 0 0.0180995464 497.9276123047 ) ( -0.08333333580000001 0 90.0828094482 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 0 0 -1 -888 ) ( ( 0 0.1428570002 61.0712394714 ) ( -0.09960939739999999 0 4.6770777702 ) ) "textures/common/caulk" 0 0 0
( 0 -1 0 2604.9936523438 ) ( ( 0 0.0180995464 241.9275970459 ) ( -0.020833334 0 36.8333320618 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( -1 0 0 1720 ) ( ( 0 0.0180995464 497.9276123047 ) ( -0.08333333580000001 0 38.9171867371 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
}
}
// primitive 4
{
brushDef3
{
( 0 0 1 741 ) ( ( 0.0151517 0 217.5900726318 ) ( 0 0.0178571008 225.3656616211 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( 0 1 0 -2593.9936523438 ) ( ( 0.071428597 0 62.5715255737 ) ( 0 0.0664061978 55.4335670471 ) ) "textures/common/caulk" 0 0 0
( 1 0 0 -1768 ) ( ( 0.0178571418 0 466.6786804199 ) ( 0 0.0625 81.6875 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
( 0 0 -1 -757 ) ( ( 0.0151517 0 217.5900726318 ) ( 0 0.0178571008 31.633731842 ) ) "textures/darkmod/stone/brick/tight_large_singleblock01" 0 0 0
( 0 -1 0 2537.9936523438 ) ( ( 0.0714277998 0 5.3982906342 ) ( 0 0.0664063022 55.4335632324 ) ) "textures/common/caulk" 0 0 0
( -1 0 0 1720 ) ( ( 0.0178571418 0 46.3213157654 ) ( 0 0.0625 81.6875 ) ) "textures/darkmod/stone/brick/single_grey_block01" 0 0 0
}
}
// primitive 5
{
patchDef3
{
"textures/decals/sdirt11"
( 5 7 5 5 0 0 0 )
(
( ( 1918 2377 -764 0 0 ) ( 2070 2334 -799 0 0.1666666716 ) ( 2235 2319 -955 0 0.3333333433 ) ( 2396 2310 -964 0 0.5 ) ( 2549 2329 -906 0 0.6666666865000001 ) ( 2729 2322 -890 0 0.8333333731 ) ( 2893 2316 -915 0 1 ) )
( ( 1893 2243 -670 0.25 0 ) ( 2059 2218 -779 0.25 0.1666666716 ) ( 2202 2237 -906 0.25 0.3333333433 ) ( 2346 2216 -949 0.25 0.5 ) ( 2566 2233 -917 0.25 0.6666666865000001 ) ( 2778 2208 -899 0.25 0.8333333731 ) ( 2876 2218 -932 0.25 1 ) )
( ( 1900 2150 -703 0.40625 0 ) ( 2044 2103 -715 0.40625 0.1666666716 ) ( 2231 2154 -882 0.40625 0.3333333433 ) ( 2346 2132 -936 0.40625 0.5 ) ( 2570 2143 -918 0.40625 0.6666666865000001 ) ( 2778 2139 -898 0.40625 0.8333333731 ) ( 2882 2121 -928 0.40625 1 ) )
( ( 1899 2040 -683 0.59375 0 ) ( 2070 2045 -706 0.59375 0.1666666716 ) ( 2258 2060 -845 0.59375 0.3333333433 ) ( 2367 2050 -896 0.59375 0.5 ) ( 2535 2049 -861 0.59375 0.6666666865000001 ) ( 2740 2003 -881 0.59375 0.8333333731 ) ( 2910 2003 -912 0.59375 1 ) )
( ( 1901 1940 -682 0.96875 0 ) ( 2092 1974 -683 0.96875 0.1666666716 ) ( 2220 1941 -815 0.96875 0.3333333433 ) ( 2415 1955 -873 0.96875 0.5 ) ( 2527 1958 -843 0.96875 0.6666666865000001 ) ( 2679 1944 -881 0.96875 0.8333333731 ) ( 2934 1941 -717 0.96875 1 ) )
)
}
}
}
gap_line_bug.map (7,019 bytes)   
greebo

greebo

20.02.2011 18:15

administrator   ~0003617

The attached map exhibits this issue and makes it clear that there is some sort of render state "corruption" going on. When the patch in the background is highlighted the gap line issue goes away, but when nothing is selected the gap lines (in caulk texture's colour) are clearly visible in between the brushes.
greebo

greebo

21.02.2011 07:23

administrator   ~0003619

Finally fixed. The openGL state was not initialised correctly when polygons with polygonOffset > 0 were rendered in the scene. GL_POLYGON_OFFSET_FILL needs to be disabled before starting to render.

user81

21.02.2011 10:02

  ~0003622

Sweet, thanks for sorting this Greebs..

Issue History

Date Modified Username Field Change
09.06.2010 11:01 user81 New Issue
10.06.2010 15:58 greebo Project The Dark Mod => DarkRadiant
10.06.2010 16:06 greebo Note Added: 0003051
10.06.2010 16:06 greebo Status new => feedback
11.06.2010 12:04 user81 File Added: gaplinetest.zip
11.06.2010 12:06 user81 Note Added: 0003058
11.06.2010 12:06 user81 Status feedback => new
11.06.2010 12:31 user81 File Added: cathfin.zip
11.06.2010 12:32 user81 Note Added: 0003062
11.06.2010 13:01 user81 Note Added: 0003063
11.06.2010 13:02 user81 Note Edited: 0003063 View Revisions
11.06.2010 13:03 user81 Note Edited: 0003063 View Revisions
18.06.2010 14:47 ungoliant Note Added: 0003072
20.06.2010 04:58 greebo Status new => acknowledged
21.06.2010 00:06 user81 Note Added: 0003084
21.06.2010 00:07 user81 Note Edited: 0003063 View Revisions
18.07.2010 17:14 user81 Note Added: 0003128
18.07.2010 17:20 user81 Category Mapping => Design/Coding
18.07.2010 17:20 user81 Product Version TDM 1.02 =>
18.07.2010 17:20 user81 Summary DR 1.3.1: Single pixel lines showing where joins in brush/patch work. => DR 1.3.1-1.4.0pre: Single pixel lines showing where joins in brush work.
18.07.2010 17:42 greebo Note Added: 0003133
19.07.2010 21:23 user81 Note Added: 0003138
06.10.2010 13:29 grayman Note Added: 0003225
20.02.2011 06:36 greebo Status acknowledged => confirmed
20.02.2011 06:53 greebo Note Added: 0003615
20.02.2011 18:13 greebo File Added: gap_line_bug.map
20.02.2011 18:13 greebo File Deleted: cathfin.zip
20.02.2011 18:13 greebo File Deleted: gaplinetest.zip
20.02.2011 18:15 greebo Note Added: 0003617
21.02.2011 07:21 greebo Assigned To => greebo
21.02.2011 07:21 greebo Status confirmed => assigned
21.02.2011 07:21 greebo Product Version => 1.3.2
21.02.2011 07:21 greebo Target Version => 1.6.0
21.02.2011 07:23 greebo Note Added: 0003619
21.02.2011 07:23 greebo Status assigned => resolved
21.02.2011 07:23 greebo Fixed in Version => 1.6.0
21.02.2011 07:23 greebo Resolution open => fixed
21.02.2011 07:27 greebo Priority high => normal
21.02.2011 10:02 user81 Note Added: 0003622
24.09.2011 08:20 greebo Status resolved => closed