 |
Aper from the bug that this does not show during savegame load, I also think this should be part of the TDM, not only because it then can be translated, but also because then not every mapper needs to muck around with copy&paste. A new GUI with a single variable for the mapper to turn this on/off should be made, and at that time we hopefully also can also fix that it shows during load. |
 |
the values contain an "else" statement, so it has something to do with this line: onNamedEvent OnRandomValueInitialised Even a value of 0 should show some text, yet none appears. My guess is that whatever creates the "onRandomValueInitialised" doesn't actually run when loading from a saved game. |
 |
In game/gamelocal.cpp there is the function idGameLocal::InitFromNewMap which implements the following lines idUserInterface* loadingGUI = uiManager->FindGui(va("guis/map/%s.gui", mapNameStr.c_str()), false, false, false); if (loadingGUI != NULL) { // Use our own randomizer, the gameLocal.random one is not yet initialised loadingGUI->SetStateFloat("random_value", static_cast<float>(rnd.Random())); loadingGUI->HandleNamedEvent("OnRandomValueInitialised"); } Neither loadgame nor initfromsavedgame does implement this lines (I gues it should go into the latter function, not sure). |
|
|
Is it possible to include some kind of "else" statement, so that if the event isn't run, some default comment is still posted? |
 |
Obs' suggestion works fine. The same code can be used to show the messages while saved gamnes are loading (paste the same code into idGameLocal::InitFromSaveGame just before the call to LoadMap). We can put them in a separate function and call it from both places. One problem: when the player reloads the currently loaded map, we don't want the text to be displayed because the player won't have time to read it. So we need to detect whether the same map is being reloaded. One more thing to check out: whether it's possible to have a default list of tips to be displayed which mappers won't have to configure manually. |
|
|
I wonder if it would be possible to just show the quick tips during a quick load. Those normally only show in the last five s condos before the game starts, so they are kept short by design. |
|
|
I'll find a way to do that. Re the idea of having a default set of tips and flavour text, could we do that simply by adding a file to the main TDM assets, that mappers can override if they wish? Or would mappers have to merge it somehow with their own GUI file? If the latter, I'll look for another way. |
|
|
The ideal option would be to have a default file of tips that mappers can opt into with some kind of flag, but that they can modify that file and include it in their pk4 if they want to customize the tips. |
|
|
I've moved the code that activates the tips and flavour text to the general LoadMap procedure, so it gets used by both save game loads and new games. I've also put in a check for quick loading so that it doesn't show them during a quick load. The way the GUI scripts are set up right now, the flavour text gets shown during loading, and the tip gets shown in a 5-second pause after loading is complete. We don't want to add a 5-second pause to quickloads, so we'd have to change the GUI scripts, not the game code, to enable tips during quickloads. I've added a new GUI state variable "quickloading" so that GUI scripts can tell the difference between a quick load and a slow one, in case they want to do this. But I'm not sure whether we want to (a) change the GUI files for the existing maps that use the system, or (b) redesign it more sweepingly so that the tips and text can be placed on an entity, given default values, and modified in DR. The maps that use the system are Score to Settle, Reputation to Uphold, and St Lucia, plus NHAT uses the same mechanism as a kind of loading progress bar. I've figured out how we could change the existing GUI scripts to make it work the way you suggest, but not how to implement Tels' suggestion of a separate GUI. I've not done GUIs before. The work so far is complete and usable -- Tips will show during loads of save games too -- so I'll commit it in the meantime. |
|
|
at rev 6503 game/game_local.cpp |
|
|
"But I'm not sure whether we want to (a) change the GUI files for the existing maps that use the system, or (b) redesign it more sweepingly so that the tips and text can be placed on an entity, given default values, and modified in DR." a) I don't think that's necessary. Having them appear during load is a big improvement already. We could see about creating a separate list of "quick tips" that could play during quickloads for authors that want that. I haven't done any gui work for a while, but maybe we could look into this when we get to that stage of the prologue project. b) Not sure that level of customization is necessary.... |
|
|
I need to put in a fix for an bug that grayman found and patched while I was on holiday. The new "quickloading" setting was causing a crash when launching a map from the console, which doesn't activate any GUIs. It'd be better if we amend the scripts for the 3 maps that use the system already. At the moment I have logic that says "activate the tips and flavour text during loading of save games, but not during a quick reload" and that logic is sitting in the game code. But it belongs in the GUI scripts really, and there'll be no way to show short tips only during quickloading unless I activate the GUI for all loading events including quickloads. So to enable tips during quickloads but disable flavour text, we'll have to tweak the scripts in your two missions. I can do that if you don't mind updates being published with 2.04. And as you say, we can do what we want with St Lucia's GUIs because we're re-releasing it anyway. |
|
|
Commit 6504 is grayman's patch for the bug mentioned above. Commit 6505 is my fix for the bug and patch. I removed the "slow loading only" logic from the game code. I don't think we want that logic hard-coded in the game DLL -- it'd be inflexible. GUI scripts now have access to a "quickloading" flag so they can handle the logic themselves. The cost is that your maps (the only ones so far other than St Lucia that have flavour text) will need that script tweak to stop the flavour text showing during a quickload. If you don't want the scripts tweaking, I'll look for another way to preserve behaviour for those maps. game/game_local.cpp |
|
|
Re-assigned to myself to (1) finalise this fix after we've discussed it, and (2) to update the wiki. |
|
|
Do I have two missions that use this method? I thought I had only one--A Score to Settle. Does reputation use this? I thought I went with a set text. |
|
|
You're right. The only maps using the "OnRandomValueInitialised" event (which is what I've tweaked) are St Lucia and Score. And they both use it for this purpose, displaying random text. |
|
|
Ok, we'll sort this out for them individually for 2.04 then |
|
|
@Springheel: forwarded to you in case you want to keep it open until we amend the maps. The code and wiki changes are complete. |
|
|
This might not be relevant now, but it just occurred to me that another place to put tool tips would be the "click to start" screen--no artificial pausing necessary, and it wouldn't require the mapper t do anything. |
|
|
Ah, you mean a standard set we could simply apply to all missions, taking advantage of a GUI that's common to them all? That would be very useful. I did do the training mission when I discovered TDM, but I only learned about leaning into doors through the tips when playing Score. I'm sure it'd be helpful for most new players. Do you want me to prep a version of the GUI for A Score to Settle that hides the flavour text on quickloads? What I did to enable the feature is still fresh in my mind so I could probably cover it off and test it in 5 minutes... |
|
|
Sure, if you don't mind. The benefit of using the attack screen is that it's under our control, yet mappers can still customize flavour text for their loading screen if they wish. |
|
|
I've attached the amended GUI file to this tracker since it's the only extant example of the system in use :) In the attached version I've suppressed *both* types of text for quickloads. I did prep a version (and still have it) that allowed the brief tip text during quick loads, but I couldn't read it so I left it out. There's no 5-second pause at the end of map load for quickloads so to show short tips, you have to move them to the Text::Flavour box. But even that didn't work well, because quickloads on my 4-yr old system take less than a second, and we probably *don't* want to slow that down, so there's no opportunity for the player to read any text. |
|
|
For the attack screen idea, are you thinking that we start it off with the tip texts from Score (or suggestions from the forum), in a gui file that mappers can customise? Is the attack screen already a gui, or do we need to tweak game code to allow it? |
|
|
I was thinking the attack screen would be controlled by us. Mappers could still customize their own tips for their loading screen. As for whether the former is a gui, I don't know. |
 |
@Spring: Can you summarize what's still needed to close out this issue? There's an awful lot of text here to satisfy the original observation that saved games don't display the tips, which appears to have been fixed in 2.04. |
|
|
I think this one can be closed...I'll open a new one for the additional idea that came up. |
- Anonymous
