View Issue Details

IDProjectCategoryView StatusLast Update
0000289DarkRadiantGUIpublic07.05.2007 19:37
ReporterSneaksieDave Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status confirmedResolutionopen 
Product Version0.9.0 
Summary0000289: ESC to close dialogs with Cancel
DescriptionAs a standard convenience to users, it is suggested that ESC close dialogs which have a Cancel button.

There might be more, but here are three examples I know of at this time:

RMB -> Create Entity
RMB -> Create Model
Entity Tab -> Add Property
TagsNo tags attached.

Activities

greebo

greebo

04.05.2007 12:19

administrator   ~0000617

AFAIK, there is no standard behaviour in any of DarkRadiant's GTK dialog. I can implement that in gtkutil/DialogWindow.h but this will not cover every dialog by far.

We'll have to track down every single of these I guess.
orbweaver

orbweaver

04.05.2007 13:32

developer   ~0000618

Didn't we already have an issue for this, and after discussion agree that using Alt-C for Cancel would be acceptable?

Alternatively, it MAY be possible to implement such behaviour with .gtkrc files. I would rather not have code-level callbacks for this sort of thing since it is really a GTK issue not an application issue.
SneaksieDave

SneaksieDave

07.05.2007 03:01

developer   ~0000628

Just as an example, refer to open map dialog:
Ctrl-O opens it, ESC closes it. Very standard behavior (in windoze at least).
greebo

greebo

07.05.2007 19:21

administrator   ~0000633

Maybe we find a one-line-way of implementing this, like:

gtkutil::DialogWindow::connectESCToWidget(GtkWidget* widget);

?
orbweaver

orbweaver

07.05.2007 19:24

developer   ~0000634

I guess that would be OK, as long as all of the dialogs inherited from the same base class.
greebo

greebo

07.05.2007 19:37

administrator   ~0000635

I think dialogs wouldn't even have to derive from the DialogWindow class (but this would of course be cleaner), as it's just a static method and a static GTK callback. It basically could be used for every widget/window.

Issue History

Date Modified Username Field Change
03.05.2007 23:16 SneaksieDave New Issue
04.05.2007 12:19 greebo Note Added: 0000617
04.05.2007 12:19 greebo Status new => confirmed
04.05.2007 13:32 orbweaver Note Added: 0000618
07.05.2007 03:01 SneaksieDave Note Added: 0000628
07.05.2007 19:21 greebo Note Added: 0000633
07.05.2007 19:24 orbweaver Note Added: 0000634
07.05.2007 19:37 greebo Note Added: 0000635