 |
The path seems to be correct, writes work correctly with png's. I assume that its the same issue that causes the mission preview shots to cause a crash. The thread about this is at : http://forums.thedarkmod.com/topic/13457-screenshot-f12-locks-up-doom3/ As I haven't really played with the IL stuff, I'll assign this to greebo for now. @greebo - you can assign it back if you're busy atm. |
 |
I think I've fixed this for JPEGs. In il_jpeg: Since RGB_PIXELSIZE was changed to 4, the conversion to RGB is short one colour component. This results in an error being thrown by DevIL, causing screenshots to crash. Revision 5388: lib/devil/il_jpeg.c win32/devil/lib/DevIL.lib win32/devil/lib/devil.pdb |
 |
Issue fixed, thank you Taaaki, this also fixes the crash with viewing jgp's in the download missions menu. |
 |
At least two people have reported that this is still crashing. |
|
|
The fix for screenshots is from revision 5388 onwards, so make sure that your binaries are the same or later revision than that (console should tell you). |
 |
Trying to take a screenshot under linux (without D3 installed, not sure if this is important) still crashes with this message: ]screenshot Bogus input colorspace ModelGenerator memory: No LOD entries. pure virtual method called terminate called without an active exception signal caught: Aborted si_code -6 Trying to exit gracefully.. pure virtual method called terminate called recursively double fault Aborted, bailing out shutdown terminal support r_screenshot_format is jpg for me. |
|
|
A cursory look into the code shows that libjpg expects RGB to be 3 pixels, but the fix for 0002982 talks about setting it to 4 (RGBA?). So maybe there is some mismatch here. |
|
|
taaaki - You can reassign this to me, I have a better way of dealing with this, and patches. I've upgraded the existing TGA writer, and I plan to move over the screenshot functionality to use that anyway. The TGA writer by default will use a 4 channel TGA, I will add in a second version to write 3 channel TGAs for use with screenshots, where the alpha channel will always be redundant (and drop file sizes by 25%). This should also fix the current Devil loading which seems a bit wonky (tho it could be the screenshot function writing a bad header, but that'll be replaced by this anyway.) |
|
|
I am not sure what a TGA writer has to do with the JPG screenshots crashing. |
|
|
Can anyone confirm that this happens when D3 is installed? If it only happens when running standalone then we should leave it for 1.09. |
|
|
It also appears with D3 installed. It really has to do with the linux libDevil being different (we use the systemlib on linux, not the one compiled in on windows). On windows, the lib expects 4 bytes per pixel (RGBA), so we send it that. The lib on linux expects 3 pixels (RGB), so it barfs when it gets 4 pixel. (or vice, versa, I am not sure on the specific counts). |
 |
Since the engine requires any image to be 4 bpp the only easy solution is to use our own jpeg lib, just like we did before. The sconscript should be easy to do, I might even find some time to look into it. |
|
|
Added the sconscript.libjpeg and adjusted the sconscripts to use the local libjpeg instead of the system one. |
|
|
This still does not work with v1.08 on Linux for whatever reasons, screenshots in JPG format still crash TDM. |
 |
Closing as this is an ancient report. Screenshots work for me on current SVN. |
- Anonymous
