 |
As of 12852, the flash still occurs. |
|
|
What is the difference between these two lamp entities? The first emits the white flash when switched on and off, and the second does not. I can't see a single significant difference between them. :wacko: -------------------------- entityDef atdm:streetlamp_square_01_lit { "inherit" "atdm:static_electric_light_lit_base" "model" "models/darkmod/lights/non-extinguishable/streetlamps/streetlamp_01.ase" "editor_setKeyValue model" "models/darkmod/lights/non-extinguishable/streetlamps/streetlamp_01.ase" "editor_displayFolder" "Lights/Model Lights, Static/Switchable/Streetlamps/Electric" "skin" "lights/streetlamp01_colorme" "skin_lit" "lights/streetlamp01_colorme" "skin_unlit" "lights/streetlamp01_unlit" "editor_usage" "A lit standing street lamp with a square top. Can be switched on and off." "light_center" "0 0 93" "editor_setKeyValue light_center" "0 0 93" "_color" "0.46 0.46 0.66" "noshadows" "0" "noshadows_lit" "1" } ------------------------------------------ entityDef atdm:streetlamp_spot_lit { "inherit" "atdm:static_electric_light_lit_base" "model" "models/darkmod/lights/non-extinguishable/streetlamps/streetlampspot.ase" "editor_setKeyValue model" "models/darkmod/lights/non-extinguishable/streetlamps/streetlampspot.ase" "editor_displayFolder" "Lights/Model Lights, Static/Switchable/Streetlamps/Electric" "skin" "lights/streetlampspot_colorme" "skin_lit" "lights/streetlampspot_colorme" "skin_unlit" "lights/streetlampspot_unlit" "editor_usage" "A lit standing street lamp with a shade on top, creating a square light spot. Can be switched on and off." "light_center" "-16 0 100" "editor_setKeyValue light_center" "-16 0 100" "texture" "lights/biground1" "_color" "0.46 0.46 0.66" "noshadows" "0" "noshadows_lit" "1" } |
|
|
Ok, so the problem has something to do with this texture, that is inherited by most electric lights: "texture" "lights/biground1_streetlamp_4fold_snd" Here's the shader it refers to: Quote lights/biground1_streetlamp_4fold_snd { { forceHighQuality map textures/lights/biground1_streetlamp_4fold red Parm0 / (sound*sound) green Parm1 / (sound*sound) blue Parm2 / (sound*sound) zeroClamp } } The sound used is: "s_shader" "light_flicker_104" |
|
|
I am pretty sure it is a subtle code change (and my bet would be one from Serpentine) that changes the way "infinity" is handled. E.g. in the very first stage, the sound value is 0, and something (light value?) gets divided by zero, instead of 1 or something, so the resulting light level is "infinity", which gets clipped to white. But impossible to say w/o knowing which revision introduced the problem. |
 |
Going to take a look at this, I seem to remember that when it was first noticed I tested a revision from before render changes and it was still present. Either way, it's something that needs to be fixed. |
|
|
I have applied a temporary fix for the 1.08 testing, I will resolve it more completely in the future. |
|
|
Is this uploaded yet? I'm still seeing the flash. |
|
|
The temp workaround is acceptable for 1.08 - might need to tweak the exact value. Suspended the task and will target for 1.09. |
 |
Exactly where is the workaround? In the support files? In the engine? With the engine and dll I built late Sunday night, I still see the white flash. This was after Serps' comment "I have applied a temporary fix for the 1.08 testing". |
|
|
Sorry, its fixed in the commit from last night regarding division by 0, in material.cpp. There are actually two bugs in here, the previous one was from lights which were not getting a soundshader set from an entity, the second is the triggering of an entity to be on, but in the same frame that it is turned on, the sound is not yet at a position where a sample is valid. Both are now resolved. But both are now resolved, as well as I'm sure other errors in materials which could try to divide by 0. |
|
|
Rebuilt with the new changes and the flash is gone. I tested 3 different electric lights that had the problem. Committed a new engine and windows dll in rev 13000. |
- Anonymous
