 |
Just make sure that moss patches on moving things (like an elevator) are still working correctly - they might still need some sort of collision check. |
 |
Yes, I checked moss patches on elevators yesterday and found they don't stick to elevators. They just fall through to whatever's below. The moss patch generating script says to only stick to worldspawn and func_statics. Everything else is ignored. And I'm not removing the collision check anyway. I'm just skipping the damage part of the collision code. |
|
|
These moveables were attempting to cause damage when struck by a passing AI. Since damage could never be inflicted because of low masses and alleged velocities (they never really were moving), the damage-check code was being run but would never produce any damage. Added a check to the damage-check part to skip it if the moveable involved is not pushable. If it’s not flying through the air, it shouldn’t cause damage. rev. 5488: Moveable.cpp |
|
|
Er, I think you misunderstood my comment. That they don't stick to elevators is a bug, that should be eventually be fixed. (track it?) Anyway, with this is fixed or not, the check on "not pushable" is still wrong. For instance, heavy barrels can be set to "not pushable" (so the player cannot push them around). But when such a barrel rides an elevator or moves otherwise (scripted sequence?), and then hits something, it *could* inflict damage. (The same goes for moss patches, they *might* inflict damage, even tho they probably never do. But this distinction cannot be done on the "pushable" flag). Collisions between objects A and B can always occur from both sides, A can collide into B, or B can collide into A. Please review the change again under this light. |
|
|
Fix reverted, on the expectation that the elevator problem might someday be fixed and that mission authors might choose to drop non-pushable barrels via a script. Rev. 5492. This was an optimization and not a bug fix, so I'm closing the problem as "design choice". |
- Anonymous
