 |
When english language is selected the shop initially shows only "Lockpicks". In other languages (i.e. "Polski") the shop initially shows "Lockpicks", "Triangle Lockpick" and "Snake Lockpick". The result is that in SetupInventory() adding second copy of a lockpick fails. PutItem() returns NULL and access violation follows. This bug was introduced in issue 0002376 when "lockpick-set-compression" was added. To be exact, the function CShop::CheckPicks() should not use english item names. So change this: idStr itemName = list[i]->GetName(); if ((idStr::Icmp(itemName,"Snake Lockpick") == 0) || (idStr::Icmp(itemName,"Triangle Lockpick") == 0)) into something like this: idStr itemName = list[i]->name; // private field! if ((idStr::Icmp(itemName,"#str_02201") == 0) || (idStr::Icmp(itemName,"#str_02200") == 0)) |
 |
The proposed change was not working, since the itemName is not "#str_02201", but the name in the current language, like "Schlange". But close enough and that comment saved me from searching the cause, so thank you! Fixed with revision 0005570. |
- Anonymous
